Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  aaugustin
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:  fixed
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by Aymeric Augustin ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"14cddf51c5f001bb426ce7f7a83fdc52c8d8aee9"]:
 {{{
 #!CommitTicketReference repository=""
 revision="14cddf51c5f001bb426ce7f7a83fdc52c8d8aee9"
 Merged branch 'database-level-autocommit'.

 Fixed #2227: `atomic` supports nesting.
 Fixed #6623: `commit_manually` is deprecated and `atomic` doesn't suffer
 from this defect.
 Fixed #8320: the problem wasn't identified, but the legacy transaction
 management is deprecated.
 Fixed #10744: the problem wasn't identified, but the legacy transaction
 management is deprecated.
 Fixed #10813: since autocommit is enabled, it isn't necessary to rollback
 after errors any more.
 Fixed #13742: savepoints are now implemented for SQLite.
 Fixed #13870: transaction management in long running processes isn't a
 problem any more, and it's documented.
 Fixed #14970: while it digresses on transaction management, this ticket
 essentially asks for autocommit on PostgreSQL.
 Fixed #15694: `atomic` supports nesting.
 Fixed #17887: autocommit makes it impossible for a connection to stay
 "idle of transaction".
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  aaugustin
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * owner:  jacob => aaugustin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  jacob
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by k4ml):

 Another note, the rollback when exception occurred not introduced by this
 patch, it's already in the committed code since Django-1.3, this patch
 only raise the exception instead of TransactionManagementError.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  jacob
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by k4ml):

 I think the docs only require you to do rollback manually if you managed
 to catch the exception. In this case the exception goes uncaught from your
 function, thus we're having this issue since we don't know that we need to
 do a rollback. So I have added a note to the docs on django doing rollback
 in case there's an exception goes uncaught the function under
 commit_manually.

 Also the previous patch does not apply cleanly anymore to django master
 (github.com/django/django).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  jacob
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by aaugustin):

 #18449 was a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  jacob
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by akaariai):

 * needs_docs:  0 => 1


Comment:

 The patch needs a docs change. As currently
 
[https://docs.djangoproject.com/en/dev/topics/db/transactions/?from=olddocs#django.db.transaction.commit_manually
 documented], in commit_manually you must do a rollback manually, even if
 an exception is risen. Granted, the code does the rollback for you anyways
 currently.

 This is a change (even if a small one) to documented behavior, so I think
 a heads-up post to django-developers should be done. I myself am +0 to
 this change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  jacob
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  SVN
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
 Reporter:  guettli  |Owner:  jacob
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  SVN
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by umbrae@…):

 * ui_ux:   => 0


Comment:

 Just a "me, too" here. This is a serious issue for us on our high-volume
 production site at Readability.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
   Reporter:  guettli|  Owner:  jacob
   Type: | Status:  assigned
  Cleanup/optimization   |  Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  1
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by julien):

 * needs_tests:  0 => 1


Comment:

 This patch would need to also include tests to stand any chance of getting
 checked in.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
   Reporter:  guettli|  Owner:  jacob
   Type: | Status:  assigned
  Cleanup/optimization   |  Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by haavikko):

 * cc: haavikko (added)
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
   Reporter:  guettli|Owner:  jacob
   Type: |   Status:  assigned
  Cleanup/optimization   |Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-

Comment (by jart):

 I submitted a trivial patch for this three years ago and I'm still getting
 emails?  Seriously?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
-+-
   Reporter:  guettli|Owner:  jacob
   Type: |   Status:  assigned
  Cleanup/optimization   |Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by anonymous):

 * severity:   => Normal


Comment:

 The problem persists in Django 1.3... I spent 6 hours trying to DEBUG it.
 I used autocommit in the same code I found out real cause of problem. Hope
 it helps someone :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
---+
  Reporter:  guettli   | Owner:  jacob
Status:  assigned  | Milestone:   
 Component:  Database layer (models, ORM)  |   Version:  SVN  
Resolution:|  Keywords:   
 Stage:  Accepted  | Has_patch:  1
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * owner:  nobody => jacob
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6623: commit_manually decorator: Better error message (show exception)

[Django]

#6623: commit_manually decorator: Better error message (show exception)
---+
  Reporter:  guettli   | Owner:  nobody
Status:  new   | Milestone:
 Component:  Database layer (models, ORM)  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by daybreaker):

 Is there anybody working on this, or any plan to adopt this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---