Re: [Django] #6799: Update to truncate words methods to make them more callable

[Django]

#6799: Update to truncate words methods to make them more callable
+---
  Reporter:  bret   | Owner:  adamfast
Status:  assigned   | Milestone:  1.2 
 Component:  Contrib apps   |   Version:  SVN 
Resolution: |  Keywords:  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by SmileyChris):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6799: Update to truncate words methods to make them more callable

[Django]

#6799: Update to truncate words methods to make them more callable
---+
  Reporter:  bret  | Owner:  adamfast
Status:  assigned  | Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by Travis Cline ):

  * needs_better_patch:  1 => 0

Comment:

 Added Chris' suggestion, moved to unittest.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6799: Update to truncate words methods to make them more callable

[Django]

#6799: Update to truncate words methods to make them more callable
---+
  Reporter:  bret  | Owner:  adamfast
Status:  assigned  | Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  1 |  
---+
Changes (by SmileyChris):

  * needs_better_patch:  0 => 1
  * stage:  Ready for checkin => Accepted

Comment:

 If you're going to do this, you may as well only do the appending of
 `end_text` if it's not false. This will avoid adding trailing whitespace.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6799: Update to truncate words methods to make them more callable

[Django]

#6799: Update to truncate words methods to make them more callable
+---
  Reporter:  bret   | Owner:  adamfast
Status:  assigned   | Milestone:  1.2 
 Component:  Contrib apps   |   Version:  SVN 
Resolution: |  Keywords:  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by jacob):

  * milestone:  1.1 => 1.2

Comment:

 Unfortunately this is a feature add and we're past feature freeze. Kicking
 to 1.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6799: Update to truncate words methods to make them more callable

[Django]

#6799: Update to truncate words methods to make them more callable
+---
  Reporter:  bret   | Owner:  adamfast
Status:  assigned   | Milestone:  1.1 
 Component:  Contrib apps   |   Version:  SVN 
Resolution: |  Keywords:  
 Stage:  Ready for checkin  | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by adamfast):

  * needs_better_patch:  1 => 0
  * stage:  Accepted => Ready for checkin
  * needs_tests:  1 => 0
  * milestone:  => 1.1

Comment:

 The latest diff (is the right one, I screwed up entering the other ones)

 Can't find documentation for django.contrib.utils to update the
 documentation, but the change is not made to the truncatewords builtin
 filter so no public doc change necessary there (the docstrings of the
 affected functions have been updated, however).

 I did fix earlier patch's truncate_words_html method to not cause existing
 tests to fail.

 There were no existing tests (aside from the template tests, which
 wouldn't have access to this method) for any of the functions in
 django.contrib.utils.text, so I've added regressiontests.utils.text to
 give them a workout and updated the regressiontests.utils.tests file to
 run them.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6799: Update to truncate words methods to make them more callable

[Django]

#6799: Update to truncate words methods to make them more callable
---+
  Reporter:  bret  | Owner:  adamfast
Status:  assigned  | Milestone:  
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  1 |  
---+
Changes (by adamfast):

  * owner:  nobody => adamfast
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---