Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
--+--
 Reporter:  gwilson   |Owner:  jorgecarleitao
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cc35bd461d35da2b03c0a1a8ff92123d716db9a9"]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc35bd461d35da2b03c0a1a8ff92123d716db9a9"
 Fixed #7599 -- Added get_user_permissions to ModelBackend.

 Thanks to @gdub for the report and intial patch and
 @charettes and @timgraham for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f54dd75019fba5bbd9f79e383d4d67a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
--+--
 Reporter:  gwilson   |Owner:  jorgecarleitao
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by jorgecarleitao):

 * needs_better_patch:  1 => 0


Comment:

 See
 
https://github.com/jorgecarleitao/django/commit/ac217515b5290b6bab8a7a78d38bf309e063b3f6

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.64eabcb8401ffc214d6d215e78d8bde6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
--+--
 Reporter:  gwilson   |Owner:  jorgecarleitao
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by timo):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0
 * needs_better_patch:  0 => 1


Comment:

 Please uncheck "Patch needs improvement" when you update the PR, thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ac76aa5b5336804986e111266709c14e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
--+--
 Reporter:  gwilson   |Owner:  jorgecarleitao
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by jorgecarleitao):

 * status:  new => assigned
 * owner:   => jorgecarleitao


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c7f78504e2030fd0089fb92ceb405eb5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
--+
 Reporter:  gwilson   |Owner:
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by jorgecarleitao):

 * cc: jorgecarleitao (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.530ef4fcb6e0583afaf05059fc1eb6f6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
--+
 Reporter:  gwilson   |Owner:
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by jorgecarleitao):

 timo is right. I added a pull request,
 https://github.com/django/django/pull/2127, that fixes the docs of
 ModelBackend and apply the patch.

 I didn't added a test case because, like timo argued, the backend is not
 tested anyway. I will fill a ticket reporting this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.975975fd3db0829d0942dd61915d213b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
--+
 Reporter:  gwilson   |Owner:
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * needs_docs:  0 => 1


Comment:

 Documentation isn't correct - this isn't a method on the `User` object,
 but on rather on `ModelBackend` which is documented at the bottom of
 `docs/ref/contrib/auth.txt`, although none of the methods for the backend
 are documented so presumably if we documented this one we'd want to
 document the rest. This ticket also has "needs tests" set, and while I
 imagine we could test the ability to override the method in a custom
 backend, I'm not convinced it's necessary as it doesn't look like the rest
 of the backend is tested in such a way.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1d9d149b687eaa9b52f9280b932fdb47%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
-+--
  Reporter:  gwilson | Owner: 
Status:  new | Milestone: 
 Component:  Authentication  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  1  
Needs_better_patch:  0   |  
-+--
Changes (by ubernostrum):

  * milestone:  1.3 =>

Comment:

 1.3 is feature-frozen now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
-+--
  Reporter:  gwilson | Owner: 
Status:  new | Milestone:  1.3
 Component:  Authentication  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  1  
Needs_better_patch:  0   |  
-+--
Changes (by jezdez):

  * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
-+--
  Reporter:  gwilson | Owner: 
Status:  new | Milestone:  1.3
 Component:  Authentication  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by jezdez):

  * needs_docs:  1 => 0
  * stage:  Design decision needed => Accepted
  * milestone:  => 1.3

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #7599: add get_user_permissions method to ModelBackend

[Django]

#7599: add get_user_permissions method to ModelBackend
-+--
  Reporter:  gwilson | Owner: 
Status:  new | Milestone: 
 Component:  Authentication  |   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  1   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by jkistler):

 Added documentation. Patch passes all existing auth tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.