Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  closed | Milestone:  
1.3
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution:  fixed  |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  0 
 
Needs_better_patch:  0  |  
+---
Changes (by carljm):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 Closing this ticket to avoid any further confusion, based on mailing list
 discussion here: http://groups.google.com/group/django-
 developers/browse_thread/thread/e263cb72eb25f8f8

 Given that there doesn't appear to be any core dev support for the
 list_display syntax changes in the patch here, and the feature described
 by the summary/title is already present in trunk, I don't see any benefit
 to keeping this ticket open, and there appears to be a significant cost in
 confusion. The only actual "todo" I see remaining here is that the admin
 ChangeList needs a refactor; if that needs a ticket, it should get a new
 one that more clearly states that goal alone.

 Resolving as fixed because all of the capabilities requested in the ticket
 are now possible, albeit with a different syntax than originally proposed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:  
1.3
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  0 
 
Needs_better_patch:  0  |  
+---
Comment (by alekam):

 Update patch and wiki page according to Yuri Baburov (buriy)
 recomendations

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:  
1.3
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  0 
 
Needs_better_patch:  0  |  
+---
Changes (by buriy):

  * needs_docs:  0 => 1

Comment:

 Patch is looking good, except few small things:

 1) value_map is not a function what can be read from its name, but a dict.
 If it is used mostly for choices, it should be named so.

 2) There's no line in docs mentioning value_map is applied *before*
 filters?

 3) I'm not sure if we need 200 Kb fixture file called listcolumns.json
 Can we strip it to few lines, showcasing all the features?
 Tests themselves are very good!

 4)
 This is backward compatibility hack one copied from
 django.contrib.admin.util.label_for_field, but it's completely
 undocumented (and i'm not sure if it's required in django 1.3!):
 {{{
 145 if self.field_name == '__unicode__':
 146 self.header =
 force_unicode(model._meta.verbose_name)
 147 elif self.field_name == '__str__':
 148 self.header =
 smart_str(model._meta.verbose_name)
 }}}
 Why can't you just reuse label_for_field to always provide header info for
 you?

 5) Wiki docs don't mention how ListColumn can be used together with
 list_display_links.

 6) list_display_links should take ListColumn, or some special instance,
 but not its field_name attribute, or you might have 2 fields selected if
 they just have different filters applied to the same model or modeladmin
 attribute.
 However this might be mention in docs as a known limitation and workaround
 shown.

 7) Typos in wiki docs: 'tagging_autocomplite_tags' ->
 'tagging_autocomplete_tags', 'calable' -> 'callable'

 8) Wiki docs don't list admin filters that can be used now (boolean_icon)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:  
1.3
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  0  |   Needs_tests:  0 
 
Needs_better_patch:  0  |  
+---
Changes (by alexkoshelev):

 * cc: alexkoshelev (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:  
1.3
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  0  |   Needs_tests:  0 
 
Needs_better_patch:  0  |  
+---
Changes (by alekam):

  * needs_better_patch:  1 => 0
  * needs_docs:  1 => 0
  * needs_tests:  1 => 0
  * milestone:  => 1.3

Comment:

 Wiki page with this ticket goals and documentation - ListColumns

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:
 
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  1 
 
Needs_better_patch:  1  |  
+---
Changes (by renatopedigoni):

 * cc: renatopedig...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:
 
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  1 
 
Needs_better_patch:  1  |  
+---
Changes (by alekam):

 * cc: kame...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:
 
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  1 
 
Needs_better_patch:  1  |  
+---
Comment (by alekam):

 update patch to django rev. 14124

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8054: Move method properties for admin list customisation to ModelAdmin

[Django]

#8054: Move method properties for admin list customisation to ModelAdmin
+---
  Reporter:  Daniel Pope   | Owner:  
brosner
Status:  assigned   | Milestone:
 
 Component:  django.contrib.admin   |   Version:  
SVN
Resolution: |  Keywords:
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  1 
 
Needs_better_patch:  1  |  
+---
Changes (by anonymous):

 * cc: a...@andybak.net (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---