Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
--+---
 Reporter:  andrew.mcmurry@…  |Owner:  jkocherhans
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  1.1-beta-1
 Severity:  Normal|   Resolution:  fixed
 Keywords:  formset   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---

Comment (by loewis):

 In [16950]:
 {{{
 #!CommitTicketReference repository="" revision="16950"
 Merged revisions
 
16743,16745,16747-16750,16752-16754,16756-16760,16770,16773-16800,16802-16804,16806,16808,16811,16813,16815,16817-16826,16829-16833,16835-16836,16838-16843,16845-16858,16860-16866,16868,16871-16877,16882-16890,16893-16947
 via svnmerge from
 https://code.djangoproject.com/svn/django/trunk

 
   r16743 | gabrielhurley | 2011-09-09 23:36:58 +0200 (Fr, 09 Sep 2011) | 2
 lines

   Fixed #16791 -- Updated a broken URL in the README file. Thanks to
 paulcwatts for the report and patch.
 
   r16745 | Alex | 2011-09-09 23:45:58 +0200 (Fr, 09 Sep 2011) | 1 line

   Switch to using explicit new-style division behavior, rather than
 relying on teh classic behavior.
 
   r16747 | SmileyChris | 2011-09-10 00:32:38 +0200 (Sa, 10 Sep 2011) | 1
 line

   Fix and test for cleaning a non-string value in a URLField
 
   r16748 | gabrielhurley | 2011-09-10 00:33:28 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #16786 -- Minor cleanups in the memcached section of the caching
 topic guide. Thanks to jamesp for the report and patch.
 
   r16749 | jbronn | 2011-09-10 00:34:23 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16408 -- Fixed conversion of dates, and other problems with the
 SpatiaLite backend.
 
   r16750 | jbronn | 2011-09-10 00:47:18 +0200 (Sa, 10 Sep 2011) | 1 line

   Removed extra call to `syncdb` that slipped in with r16749.
 
   r16752 | SmileyChris | 2011-09-10 00:57:12 +0200 (Sa, 10 Sep 2011) | 1
 line

   Fixes #16664 -- URLField's to_python method fails with ValueError on
 some urls on python 2.7. Based on patch by zigzag.
 
   r16753 | russellm | 2011-09-10 01:02:33 +0200 (Sa, 10 Sep 2011) | 1 line

   Added two pointless query repeats to work around a known issue with
 MySQL that was causing failures in our test suite.
 
   r16754 | gabrielhurley | 2011-09-10 01:25:48 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #16782 -- Corrected a broken cross-reference to the database
 engine setting in the tutorial. Thanks to mjumbewu for the report and
 patch.
 
   r16756 | kmtracey | 2011-09-10 02:05:48 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #15722: ensure formsets evaluate to True even if they have no
 forms. Thanks mlavin.
 
   r16757 | jbronn | 2011-09-10 02:29:34 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #13670 -- Comparisons with the spatial adapter won't blow up in
 some corner cases.  Thanks, milosu for the bug report and jpaulett for the
 patch.
 
   r16758 | russellm | 2011-09-10 02:46:38 +0200 (Sa, 10 Sep 2011) | 1 line

   Added protection against spoofing of X_FORWARDED_HOST headers. A
 security announcement will be made shortly.
 
   r16759 | russellm | 2011-09-10 02:46:48 +0200 (Sa, 10 Sep 2011) | 1 line

   Corrected an issue which could allow attackers to manipulate session
 data using the cache. A security announcement will be made shortly.
 
   r16760 | russellm | 2011-09-10 02:47:00 +0200 (Sa, 10 Sep 2011) | 1 line

   Altered the behavior of URLField to avoid a potential DOS vector, and to
 avoid potential leakage of local filesystem data. A security announcement
 will be made shortly.
 
   r16770 | Alex | 2011-09-10 03:53:56 +0200 (Sa, 10 Sep 2011) | 1 line

   Make ``Formset.__getitem__`` O(1), rather than O(n).  If you override
 ``__iter__`` you now need to also override ``__getitem__`` for consistant
 behavior.  Thanks to Carl and Russ for the review.
 
   r16773 | Alex | 2011-09-10 04:42:05 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #11404.  Added ``FormSet.has_changed``, for consistancy with
 ``Form.has_changed``. Thanks to michelts for the patch.
 
   r16774 | Alex | 2011-09-10 04:52:37 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16793. Added more cross referencing to the load tag's
 documentation.  Thanks to bluejeansummer for the patch.
 
   r16775 | jbronn | 2011-09-10 05:04:30 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16790 -- Modified the geographic admin to work after r16594.
 Thanks, jdiego, for the bug report and patch.
 
   r16776 | carljm | 2011-09-10 05:26:13 +0200 (Sa, 10 

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
--+---
 Reporter:  andrew.mcmurry@…  |Owner:  jkocherhans
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  1.1-beta-1
 Severity:  Normal|   Resolution:  fixed
 Keywords:  formset   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by ramiro):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [16918]:
 {{{
 #!CommitTicketReference repository="" revision="16918"
 Fixed #8160 -- Made sure `modelformset_factory` takes in account `fields'
 and `exclude` ModelForm options.

 Thanks Andrew McMurry for the report and Claude Paroz for creating these
 tests.

 (Actually, this had been fixed in r10619 but the tests added then exercise
 the
 code in the context of ModelAdmin. This commit adds more generic tests.)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+-
   Reporter:  andrew.mcmurry@…  |  Owner:  jkocherhans
   Type:  Bug   | Status:  assigned
  Milestone:|  Component:  Forms
Version:  1.1-beta-1|   Severity:  Normal
 Resolution:|   Keywords:  formset
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+-
Changes (by claudep):

 * ui_ux:   => 0
 * needs_tests:  1 => 0


Comment:

 This works on current trunk. I suggest to commit the attached test and
 then close this ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+-
   Reporter:  andrew.mcmurry@…  |  Owner:  jkocherhans
   Type:  Bug   | Status:  assigned
  Milestone:|  Component:  Forms
Version:  1.1-beta-1|   Severity:  Normal
 Resolution:|   Keywords:  formset
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  0
+-
Changes (by julien):

 * type:   => Bug
 * severity:   => Normal
 * easy:   => 0


Comment:

 #8071 is very likely a symptom of the same problem. Both tickets should
 probably be addressed at the same time.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+---
  Reporter:  andrew.mcmu...@ifi.uio.no  | Owner:  jkocherhans
Status:  assigned   | Milestone: 
 Component:  Forms  |   Version:  1.1-beta-1 
Resolution: |  Keywords:  formset
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  1  
Needs_better_patch:  0  |  
+---
Changes (by alanjds):

 * cc: alan.just...@yahoo.com.br (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+---
  Reporter:  andrew.mcmu...@ifi.uio.no  | Owner:  jkocherhans
Status:  assigned   | Milestone: 
 Component:  Forms  |   Version:  1.1-beta-1 
Resolution: |  Keywords:  formset
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  1  
Needs_better_patch:  0  |  
+---
Comment (by alanjds):

 It looks like fixed at 1.1.1, but I cant run unittests.

 Replying to [comment:9 alanjds]:
 > Attached patch appears to target a very old revision. I will fix this
 bug in next 3 weeks (because I need it fixed), but for that I'm asking
 some guiedance to make not much mistakes. I will patch against 1.1-beta1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+---
  Reporter:  andrew.mcmu...@ifi.uio.no  | Owner:  jkocherhans
Status:  assigned   | Milestone: 
 Component:  Forms  |   Version:  1.1-beta-1 
Resolution: |  Keywords:  formset
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  1  
Needs_better_patch:  0  |  
+---
Comment (by Alex):

 I'll also note that this looks like a dupe of #10208.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+---
  Reporter:  andrew.mcmu...@ifi.uio.no  | Owner:  jkocherhans
Status:  assigned   | Milestone: 
 Component:  Forms  |   Version:  1.1-beta-1 
Resolution: |  Keywords:  formset
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  1  
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * milestone:  1.1 =>

Comment:

 This is not a critical bug for 1.1, removing milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+---
  Reporter:  andrew.mcmu...@ifi.uio.no  | Owner:  jkocherhans
Status:  assigned   | Milestone:  1.1
 Component:  Forms  |   Version:  1.1-beta-1 
Resolution: |  Keywords:  formset
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  1  
Needs_better_patch:  0  |  
+---
Changes (by alanjds):

  * version:  SVN => 1.1-beta-1
  * milestone:  => 1.1

Comment:

 Attached patch appears to target a very old revision. I will fix this bug
 in next 3 weeks (because I need it fixed), but for that I'm asking some
 guiedance to make not much mistakes. I will patch against 1.1-beta1.

 Roadmap: (to source:django/forms/models.py#8691 )[[BR]]
 - Compare rev8691 with 1.1-beta1[[BR]]
 - Merge diff into rev8691 and study results[[BR]]
 - Merge diff into 1.1-beta1 and run tests[[BR]]
 - Force tests to pass[[BR]]

 I found no tag for 1.1-beta1. So, if someone knows rev. number for this,
 please comment or msg me.

 Thanks in advance.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+---
  Reporter:  andrew.mcmu...@ifi.uio.no  | Owner:  jkocherhans
Status:  assigned   | Milestone: 
 Component:  Forms  |   Version:  SVN
Resolution: |  Keywords:  formset
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  1  
Needs_better_patch:  0  |  
+---
Changes (by jkocherhans):

  * owner:  justinf => jkocherhans
  * status:  new => assigned

Comment:

 Taking this on with a few other related issues.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8160: ModelFormset ignores form properties

[Django]

#8160: ModelFormset ignores form properties
+---
  Reporter:  andrew.mcmu...@ifi.uio.no  | Owner:  justinf 
Status:  new| Milestone:  post-1.0
 Component:  Forms  |   Version:  SVN 
Resolution: |  Keywords:  formset 
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  1   
Needs_better_patch:  0  |  
+---
Changes (by punteney):

 * cc: ja...@geniusrocket.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---