Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+
 Reporter:  levity   |Owner:  loic84
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Marc Tamlyn ):

 In [changeset:"be733bf672eebb7d03061a293a2b0b03c727ab44"]:
 {{{
 #!CommitTicketReference repository=""
 revision="be733bf672eebb7d03061a293a2b0b03c727ab44"
 [1.7.x] Fixed #22510 -- Harden field removal to only None.

 Refs #8620.

 If we allow any value to remove form fields then we get name clashes
 with method names, media classes etc. There was a backwards
 incompatibility introduced meaning ModelForm subclasses with declared
 fields called media or clean would lose those fields.

 Field removal is now only permitted by using the sentinel value None.
 The docs have been slightly reworded to refer to removal of fields
 rather than shadowing.

 Thanks to gcbirzan for the report and initial patch, and several of the
 core team for opinions.

 Backport of 9fb0f5dddc4cf7f2d294af1bcde2c359cffd90a5 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.102571c11705acc46b0243c4f0038e13%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+
 Reporter:  levity   |Owner:  loic84
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Loic Bistuer ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b16dd1fe019b38d0dcdf4a400e9377fb06b33178"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b16dd1fe019b38d0dcdf4a400e9377fb06b33178"
 Fixed #8620 -- Updated the Form metaclass to support excluding fields by
 shadowing them.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.78c8e5b3eb80e64f57ae7841099b2925%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+
 Reporter:  levity   |Owner:  loic84
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Tim Graham ):

 In [changeset:"8222a48253e61f4d3c1d30156a5f9e0d59a7c56c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8222a48253e61f4d3c1d30156a5f9e0d59a7c56c"
 [1.6.x] Clarfied the ModelForm docs with respect to generated vs. declared
 fields.

 The ModelForm docs suggested that fields defined declaratively override
 default fields generated from the form Meta.

 This is conceptually wrong, especially with inheritance in mind. Meta is
 usually defined on the topmost ModelForm subclass, while fields can come
 from anywhere in the MRO, especially base classes; therefore we suggested
 that something defined in a base class override something from a subclass.

 This patch rephrases the docs around the idea that Meta is used to
 generate
 *missing* fields.

 Refs #8620, #19617.

 Thanks @mjtamlyn and @timgraham for the review.

 Backport of 54cd930baf from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.17578d068c55575fdc88ac1f8d9dc04f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+
 Reporter:  levity   |Owner:  loic84
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Tim Graham ):

 In [changeset:"54cd930baf49c45e3e91338a9f4a56d19090ff25"]:
 {{{
 #!CommitTicketReference repository=""
 revision="54cd930baf49c45e3e91338a9f4a56d19090ff25"
 Clarfied the ModelForm docs with respect to generated vs. declared fields.

 The ModelForm docs suggested that fields defined declaratively override
 default fields generated from the form Meta.

 This is conceptually wrong, especially with inheritance in mind. Meta is
 usually defined on the topmost ModelForm subclass, while fields can come
 from anywhere in the MRO, especially base classes; therefore we suggested
 that something defined in a base class override something from a subclass.

 This patch rephrases the docs around the idea that Meta is used to
 generate
 *missing* fields.

 Refs #8620, #19617.

 Thanks @mjtamlyn and @timgraham for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c499bf9584ed2e2a16556b0903e8a4b1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+
 Reporter:  levity   |Owner:  loic84
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by loic84):

 * status:  new => assigned
 * owner:  shimonrura => loic84


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2806e8af02237bef5bc99a4b0e78b550%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by loic84):

 * cc: loic@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c048ab91d9be8869f235526237f2623d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by loic84):

 This may or may not be the right solution to this issue, but this PR
 allows shadowing a declarative field and would enable the `username =
 None` example from the previous comment:
 https://github.com/django/django/pull/1382.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5025d61621009be776bf8ba5ff14b8a9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by mjtamlyn):

 At the moment, I'm definitely -0 on this change in functionality. I
 believe that `fields` and `exclude` are shortcuts and are secondary to
 actually defining the fields - i.e. the field definitions on the form
 should *always* take precedence. I believe that the subclassing issue can
 be solved by setting `username = None`on the subclass.

 In particular this introduces a disparity between `Form` and `ModelForm` -
 I don't want to recommend this as a subclassing route if it doesn't
 actually work in the general case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3a020b0a66c2ddd3fc96c42e4e78193f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by timo):

 I think this should be fine backwards compatibility-wise, but a posted a
 [https://github.com/django/django/pull/1409 PR] just to give greater
 visibility to the patch before I commit it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.50381ae73027e9ffb275f4638599321d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by mitar):

 * cc: mmitar@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by codysomerville):

 * cc: cody.somerville@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by codysomerville):

 See duplicate ticket:13971 for additional discussion/patches on this
 issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
-+--
 Reporter:  levity   |Owner:  shimonrura
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by koenb):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0
 * needs_better_patch:  1 => 0


Comment:

 Added an updated patch, that only implements leaving out an explicitly
 declared field with Meta.exclude, and does not require adding explicitly
 declared fields into the Meta.fields list like the previous patch did
 (which was backwards incompatible).

 Added a note to the documentation also.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
---+
   Reporter:  levity   |  Owner:  shimonrura
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  Forms
Version:  SVN  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  1
Patch needs improvement:  1|  Easy pickings:  0
  UI/UX:  0|
---+
Changes (by anonymous):

 * ui_ux:   => 0


Comment:

 The problem still occurs in Django 1.3
 Also, if you set form fields to Required=False, they are still required in
 form validation.
 Here is an example :

 {{{
 class RegistrationForm(forms.ModelForm):
 # Extra form
 fields
 email_confirm = forms.EmailField(widget = forms.TextInput(attrs =
 {'size':20}))
 password_confirm = forms.CharField(required=False, widget =
 forms.PasswordInput(attrs = {'size':20}))
 eula = forms.BooleanField(required=False, label=u"CGU")
 #===
 # Metadata
 #===
 class Meta:
 model = User
 fields = ('username', 'email', 'email_confirm', 'password',
 'first_name', 'last_name')
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
---+
   Reporter:  levity   |  Owner:  shimonrura
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  Forms
Version:  SVN  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  1
Patch needs improvement:  1|  Easy pickings:  0
---+
Changes (by tomchristie):

 * cc: tom@… (added)
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
+--
   Reporter:  levity|Owner:  shimonrura
 Status:  new   |Milestone:
  Component:  Forms |  Version:  SVN
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  1 |  Needs tests:  1
Patch needs improvement:  1 |
+--
Changes (by shimonrura):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 I've attached an updated patch that includes tests for the new behavior.
 However, this change in behavior breaks several other tests. One newly-
 failing test is also in the modelform tests
 (tests/regressiontests/forms/tests/models.py), but several are elsewhere
 in the test suite.

 That suggests to me that there may be lots of code built on the assumption
 that the Meta.exclude attribute ''doesn't'' affect fields explicitly
 declared in a superclass. While changing this behavior seems useful to me,
 it probably merits more consideration, to either OK the change and accept
 the consequences for users, or to provide an alternate way to achieve
 exclusion of fields inherited from superclasses (which may arguably be
 useful outside of ModelForms).

 The patch still needs work (changes to several other tests that fail as a
 result of the change).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
+--
   Reporter:  levity|Owner:  shimonrura
 Status:  new   |Milestone:
  Component:  Forms |  Version:  SVN
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  1
Patch needs improvement:  0 |
+--
Changes (by shimonrura):

 * owner:  nobody => shimonrura


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
+---
   Reporter:  levity| Owner:  nobody
 Status:  new   | Milestone:
  Component:  Forms |   Version:  SVN   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  1 
Patch needs improvement:  0 |  
+---
Changes (by rizumu):

 * cc: tom@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
---+
  Reporter:  levity| Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by kmtracey):

  * has_patch:  0 => 1
  * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
---+
  Reporter:  levity| Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by allanw):

 Is there any chance we could get this fixed in trunk sometime soon?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
---+
  Reporter:  levity| Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by marcinnowak):

 1. patch should be changed a bit to avoid "NoneType is not iterable"
 error.

 {{{
   [declared_fields.pop(f) for f in declared_fields.keys() if f not in
 (opts.fields or []) or f in (opts.exclude or [])]
 }}}

   2. this patch needs improvement - if fields aren't set in Meta class,
 overriding the default field types does not work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8620: ModelForm.Meta.exclude only excludes model fields, not form fields

[Django]

#8620: ModelForm.Meta.exclude only excludes model fields, not form fields
---+
  Reporter:  levity| Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---