Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by Ramiro Morales ):

 In [changeset:"8ab5f1fe4750105dae734764baed54bd4d22792b"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8ab5f1fe4750105dae734764baed54bd4d22792b"
 Close file after tests added in 945e033a69.

 Avoids failures on Windows. Refs #8918.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b03505812ed7d3e231656d1d3f8af852%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by anonymous):

 Amazing. Thanks everyone!!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3efb9741dd6da82095548557d6f0d691%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"945e033a6964c8c83c1c5ce5f188baf41a7a7701"]:
 {{{
 #!CommitTicketReference repository=""
 revision="945e033a6964c8c83c1c5ce5f188baf41a7a7701"
 Fixed #8918 -- Made FileField.upload_to optional.

 Thanks leahculver for the suggestion and dc and vajrasky for work
 on the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3df3836625d8dca8d73ce3615f80fdf0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  File |  Version:  master
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1
 * easy:  0 => 1


Comment:

 Patch needs to be updated to apply cleanly and the change should be
 mentioned in the release notes (docs/releases/1.7.txt). These changes
 should be suitable for a first-time committer.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1b376e53a98782d9ce128a8e5e5fdd07%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  File |  Version:  master
  uploads/storage|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by jacob):

 * stage:  Design decision needed => Accepted


Comment:

 Despite the portability issues, I still think upload_to should be
 optional.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+--
  Reporter:  leahculver  | Owner:  nobody   
  
Status:  new | Milestone:  1.3  
  
 Component:  File uploads/storage|   Version:  SVN  
  
Resolution:  |  Keywords:  FileField, 
files, upload, S3, upload_to
 Stage:  Design decision needed  | Has_patch:  1
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  0   |  
-+--
Comment (by adamnelson):

 I'm not sure if Django should stop the user from doing this, but
 dedicating an entire bucket to a FileField seems like a bad idea.  Setting
 upload_to to any string creates a pseudo-folder on Amazon S3 at no cost
 except for extra characters in the URL.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+--
  Reporter:  leahculver  | Owner:  nobody   
  
Status:  new | Milestone:  1.3  
  
 Component:  File uploads/storage|   Version:  SVN  
  
Resolution:  |  Keywords:  FileField, 
files, upload, S3, upload_to
 Stage:  Design decision needed  | Has_patch:  1
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * milestone:  1.2 => 1.3

Comment:

 Not critical for 1.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
-+--
  Reporter:  leahculver  | Owner:  nobody   
  
Status:  new | Milestone:  1.2  
  
 Component:  File uploads/storage|   Version:  SVN  
  
Resolution:  |  Keywords:  FileField, 
files, upload, S3, upload_to
 Stage:  Design decision needed  | Has_patch:  1
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  0   |  
-+--
Changes (by ubernostrum):

  * stage:  Ready for checkin => Design decision needed

Comment:

 Bumping this off the "ready for checkin" stage following discussion with
 Jacob of some issues with the proposed solution.

 In a nutshell, making `upload_to` optional makes code portability
 difficult; application code shouldn't differ based on the (deployment-
 specific) storage backend in use.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
---+
  Reporter:  leahculver| Owner:  nobody 

Status:  new   | Milestone:  1.2

 Component:  File uploads/storage  |   Version:  SVN

Resolution:|  Keywords:  FileField, files, 
upload, S3, upload_to
 Stage:  Ready for checkin | Has_patch:  1  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
---+
  Reporter:  leahculver| Owner:  nobody 

Status:  new   | Milestone:  1.2

 Component:  File uploads/storage  |   Version:  SVN

Resolution:|  Keywords:  FileField, files, 
upload, S3, upload_to
 Stage:  Accepted  | Has_patch:  1  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by physicsnick):

 * cc: physicsn...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
---+
  Reporter:  leahculver| Owner:  nobody 

Status:  new   | Milestone:  1.2

 Component:  File uploads/storage  |   Version:  SVN

Resolution:|  Keywords:  FileField, files, 
upload, S3, upload_to
 Stage:  Accepted  | Has_patch:  1  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * milestone:  1.1 => 1.2

Comment:

 Punting from 1.1: this is annoying, but there's an easy workaround (just
 set `upload_to = "dummy"` or something).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
---+
  Reporter:  leahculver| Owner:  nobody 

Status:  new   | Milestone:  1.1

 Component:  File uploads/storage  |   Version:  SVN

Resolution:|  Keywords:  FileField, files, 
upload, S3, upload_to
 Stage:  Accepted  | Has_patch:  1  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by dc):

  * has_patch:  0 => 1

Comment:

 upload_to can be optional - all infrastructure is here, actually only
 check in validation.py makes it required.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #8918: FileField upload_to should not be required for custom backends

[Django]

#8918: FileField upload_to should not be required for custom backends
---+
  Reporter:  leahculver| Owner:  nobody 

Status:  new   | Milestone:  1.1

 Component:  File uploads/storage  |   Version:  SVN

Resolution:|  Keywords:  FileField, files, 
upload, S3, upload_to
 Stage:  Accepted  | Has_patch:  0  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.1

Comment:

 There probably needs to be some flag you can set on the storage backend to
 indicate weather upload_to is required or not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---