Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
---+-
 Reporter:  Javier de la Rosa  |Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  Template system|  Version:  1.0
 Severity:  Normal |   Resolution:  duplicate
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Tim Graham ):

 In [changeset:"12cefee5d84b3569ccbde03167c7853e8dac638f" 12cefee5]:
 {{{
 #!CommitTicketReference repository=""
 revision="12cefee5d84b3569ccbde03167c7853e8dac638f"
 Refs #15667 -- Prevented newlines in attrs.html widget rendering.

 Removed the trailing newline from widget attrs.html template.
 The solution may be revisited by fixing refs #9198 but not
 for Django 1.11.

 Thanks Dmitry Ivanchenko for the report and Preston Timmons for advice.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e0ea75d817c5333beab07d21593c8eb7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
-+-
 Reporter:  versae   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  1.0
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by anonymous):

 Replying to [comment:8 david.wahlund@…]:
 > Using Django 1.6 I'm including a template inside of a , this adds a
 newline to the html that moves the whole content down a line. The newline
 is impossible to remove, even with the spaceless tag. This needs to be
 fixed somehow. Case #2594 deals with more specific cases of white space
 handling. This is only related to the new line from include and why it's
 not cleared using spaceless.
 Nevermind. There was a newline, but the space was an invisible character
 in the file.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2f7ac31f99b00cb89b2d8404d35b7a02%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
-+-
 Reporter:  versae   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  1.0
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by david.wahlund@…):

 Using Django 1.6 I'm including a template inside of a , this adds a
 newline to the html that moves the whole content down a line. The newline
 is impossible to remove, even with the spaceless tag. This needs to be
 fixed somehow. Case #2594 deals with more specific cases of white space
 handling. This is only related to the new line from include and why it's
 not cleared using spaceless.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0243b145c7728e1f71da9de58b3717e1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
-+-
 Reporter:  versae   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  1.0
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by anonymous):

 I found this solution, and it has worked for me:
 https://github.com/twidi/django-include-strip-tag

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
-+-
 Reporter:  versae   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  1.0
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => closed
 * ui_ux:   => 0
 * resolution:   => duplicate


Comment:

 I believe this is a special case of #2594.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
---+-
   Reporter:  versae   |  Owner:  nobody
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  Template system
Version:  1.0  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+-

Comment (by versae):

 Replying to [comment:4 anonymous]:
 > versae's workaround doesnt seem to fix anything. The new lines seem to
 survive the trimming (!?).

 You have to use the filter together to
 [http://djangosnippets.org/snippets/835/ withtag templatetag]. By example:
 {{{
 {% withtag include temaplate1.html as my_template %}
 {% my_template|trim %}
 {% endwithtab %}
 }}}

 But the code of {{{withtag}}} templatetag is old, I don't know if it's
 working yet.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
---+-
   Reporter:  versae   |  Owner:  nobody
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  Template system
Version:  1.0  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+-
Changes (by anonymous):

 * easy:   => 0


Comment:

 versae's workaround doesnt seem to fix anything. The new lines seem to
 survive the trimming (!?).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
--+-
  Reporter:  versae   | Owner:  nobody
Status:  new  | Milestone:
 Component:  Template system  |   Version:  1.0   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  0 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Comment (by versae):

 As temporary workaround, I used a custom trim filter
 {{{
 def trim(value):
 return mark_safe(value).strip()
 register.filter('trim', trim)
 }}}
 Together with [http://www.djangosnippets.org/snippets/835/ withtag
 templatetag].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
--+-
  Reporter:  versae   | Owner:  nobody
Status:  new  | Milestone:
 Component:  Template system  |   Version:  1.0   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  0 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by mtredinnick):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 For backwards compatibility reasons we cannot change the default behaviour
 now (there will be templates that rely on the newline being inserted). It
 might be possible to add a "trim trailing newline" option to the `include`
 tag, though, if it can be given a very short name. Something like
 `final_newline=0` but with a way better name than that (I'm giving it an
 "=0" bit so that we can tell the different between the controlling
 parameter and the name of any file to be included.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #9198: templatetag include adds new line

[Django]

#9198: templatetag include adds new line
-+--
 Reporter:  versae   |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  Template system  | Version:  1.0   
 Keywords:   |   Stage:  Unreviewed
Has_patch:  0|  
-+--
 If I have a template
 {{{
 # template1.html
 Line 1
 Line 2
 }}}

 And I include this template in other one using templatetag include:
 {{{
 # template2.html
 {% include template1.html %}
 Line 3
 }}}

 The output must be:
 {{{
 # template2.html
 # template1.html
 Line 1
 Line 2
 Line 3
 }}}

 But the actual output is:
 {{{
 # template2.html
 # template1.html
 Line 1
 Line 2

 Line 3
 }}}

 This behavior is particularly annoying when it renders a template
 including JSON.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---