Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nessita 

Status:  closed   | Milestone:  1.1 

 Component:  Template system  |   Version:  1.0 

Resolution:  fixed|  Keywords:  url, tplrf-fixed, 
pycamp2009
 Stage:  Accepted | Has_patch:  1   

Needs_docs:  0|   Needs_tests:  0   

Needs_better_patch:  0|  
--+-
Comment (by nessita):

 Malcom,

 you're welcome! We had the most fun proposing a solution for this one. We
 would love to keep contributing to the django project.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nessita 

Status:  assigned | Milestone:  1.1 

 Component:  Template system  |   Version:  1.0 

Resolution:   |  Keywords:  url, tplrf-fixed, 
pycamp2009
 Stage:  Accepted | Has_patch:  1   

Needs_docs:  0|   Needs_tests:  0   

Needs_better_patch:  0|  
--+-
Comment (by mtredinnick):

 I'm not going to apply the changes to the `split_contents()` portion,
 since they don't appear to fix an existing problem I'm not convinced they
 don't introduce a bug. We should fix on problem per ticket.

 If somebody wants to fix up that portion (and if it can be reduced to one
 line, that would be great), the patch should include test of the i18n
 pieces in that function. It's clearly looking at `_("...")` strings, but I
 don't see anything in the replacement code that handles that. It might
 well be being handled elsewhere automatically (so we're doing it twice
 now) and that will be demonstrated by the tests in the new ticket and
 patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nessita 

Status:  assigned | Milestone:  1.1 

 Component:  Template system  |   Version:  1.0 

Resolution:   |  Keywords:  url, tplrf-fixed, 
pycamp2009
 Stage:  Accepted | Has_patch:  1   

Needs_docs:  0|   Needs_tests:  0   

Needs_better_patch:  0|  
--+-
Comment (by nessita):

 Attaching new patch with greedy regular expression (to avoid
 backtracking).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nessita 

Status:  assigned | Milestone:  1.1 

 Component:  Template system  |   Version:  1.0 

Resolution:   |  Keywords:  url, tplrf-fixed, 
pycamp2009
 Stage:  Accepted | Has_patch:  1   

Needs_docs:  0|   Needs_tests:  0   

Needs_better_patch:  0|  
--+-
Changes (by nessita):

 * cc: matiasb (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nessita 

Status:  assigned | Milestone:  1.1 

 Component:  Template system  |   Version:  1.0 

Resolution:   |  Keywords:  url, tplrf-fixed, 
pycamp2009
 Stage:  Accepted | Has_patch:  1   

Needs_docs:  0|   Needs_tests:  0   

Needs_better_patch:  0|  
--+-
Comment (by nessita):

 Last night, while being unable to sleep, I figured out that the non-greedy
 part of the proposed regular expression (in teh pacth attached) can be
 changed to a greedy expression, improving the performance of it.

 So, where it reads:

 {{{
 smart_split_re = re.compile(r"""(\S*?"(?:[^"\\]*(?:\\.[^"\\]*)*)"\S*| #
 matches '"value with spaces"' and 'keyword="value with spaces"'
  \S*?'(?:[^'\\]*(?:\\.[^'\\]*)*)'\S*| #
 same as above but with quotes swapped
  \S+) #
 matches not whitespaces""",
 re.VERBOSE)
 }}}

 the {{{\S+?"}}} can be changed to {{{[^\s"]"}}} (same for the {{{'}}}
 character). I'll submit a new patch in a while, prior some checkings.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nessita 

Status:  assigned | Milestone:  1.1 

 Component:  Template system  |   Version:  1.0 

Resolution:   |  Keywords:  url, tplrf-fixed, 
pycamp2009
 Stage:  Accepted | Has_patch:  1   

Needs_docs:  0|   Needs_tests:  0   

Needs_better_patch:  0|  
--+-
Changes (by nessita):

  * has_patch:  0 => 1

Comment:

 Added patch to solve this issue. Fixed involved debugging and improvments
 of the {{{smart_split}}} from [browser:/django/util/text.py], plus a
 simplification of {{{split_contents}}} at
 [browser:django/template/__init__.py].

 All tests passes except for {{{test_templates
 (regressiontests.templates.tests.Templates)}}} which was already failing.

 Made by nessita (Natalia Bidart) and matiasb (Matías Bordese, not
 registered yet).
 Contributors understanding regexs: Ramiro Morales, Facundo Batista, Pablo
 Ziliani, John Lenton.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nessita 

Status:  assigned | Milestone:  1.1 

 Component:  Template system  |   Version:  1.0 

Resolution:   |  Keywords:  url, tplrf-fixed, 
pycamp2009
 Stage:  Accepted | Has_patch:  0   

Needs_docs:  0|   Needs_tests:  0   

Needs_better_patch:  0|  
--+-
Changes (by nessita):

  * keywords:  url, tplrf-fixed => url, tplrf-fixed, pycamp2009
  * owner:  nobody => nessita
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nobody  
Status:  new  | Milestone:  1.1 
 Component:  Template system  |   Version:  1.0 
Resolution:   |  Keywords:  url, tplrf-fixed
 Stage:  Accepted | Has_patch:  0   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nobody  
Status:  new  | Milestone:  
 Component:  Template system  |   Version:  1.0 
Resolution:   |  Keywords:  url, tplrf-fixed
 Stage:  Unreviewed   | Has_patch:  0   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by airrob):

 * cc: airrob (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
--+-
  Reporter:  alexisbellido| Owner:  nobody  
Status:  new  | Milestone:  
 Component:  Template system  |   Version:  1.0 
Resolution:   |  Keywords:  url, tplrf-fixed
 Stage:  Unreviewed   | Has_patch:  0   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by emulbreh):

  * keywords:  url => url, tplrf-fixed
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 This would be fixed by #7806.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #9315: Keyword arguments with spaces and the url tag

[Django]

#9315: Keyword arguments with spaces and the url tag
-+--
 Reporter:  alexisbellido|   Owner:  nobody
   Status:  new  |   Milestone:
Component:  Template system  | Version:  1.0   
 Keywords:  url  |   Stage:  Unreviewed
Has_patch:  0|  
-+--
 Hi, I asked about this on the django-users group and was told it was
 probably a bug so I'm reporting it:

 I was testing named url patterns and I have something like this in my
 URLConf:

 {{{
 url(r'^search/(?P.*)$', 'books.views.search', name='search_page'),
 }}}

 The view is defined like this:

 {{{
 def search(request, words):
 }}}

 Now I'd like to print a link to the search page with certain words from a
 template and used the url tag like this:

 {{{
 {% url search_page words="someword" %}
 }}}

 When viewing on the browser I get something like '/search/someword', which
 is good. My question is how do I pass more than one word in the 'words'
 parameter?

 If I do this:

 {{{
 {% url search_page words="someword otherword" %}
 }}}

 I get this error:

 {{{
 TemplateSyntaxError at (my page name here)

 Could not parse the remainder: '"someword' from '"someword
 }}}

 Can the url tag handle parameters with spaces?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---