Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by timo):

 Please look at the commits above for details. The Version field on the
 ticket merely indicates what the current version was when the ticket was
 reported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6d238059e78766345b516d8624f75975%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by anonymous):

 will this be implemented in 1.8? the ticket says 1.4 and the "press
 ctrl..."-help text is still appended to any custom text.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.74d42db40af8b716f54e99887f7d923e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by Ramiro Morales ):

 In [changeset:"491419b5ffac3752a1c1804a763c017a2ed82e16"]:
 {{{
 #!CommitTicketReference repository=""
 revision="491419b5ffac3752a1c1804a763c017a2ed82e16"
 Made m2m fields form help_text munging specific to admin widgets.

 Refs #9321 and follow-up to e80de93af6a0a21a9063a55c4d6d20e3927243e9.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c54114e77e1895cdb4f1a1bbacef9e3b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by Tim Graham ):

 In [changeset:"e80de93af6a0a21a9063a55c4d6d20e3927243e9"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e80de93af6a0a21a9063a55c4d6d20e3927243e9"
 Removed hard-coded help_text for ManyToManyFields that use a
 SelectMultiple widget

 Per deprecation timeline; refs #9321.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ee970a85923173d6f22f06e1cf20d8a0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by Ramiro Morales ):

 In [changeset:"8c2fd050f80f528cc1609c1a7f16901194834831"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8c2fd050f80f528cc1609c1a7f16901194834831"
 Made fix for #9321 less buggy and more effective.

 Don't try to be smart about building a good-looking help string
 because it evaluates translations too early, simply use the same old
 strategy as before. Thanks Donald Stufft for the report.

 Also, actually fix the case reported by the OP by special-casing
 CheckboxSelectMultiple.

 Added tests.

 Refs #9321.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3313a6829a70c379b658eb656c8e3103%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by Ramiro Morales ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4ba1c2e785feecfa7a47aa5336a2b595f086a765"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4ba1c2e785feecfa7a47aa5336a2b595f086a765"
 Fixed #9321 -- Deprecated hard-coding of help text in model
 ManyToManyField fields.

 This is backward incompatible for custom form field/widgets that rely
 on the hard-coded 'Hold down "Control", or "Command" on a Mac, to select
 more than one.' sentence.

 Application that use standard model form fields and widgets aren't
 affected but need to start handling these help texts by themselves
 before Django 1.8.

 For more details, see the related release notes and deprecation timeline
 sections added with this commit.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by ramiro):

 I've posted a proposal to the django-dev mailing list:
 https://groups.google.com/forum/?hl=en&fromgroups#!topic/django-
 developers/PqfHA3hvAxo

 Feedback on is welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by anonymous):

 This is the single most annoying bug on django, if dyve won't fix it I
 will. For now I'll wait.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by dyve):

 Adding my support to absolutely removing this from the database layer. I
 keep running into this. And sometimes it's just plain ridiculous (for
 example when using `CheckboxSelectMultiple` for a ManyToMany.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Accepted
  widget, related.py, admin  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by jacob):

 * stage:  Design decision needed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by anonymous):

 What's wrong with this patch?

 https://code.djangoproject.com/attachment/ticket/19066/0001-Allow-
 overriding-help_text-default-message-on-ManyTo.patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by gert):

 1) As many people have stated (in various duplicate tickets) the help text
 should not be in the database layer

 2) Also, overriding the help text from the model definition has no effect
 - so putting the help text in the database layer is breaking the model
 definition

 This has been going on for 4 years now, without resolution, please allow
 me to propose a different approach:

 Firstly it's a bug, there is no need to maintain any backwards
 compatibility. Why don't we delete it from the database layer and then
 opening a new ticket that states that the widget does not display the help
 text. That way at least just the widget is broken, currently the widget
 and the database layer is broken.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by dyve):

 I keep running into this issue. It's a really obnoxious test that certain
 does not belong in ManyToManyField. It belongs in widgets if anywhere. But
 why add this to every Many To Many? We don't show "Press Enter to submit"
 help texts when displaying forms?

 This functionality assumes a HTML select widget, and nowadays much more
 different widget styles (scripted and otherwise) are available.

 Basically, the text is a piece of hardcoded UI that should be completely
 removed instead of toned down. The only reason not to remove this is
 backward compatibility. If removing it is too big a step, it should be
 moved to SelectMultiple widget.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by aaugustin):

 #19066 was a duplicate with a simple patch and tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by ivan_virabyan):

 * cc: ivan_virabyan (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by jpic):

 * cc: jpic (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by quinode):

 * cc: dguardiola@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by domen@…):

 * cc: domen@… (added)


Comment:

 What else is needed for this one to apply?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by russellm):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 A ticket is closed when the patch is applied, not when the patch is
 provided. Reopening.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by marcdm@…):

 * status:  reopened => closed
 * version:  1.2 => 1.4
 * resolution:   => fixed
 * needs_tests:  0 => 1


Comment:

 Please accept my apologies for this patch if the format is wrong or
 something similar.

 I think I've fixed this bug in a fairly simple way.

 The thing that is at issue here is the addition of widget-related help-
 text by the Database field object (ManyToManyField) instead of the Form
 field object (MultipleChoiceField, ModelMultipleChoiceField,
 TypedChoiceField etc.)

 The patch does the following :
 * remove the 2 lines that add the message in
 django.db.models.related.ManyToManyField.__init__
 * add a private method to django.forms.fields.ChoiceField field called
 _patch_help_text().
 * add calls to this method in the __init__ of MultipleChoiceField and
 ModelMultipleChoiceField

 The _patch_help_text() method, when called :
 * checks the widget on the form and updates the help text if the widget is
 a SelectMultiple.
 * uses type() to check self.widget so the message isn't printed for
 subclasses of SelectMultiple

 What do u think? Sorry, I haven't read up on writing tests yet, so no
 tests. But, the goal was simple, show the message for SelectMultiple,
 suppress it all other times.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by dblado):

 and w/ formatting and me logged in

 I solved this with:

 {{{#!python
 class mymodelform(ModelForm):
 class Meta:
 pass
 def __init__(self, *args, **kwargs):
 super(RegisterForm, self).__init__(*args, **kwargs)
 self.fields['staying'].help_text = ''
 self.fields['family_members'].help_text = ''
 }}}
 don't know if this is 'kosher' but it seems to work for me!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by anonymous):

 I solved this with:
 class mymodelform(ModelForm):
 class Meta:
 pass
 def __init__(self, *args, **kwargs):

 super(RegisterForm, self).__init__(*args, **kwargs)

 self.fields['staying'].help_text = ''

 self.fields['family_members'].help_text = ''

 don't know if this is 'kosher' but it seems to work for me!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
 Reporter:  mrcai|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  manytomanyfield, | Triage Stage:  Design
  widget, related.py, admin  |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by carlos.palol@…):

 * cc: carlos.palol@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  1  |
-+-

Comment (by anonymous):

 I just ran into this and am having trouble finding a workaround. Can
 someone list the preferred workaround until the bug is resolved?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  1  |
-+-

Comment (by anonymous):

 #16370 reported this again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  1  |
-+-
Changes (by julien):

 * ui_ux:   => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by julien):

 Replying to [comment:24 jezdez]:
 > Honestly this is not a good comparison at all, `ModelAdmin` is at a
 completely different abstraction layer; users are encouraged to write them
 while Widgets (especially the SelectMultiple) not so much.

 The comparison was just purely about the hook implementation paradigm,
 nothing more. I've actually had to write custom widgets on many occasions
 for the admin (in particular for the `ManyToManyField`), which is why I've
 always been keen to fix this ticket :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by jezdez):

 Replying to [comment:17 julien]:
 > Just following on your comment, I see your point about the oddness of
 that callback. It felt similarly odd to me when the
 `ModelAdmin.save_model()` and `ModelAdmin.delete_model()` hooks were
 introduced. I think the oddness is the price to pay for more flexibility
 and future-proofness. So I'm a bit ambivalent about this. I'll resubmit a
 patch using the `extra_help_text` class attribute so we can compare
 approaches.

 Honestly this is not a good comparison at all, `ModelAdmin` is at a
 completely different abstraction layer; users are encouraged to write them
 while Widgets (especially the SelectMultiple) not so much.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by julien):

 OK, thank you all for your feedback. I'll try to summarize the problem and
 discussions so far. So, an **ideal** solution would:

 * stop `ManyToManyField` from directly appending the 'Hold down Control'
 message, since this has nothing to do with ORM-level business.
 * allow **non-standard** widgets and widgets **inheriting** from
 `SelectMultiple` to **not** append the 'Hold down Control' message when
 used in conjunction with a `ManyToManyField`.
 * be backwards compatible as it would potentially affect a lot of people:
* When the **default** `SelectMultiple` widget, or any widget
 **inheriting** from `SelectMultiple`, **is not** used in conjunction with
 a `ManyToManyField`, then **do not** append the message.
* When the **default** `SelectMultiple` **is** used in conjunction with
 a `ManyToManyField`, then **do** append the message.

 A compromise needs to be found between doing things right and not annoying
 too many people with a potentially backwards incompatible change. The
 challenge is that, as much as `ManyToManyField` should not be allowed to
 guess which widget will be used, the `SelectMultiple` widget should also
 not trying to guess that it's used with a `ManyToManyField`. Maybe the
 compromise lies in the form field's realm, in particular
 `ModelMultipleChoiceField`.

 Finally, a bit of forensic research reveals this behaviour was introduced
 at least at the time of the magic-removal branch merge:
 
http://code.djangoproject.com/browser/django/trunk/django/db/models/fields/related.py?rev=2809#L580

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by julien):

 On further reflection, one radical approach would be to remove the 'Hold
 down Control' extra message altogether, and let the developers directly
 add some extra information, if they see fit, using the traditional way via
 the model field or form field's `help_text` attribute. The use of that
 extra message is actually quite debatable, and it has caused quite some
 confusion for years from an implementation standpoint.

 Anyways, just a thought.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by SmileyChris):

 Er, minimize the backwards ''in''compatibility...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by SmileyChris):

 I'd prefer to minimize the backwards compatibility of the patch. I don't
 really want people to have to hunt through and modify every instance of
 `SelectMultiple` they've used to continue to have their help_text
 unmolested.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by julien):

 @SmileyChris: Yes, this is a manifestation of the backwards incompatible
 change of this patch. The "Hold down Control" message only makes sense
 when used with a `` widget where multiple items can be selected,
 i.e. with `SelectMultiple`. So, had the behaviour been proper, then that
 message should have always been there in the tests, not just when used in
 the context of a `ManyToManyField`. I see this change more as way of re-
 establishing the correct behaviour. What do you think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by SmileyChris):

 I also don't like the fact this is adding the default help text for all
 `SelectMultiple` widgets, as noted by the requirement to change current
 tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by julien):

 Just following on your comment, I see your point about the oddness of that
 callback. It felt similarly odd to me when the `ModelAdmin.save_model()`
 and `ModelAdmin.delete_model()` hooks were introduced. I think the oddness
 is the price to pay for more flexibility and future-proofness. So I'm a
 bit ambivalent about this. I'll resubmit a patch using the
 `extra_help_text` class attribute so we can compare approaches.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by julien):

 Well, this callback would allow the widget to operate more changes that
 just append some text, for example prepend some text or replace it
 altogether. A bit like the way the `ModelAdmin.save_model()` hook works.
 If you think that's a YAGNI and that we should only allow appending text,
 then a `extra_help_text` class attribute would work. Note that it would
 also be backwards compatible (which is cool, I think, if we want to get it
 right).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-
Changes (by jezdez):

 * needs_better_patch:  0 => 1


Comment:

 Yeah, I really think this callback API is odd, I don't like it at all, why
 not just have a `extra_help_text` class attribute in a widget that is
 appended if it exists?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
-+-
   Reporter:  mrcai  |  Owner:  nobody
   Type:  Bug| Status:  reopened
  Milestone:  1.4|  Component:  Forms
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:  manytomanyfield,
   Triage Stage:  Design |  widget, related.py, admin
  decision needed|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by julien):

 * severity:   => Normal
 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * easy:   => 0
 * needs_docs:  1 => 0
 * type:   => Bug


Comment:

 The attached patch solves two tickets at once, i.e. this one and #14402.
 The reason is that the bug fixes for those two tickets both rely on the
 introduction of the same new method `Widget.alter_help_text`. If this
 approach is validated then I'll break the patch in two, and #14402 can be
 checked in after this one.

 The idea behing `alter_help_text` is to allow the widget to customize the
 form field's help text -- for example `SelectMultiple` would now be
 responsible for appending the '`Hold down "Control"`' message instead of
 letting `ManyToManyField` do it. This new feature introduces a backwards
 incompatible change, although the upgrade path is really simple. See the
 doc in the patch for more info about that.

 Let me know what you think!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
--+-
   Reporter:  mrcai   | Owner:  nobody  
  
 Status:  reopened| Milestone:  1.4 
  
  Component:  Forms   |   Version:  1.2 
  
 Resolution:  |  Keywords:  
manytomanyfield, widget, related.py, admin
   Triage Stage:  Design decision needed  | Has patch:  1   
  
Needs documentation:  1   |   Needs tests:  1   
  
Patch needs improvement:  1   |  
--+-
Changes (by julien):

  * component:  Database layer (models, ORM) => Forms


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
+---
   Reporter:  mrcai | Owner:  
nobody
 Status:  reopened  | Milestone:  1.4   

  Component:  Database layer (models, ORM)  |   Version:  1.2   

 Resolution:|  Keywords:  
manytomanyfield, widget, related.py, admin
   Triage Stage:  Design decision needed| Has patch:  1 

Needs documentation:  1 |   Needs tests:  1 

Patch needs improvement:  1 |  
+---
Changes (by julien):

  * needs_better_patch:  0 => 1
  * stage:  Accepted => Design decision needed
  * needs_tests:  0 => 1
  * milestone:  => 1.4


Comment:

 I'm marking as DDN since we still need to figure out the best approach for
 amending the help text based on which widget is used. I strongly feel that
 each widget should be able to control what help text gets displayed. I
 haven't given this enough thoughts yet, but perhaps it could be along the
 lines of:

 {{{
 #!python
 # In django/forms/widgets.py
 class Widget(object):
 ...
 def get_help_text(self, text):
 """ Hook to allow a widget to amend its help text """
 return text

 class SelectMultiple(Select):
 def get_help_text(self, text):
 return string_concat(text, ' ', _('Hold down "Control", or
 "Command" on a Mac, to select more than one.'))
 }}}

 ... and then call the `get_help_text()` method at the right time either
 when building or rendering the form.

 See also #14402 for a tightly linked issue. I'd recommend solving both
 tickets at once.

 I'd really like to see this fixed in 1.4.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
---+
  Reporter:  mrcai | Owner:  nobody 
   
Status:  reopened  | Milestone: 
   
 Component:  Database layer (models, ORM)  |   Version:  1.2
   
Resolution:|  Keywords:  
manytomanyfield, widget, related.py, admin
 Stage:  Accepted  | Has_patch:  1  
   
Needs_docs:  1 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by rspeed):

  * keywords:  manytomanyfield, widget, related.py => manytomanyfield,
   widget, related.py, admin
  * has_patch:  0 => 1
  * component:  Forms => Database layer (models, ORM)

Comment:

 Attached an updated version of the patch from #12359 by t...@ktrl.com
 which moves the assignment of the help_text from
 django.db.models.fields.related to django.contrib.admin.options.

 I had begun making a patch to move the help_text assignment to
 django.forms.widgets.SelectMultiple, but in doing so I realized that this,
 too, is poor behavior. The help_text property is expected to be in direct
 control of the application; in no situation should it be modified by the
 framework.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
---+
  Reporter:  mrcai | Owner:  nobody 

Status:  reopened  | Milestone: 

 Component:  Forms |   Version:  1.2

Resolution:|  Keywords:  manytomanyfield, widget, 
related.py
 Stage:  Accepted  | Has_patch:  0  

Needs_docs:  1 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Comment (by bryce):

 Is there update for this issue? The workarounds are all pretty annoying

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9321: When overriding the widget for a manytomany field default help_text stays

[Django]

#9321: When overriding the widget for a manytomany field default help_text stays
---+
  Reporter:  mrcai | Owner:  nobody 

Status:  reopened  | Milestone: 

 Component:  Forms |   Version:  1.2

Resolution:|  Keywords:  manytomanyfield, widget, 
related.py
 Stage:  Accepted  | Has_patch:  0  

Needs_docs:  1 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by kmtracey):

  * summary:  When overriding the widget for a manytomany field default
  helper text stays => When overriding the widget
  for a manytomany field default help_text stays

Comment:

 #12359 and #13858 also reported this; the first has a patch (but no test).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.