Re: [Django] #9587: formset with can_delete shouldn't require deleted forms to validate

[Django]

#9587: formset with can_delete shouldn't require deleted forms to validate
+---
  Reporter:  Daniel Pope   | Owner:  
nobody
Status:  closed | Milestone:  
1.1   
 Component:  Forms  |   Version:  
1.0   
Resolution:  fixed  |  Keywords:  
formset can_delete
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Comment (by danstadler):

 I would agree with jsamsa's comment on 06/08/09.  I have a case where I
 don't want to delete the last child object, if the parent object is in a
 particular state.  I'd like to be able to throw a ValidationError on
 delete, but that doesn't seem allowed.  BTW we are on Django 1.0.3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9587: formset with can_delete shouldn't require deleted forms to validate

[Django]

#9587: formset with can_delete shouldn't require deleted forms to validate
+---
  Reporter:  Daniel Pope   | Owner:  
nobody
Status:  closed | Milestone:  
1.1   
 Component:  Forms  |   Version:  
1.0   
Resolution:  fixed  |  Keywords:  
formset can_delete
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Comment (by jsamsa):

 Can we improve this to read the delete field value from cleaned_data so
 that validation has a chance to raise validation errors on delete?  I have
 a case where I don't want to allow delete on inlines after the parent
 model reaches a certain state.  I'll try writing a patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9587: formset with can_delete shouldn't require deleted forms to validate

[Django]

#9587: formset with can_delete shouldn't require deleted forms to validate
+---
  Reporter:  Daniel Pope   | Owner:  
nobody
Status:  new| Milestone:  
1.1   
 Component:  Forms  |   Version:  
1.0   
Resolution: |  Keywords:  
formset can_delete
 Stage:  Accepted   | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9587: formset with can_delete shouldn't require deleted forms to validate

[Django]

#9587: formset with can_delete shouldn't require deleted forms to validate
+---
  Reporter:  Daniel Pope   | Owner:  
nobody
Status:  new| Milestone:

 Component:  Forms  |   Version:  
1.0   
Resolution: |  Keywords:  
formset can_delete
 Stage:  Unreviewed | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by vbmendes):

 * cc: vbmendes (added)

Comment:

 I think the first solution is better. If you want to delete the form, it
 doesn't matter if it validates or not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9587: formset with can_delete shouldn't require deleted forms to validate

[Django]

#9587: formset with can_delete shouldn't require deleted forms to validate
+---
  Reporter:  Daniel Pope   | Owner:  
nobody
Status:  new| Milestone:

 Component:  Forms  |   Version:  
1.0   
Resolution: |  Keywords:  
formset can_delete
 Stage:  Unreviewed | Has_patch:  1 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  1  |  
+---
Changes (by kratorius):

  * needs_better_patch:  0 => 1
  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9587: formset with can_delete shouldn't require deleted forms to validate

[Django]

#9587: formset with can_delete shouldn't require deleted forms to validate
+---
  Reporter:  Daniel Pope   | Owner:  
nobody
Status:  new| Milestone:

 Component:  Forms  |   Version:  
1.0   
Resolution: |  Keywords:  
formset can_delete
 Stage:  Unreviewed | Has_patch:  0 

Needs_docs:  0  |   Needs_tests:  0 

Needs_better_patch:  0  |  
+---
Changes (by kratorius):

  * keywords:  => formset can_delete
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I see two possible solutions here:
  1. we don't validate the single form
  2. we validate the form, but the formset's will be valid even if the
 field that is going to be deleted is invalid

 I'm more inclined to go with the second option since if the user checks
 the deletion checkbox but other fields are invalid, we should redisplay
 the whole formset and show eventual errors.[[BR]]

 Anyway I can't see a clean way of fixing this issue. I wrote a patch, but
 I don't like the solution mainly because the only way I have to know if
 the form has to be deleted is to check for the {{{DELETE}}} string in the
 initial data (I can't access {{{form.cleaned_data}}} since if the form has
 errors {{{cleaned_data}}} gets deleted).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #9587: formset with can_delete shouldn't require deleted forms to validate

[Django]

#9587: formset with can_delete shouldn't require deleted forms to validate
---+
 Reporter:  Daniel Pope <[EMAIL PROTECTED]>  |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Forms  | Version:  1.0   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 If I check the can_delete checkbox for a !FormSet form, I would expect the
 form to be deleted regardless of whether there are validation errors in
 that particular form. I'm getting "This field is required" even for forms
 I'm trying to delete.

 I'm using inlineformset_factory.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---