subject:"\[Django\] #9588\: provide \*\*kwargs argument to GenericInlineModelAdmin.get

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2011-06-16 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
-+-
   Reporter:  lakin@…|  Owner:  brosner
   Type:  New| Status:  closed
  feature|  Component:
  Milestone: |  contrib.contenttypes
Version:  SVN|   Severity:  Normal
 Resolution:  fixed  |   Keywords:
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by jezdez):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [16419]:
 {{{
 #!CommitTicketReference repository="" revision="16419"
 Fixed #9588 -- Allow passing kwargs to
 `GenericInlineModelAdmin.get_formset` just like the InlineModelAdmin.
 Thanks, prestontimmons.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2011-05-15 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
-+-
   Reporter:  lakin@…|  Owner:  brosner
   Type:  New| Status:  assigned
  feature|  Component:
  Milestone: |  contrib.contenttypes
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * stage:  Accepted => Ready for checkin


Comment:

 Excellent, thanks a lot.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2011-05-15 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
-+-
   Reporter:  lakin@…|  Owner:  brosner
   Type:  New| Status:  assigned
  feature|  Component:
  Milestone: |  contrib.contenttypes
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by prestontimmons):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2011-05-15 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
-+-
   Reporter:  lakin@…|  Owner:  brosner
   Type:  New| Status:  assigned
  feature|  Component:
  Milestone: |  contrib.contenttypes
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  1
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by julien):

 * needs_tests:  0 => 1


Comment:

 Thanks a lot for the patch. It is a simple change but tests are still
 needed. Passing a couple of kwargs and making sure that they override the
 defaults would be enough.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2011-05-15 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
-+-
   Reporter:  lakin@…|  Owner:  brosner
   Type:  New| Status:  assigned
  feature|  Component:
  Milestone: |  contrib.contenttypes
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by prestontimmons):

 * easy:   => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2011-04-17 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
-+-
   Reporter:  lakin@…|Owner:  brosner
   Type:  New|   Status:  assigned
  feature|Component:  contrib.contenttypes
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  1
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * type:   => New feature
 * severity:   => Normal
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2010-02-23 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
--+-
  Reporter:  la...@structuredabstraction.com  | Owner:  brosner
Status:  assigned | Milestone: 
 Component:  Contrib apps |   Version:  SVN
Resolution:   |  Keywords: 
 Stage:  Accepted | Has_patch:  1  
Needs_docs:  0|   Needs_tests:  0  
Needs_better_patch:  0|  
--+-
Changes (by ubernostrum):

  * milestone:  1.2 =>

Comment:

 1.2 is feature-frozen, moving this feature request off the milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2010-01-10 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
--+-
  Reporter:  la...@structuredabstraction.com  | Owner:  brosner
Status:  assigned | Milestone:  1.2
 Component:  Contrib apps |   Version:  SVN
Resolution:   |  Keywords: 
 Stage:  Accepted | Has_patch:  1  
Needs_docs:  0|   Needs_tests:  0  
Needs_better_patch:  0|  
--+-
Changes (by brosner):

  * version:  1.0 => SVN
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2008-11-13 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
--+-
  Reporter:  [EMAIL PROTECTED]  | Owner:  brosner
Status:  assigned | Milestone: 
 Component:  Contrib apps |   Version:  1.0
Resolution:   |  Keywords: 
 Stage:  Accepted | Has_patch:  1  
Needs_docs:  0|   Needs_tests:  0  
Needs_better_patch:  0|  
--+-
Comment (by anonymous):

 If you're having a go at fixing this one, you should consider fixing #9122
 at the same time, it's kinda related in the "Make the
 GenericInlineModelAdmin more like the InlineModelAdmin" category. :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2008-11-13 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
--+-
  Reporter:  [EMAIL PROTECTED]  | Owner:  brosner
Status:  assigned | Milestone: 
 Component:  Contrib apps |   Version:  1.0
Resolution:   |  Keywords: 
 Stage:  Accepted | Has_patch:  1  
Needs_docs:  0|   Needs_tests:  0  
Needs_better_patch:  0|  
--+-
Changes (by brosner):

  * status:  new => assigned
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * owner:  nobody => brosner
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted

Comment:

 I was just thinking about this today as I was going through this code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

2008-11-13 Thread Django

#9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset
-+--
 Reporter:  [EMAIL PROTECTED]  |   Owner:  nobody
   Status:  new  |   Milestone:
Component:  Contrib apps | Version:  1.0   
 Keywords:   |   Stage:  Unreviewed
Has_patch:  1|  
-+--
 InlineModelAdmin.get_formset provides kwargs to override defaults:
 {{{
 def get_formset(self, request, obj=None, **kwargs):
 """Returns a BaseInlineFormSet class for use in admin add/change
 views."""
 if self.declared_fieldsets:
 fields = flatten_fieldsets(self.declared_fieldsets)
 else:
 fields = None
 if self.exclude is None:
 exclude = []
 else:
 exclude = self.exclude
 defaults = {
 "form": self.form,
 "formset": self.formset,
 "fk_name": self.fk_name,
 "fields": fields,
 "exclude": exclude + kwargs.get("exclude", []),
 "formfield_callback": self.formfield_for_dbfield,
 "extra": self.extra,
 "max_num": self.max_num,
 }
 defaults.update(kwargs)
 return inlineformset_factory(self.parent_model, self.model,
 **defaults)
 }}}

 Shouldn't we do the same for GenericInlineModelAdmin.get_formset ?

 Potential Patch:
 {{{
 def get_formset(self, request, obj=None, **kwargs):
 if self.declared_fieldsets:
 fields = flatten_fieldsets(self.declared_fieldsets)
 else:
 fields = None
 defaults = {
 "ct_field": self.ct_field,
 "fk_field": self.ct_fk_field,
 "form": self.form,
 "formfield_callback": self.formfield_for_dbfield,
 "formset": self.formset,
 "extra": self.extra,
 "can_delete": True,
 "can_order": False,
 "fields": fields,
 }
 defaults.update(kwargs)
 return generic_inlineformset_factory(self.model, **defaults)
 }}}

 I chose the "Contrib Apps" component because there is no
 "contrib.contenttypes".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

Re: [Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

[Django] #9588: provide **kwargs argument to GenericInlineModelAdmin.get_formset

11 matches

Site Navigation

Mail list logo

Footer information