Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by paulc):

 * cc: pa...@mozilla.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by vkryachko):

  * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  1   |  
-+--
Comment (by vkryachko):

 So here's the patch, I think that this way it would be more flexible so
 that you can customize the content of 403 as much as you wish. Besides it
 makes exception handling more consistent, you just create 403.html in the
 root of your templates dir just like for 404 and 500. What do you think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  1   |  
-+--
Comment (by vkryachko):

 OK, I see middleware is not involved in this process, but it's possible to
 add a method to the resolver, resolver.resolve403() just like resolve404
 and resolve500 which could render 403.html template and if that fails just
 return 'Permission Denied'

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  1   |  
-+--
Comment (by vkryachko):

 Why not create an exception subclass which would be raised in base.py and
 caught by a middleware to display a custom 403 page, like with Http404 ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  1   |  
-+--
Changes (by adamnelson):

  * needs_better_patch:  0 => 1

Comment:

 I take back what I said about not having a message at all.

  1. It shouldn't be hardcoded in base.py, maybe it should be in
 source:django/trunk/django/http/__init__.py ?
  1. All the non-200 HTTP errors should derive from a master error class.
 Right now it's kind of a hodge-podge it seems.

 I agree that milestone:1.3 is best.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.3
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by ubernostrum):

  * milestone:  1.2 => 1.3

Comment:

 Also, this is a minor enough issue that it really ought to happen on 1.3
 or a 1.2.X bugfix release.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.2
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by ubernostrum):

 I think there should be content in the response, since otherwise you'd
 show a completely blank page to an end user, requiring them to know about
 HTTP status codes and how to find out what status code we sent back.

 I can see a couple options for doing this:

  1. Don't bother trying to translate the response content, and just use
 the language in the HTTP spec (so just "403 Forbidden").
  2. Set a default `content` value for `HttpResponseForbidden`, and mark it
 for translation. I think we can do that safely since it's over in
 `django.http` and settings will already be set up by the time it gets
 imported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.2
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by adamnelson):

  * has_patch:  0 => 1

Comment:

 There is no need to have a message at all.  'Permission Denied' is
 presumed with the 403 HttpResponseForbidden error.  If a message must be
 delivered, it should be added to django/http/__init__.py for all
 HttpResponseForbidden errors.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.2
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by adrian):

  * milestone:  1.1 => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner: 
Status:  new | Milestone:  1.1
 Component:  Core framework  |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by kgrandis):

  * owner:  kgrandis =>
  * status:  reopened => new
  * has_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner:  kgrandis
Status:  reopened| Milestone:  1.1 
 Component:  Core framework  |   Version:  1.0 
Resolution:  |  Keywords:  
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by jacob):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Reopening - the fix was a bad idea; see [10347].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner:  kgrandis
Status:  assigned| Milestone:  1.1 
 Component:  Core framework  |   Version:  1.0 
Resolution:  |  Keywords:  
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by kgrandis):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner:  kgrandis
Status:  assigned| Milestone:  1.1 
 Component:  Core framework  |   Version:  1.0 
Resolution:  |  Keywords:  
 Stage:  Accepted| Has_patch:  0   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by kgrandis):

  * owner:  nobody => kgrandis
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
-+--
  Reporter:  drakkan | Owner:  nobody
Status:  new | Milestone:  1.1   
 Component:  Core framework  |   Version:  1.0   
Resolution:  |  Keywords:
 Stage:  Accepted| Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by jacob):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #9847: hardcoded string in core/handlers/base.py

[Django]

#9847: hardcoded string in core/handlers/base.py
+---
 Reporter:  drakkan |   Owner:  nobody
   Status:  new |   Milestone:
Component:  Core framework  | Version:  1.0   
 Keywords:  |   Stage:  Unreviewed
Has_patch:  0   |  
+---
 in core/handlers/base.py is hardcoded an h1:

 Permission denied

 so this string not transable,

 regards
 drakkan

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---