Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.3 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by jezdez):

 Looks good to me, maby "l10n" for the keyword would be better, e.g. Pootle
 uses it here:
 
https://translate.svn.sourceforge.net/svnroot/translate/src/trunk/Pootle/local_apps/pootle_app/management/commands/makepropermessages.py

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.3 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by claudep):

  * needs_docs:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.3 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by claudep):

 Patch revised. I have no personal preference for the comment keyword, and
 I don't think there is any standard about it. I've seen "xgettext:" (don't
 like it at all), "Translators:" (a bit verbose?).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.3 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by clouserw):

 > I certainly think this is a neat idea, but don't really like the literal
 that triggers the comment adoption, "L10n". Not having seen this
 elsewhere, is this again a standard somehow?

 There is no standard that I know of.  The goal is something short, unique,
 and relevant; "L10n" fits the bill.  We started using it at Mozilla years
 ago and continue to do so.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.3 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by jezdez):

 I certainly think this is a neat idea, but don't really like the literal
 that triggers the comment adoption, "L10n". Not having seen this
 elsewhere, is this again a standard somehow?

 The reorganization of the tests isn't really necessary and actually makes
 it harder to backport single tests to 1.2.X. I'd appreciate it if that
 could be reverted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.3 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  1 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by claudep):

  * needs_docs:  0 => 1
  * has_patch:  0 => 1

Comment:

 When reviewing martinb's patch, I wonder what value we add in making the
 addcomments switch optional and the extraction keyword configurable.

 I have proposed a new patch, much simpler, which simply extract comments
 with the L10n keyword. Extracting translator comments should never be
 optional IMHO.

 About tests, it's slightly messed up in the patch because I reorganized
 them to not require a new class for each type of test. The only real new
 test is the test_comments_extractor method.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.3 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by ubernostrum):

  * milestone:  1.2 => 1.3

Comment:

 This feels too much like a feature request to be on the 1.2 milestone at
 this point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  1.2 
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by clouserw):

  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by anonymous):

 Replying to [comment:8 clouserw]:
 > I haven't tested it either (it looks ok) but your help text is unclear
 to me.

 I stole this text directly from the xgettext manual page (or help output?)
 without change.

 > Include comments directly before gettext calls in output file.  If TAG
 is specified only comments matching TAG will be included.

 Yes, this sounds better.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by clouserw):

 I haven't tested it either (it looks ok) but your help text is unclear to
 me.  "place comment block with TAG (or those preceding keyword lines) in
 output file" - That sounds like it'll grab comments with the tag from
 anywhere, whereas the comment still needs to be directly before the call
 to gettext.  Might just be the way I'm reading it, but I think this is
 more clear:Include comments directly before gettext calls in output
 file.  If TAG is specified only comments matching TAG will be included.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by martinb):

 * cc: martinb (added)

Comment:

 The patch I just added is not tested nor do I have any idea whether this
 is the way to go. Could please somebody have a look at it? TIA.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by clouserw):

 --add-comments accepts an optional tag which would filter the current
 comments and prevent needing to go through them all manually.  If you set
 a standard prefix for developer comments it makes extraction easy.  For
 example:

 {{{ # L10n: This variable is a button }}}

 would be extracted with

 {{{ xgettext --add-comments=L10n }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by clouserw):

 * cc: clous...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 [12296] is a first step in this direction.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  
Status:  new   | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Unreviewed| Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by mtredinnick):

  * owner:  mtredinnick =>
  * status:  assigned => new

Comment:

 Whoops. Didn't mean to assign this to me. Anybody can do this with care
 and research.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10004: Enable -c switch in xgettext call to collect translator comments

[Django]

#10004: Enable -c switch in xgettext call to collect translator comments
---+
  Reporter:  claudep   | Owner:  mtredinnick 
Status:  assigned  | Milestone:  
 Component:  Internationalization  |   Version:  1.0 
Resolution:|  Keywords:  makemessages
 Stage:  Unreviewed| Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by mtredinnick):

  * status:  new => assigned
  * needs_better_patch:  => 0
  * component:  django-admin.py => Internationalization
  * needs_tests:  => 0
  * owner:  nobody => mtredinnick
  * needs_docs:  => 0

Comment:

 I thought there was already a ticket open for this, but I can't find it
 now. So maybe it's just one of those things that's been on my TODO list
 for ages. We should certainly do something like this. We need to specify
 (and document) a tag to mark the comments to include, since there are lots
 of places where there are comments preceding translation calls that are
 not at all relevant to the localisation process.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---