Re: [Django] #10369: {% trans %} and {% blocktrans %} breaking auto escape
#10369: {% trans %} and {% blocktrans %} breaking auto escape
-+--
Reporter: Briel | Owner: nobody
Status: new | Milestone: 1.1
Component: Internationalization| Version: 1.0
Resolution: | Keywords:
Stage: Accepted| Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-+--
Changes (by andrewbadr):
* owner: andrewbadr => nobody
Comment:
Added underscores to mark the function private. I've tried to come up with
a way to do this using classes and inheritence but couldn't come up with
anything sensible. The `Node` class already has a `render` method with a
different signature. If "add some underscores and call it a day" is good
enough, then I guess the patch is ready, otherwise someone else should
take a look.
--
Ticket URL:
Django
Re: [Django] #10369: {% trans %} and {% blocktrans %} breaking auto escape
#10369: {% trans %} and {% blocktrans %} breaking auto escape
-+--
Reporter: Briel | Owner: andrewbadr
Status: new | Milestone: 1.1
Component: Internationalization| Version: 1.0
Resolution: | Keywords:
Stage: Accepted| Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-+--
Changes (by andrewbadr):
* has_patch: 0 => 1
Comment:
Variables aren't getting escaped in the ''trans'' and ''blocktrans''
template tags because, unlike other template tags, they render their own
contents. For ''blocktrans'', one solution would be to save a VariableNode
for each variable token in the parser, then render them all before the
string interpolation. That seemed complicated, so I implemented the
solution in this patch, at the cost of a new module-level function in
django.template.
--
Ticket URL:
Django
Re: [Django] #10369: {% trans %} and {% blocktrans %} breaking auto escape
#10369: {% trans %} and {% blocktrans %} breaking auto escape
-+--
Reporter: Briel | Owner: andrewbadr
Status: new | Milestone: 1.1
Component: Internationalization| Version: 1.0
Resolution: | Keywords:
Stage: Accepted| Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-+--
Changes (by andrewbadr):
* owner: nobody => andrewbadr
--
Ticket URL:
Django
Re: [Django] #10369: {% trans %} and {% blocktrans %} breaking auto escape
#10369: {% trans %} and {% blocktrans %} breaking auto escape
-+--
Reporter: Briel | Owner: nobody
Status: new | Milestone: 1.1
Component: Internationalization| Version: 1.0
Resolution: | Keywords:
Stage: Accepted| Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-+--
Changes (by jacob):
* needs_better_patch: => 0
* needs_docs: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* milestone: => 1.1
--
Ticket URL:
Django
