Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
-+-
   Reporter:  Matthew|  Owner:  nobody
  Flanagan   | Status:  closed
   Type:  Bug|  Component:  contrib.formtools
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  wizard sprintnov13
 Resolution:  wontfix|  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  1  |
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Superseded by #9200.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
-+-
   Reporter:  Matthew|  Owner:  nobody
  Flanagan   | Status:  new
   Type:  Bug|  Component:  contrib.formtools
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  wizard sprintnov13
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  1  |
-+-
Changes (by patchhammer):

 * needs_better_patch:  0 => 1
 * easy:   => 0


Comment:

 trac-10557.2.diff fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
-+-
   Reporter:  Matthew|Owner:  nobody
  Flanagan   |   Status:  new
   Type:  Bug|Component:  contrib.formtools
  Milestone:  1.3| Severity:  Normal
Version:  SVN| Keywords:  wizard sprintnov13
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by SmileyChris):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.3   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard sprintnov13
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by steph):

  * keywords:  wizard => wizard sprintnov13

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.3   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by lukeplant):

 There are backwards compatibility issues with changing the signature of
 `FormWizard.render_template`. It is a method that subclasses can override,
 therefore changes to it must be done with keyword arguments, '''and''' any
 time it is called from the `FormWizard` class we must check that the
 method accepts the keyword argument we want to pass (use
 inspect.getargspec).

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.3   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by steph):

  * needs_better_patch:  1 => 0
  * needs_tests:  1 => 0

Comment:

 .. just added a better patch including tests for the old previous_fields
 and the new previous_fields_list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.3   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  1 
Needs_better_patch:  1  |  
+---
Changes (by lukeplant):

  * needs_better_patch:  0 => 1
  * needs_tests:  0 => 1
  * stage:  Ready for checkin => Accepted

Comment:

 It's not ready for checkin if it's not backwards compatible, as Jacob said
 before.  This needs a much better patch - for example, a new method that
 provides the new required format.  With docs and tests, of course.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.3   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Ready for checkin  | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by lrekucki):

  * needs_better_patch:  1 => 0
  * stage:  Accepted => Ready for checkin

Comment:

 It's 1.3 now and apart from not being backwards compatible, looks good to
 me. This also helps writing tests, because you don't have to parse the raw
 HTML to get the security_hash for the next step.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.3   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  1  |  
+---
Changes (by ubernostrum):

  * milestone:  1.2 => 1.3

Comment:

 If it's not backwards-compatible it can't land in 1.2; luckily, you get
 another release cycle to get it into shape :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.2   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  1  |  
+---
Changes (by jacob):

  * needs_better_patch:  0 => 1

Comment:

 This doesn't appear to be backwards compatible, which it needs to be if
 it's to go into 1.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.2   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by Matthew Flanagan ):

 See here for a installable module if you don't want to wait until Django
 1.2 arrives.

 http://wadofstuff.blogspot.com/2009/07/improved-django-formwizard.html

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10557: FormWizard should not output raw HTML for previous_fields

[Django]

#10557: FormWizard should not output raw HTML for previous_fields
+---
  Reporter:  Matthew Flanagan   | 
Owner:  nobody
Status:  new| 
Milestone:  1.2   
 Component:  django.contrib.formtools   |   
Version:  SVN   
Resolution: |  
Keywords:  wizard
 Stage:  Accepted   | 
Has_patch:  1 
Needs_docs:  0  |   
Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by jacob):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---