Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  closed  | Milestone:  1.2   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  duplicate   |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by jacob):

  * status:  new => closed
  * resolution:  => duplicate

Comment:

 Now that the docs are in, I'm closing this as a dup of #11022. Please open
 another ticket for the other thing, if it's indeed a bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by kmtracey):

 This last comment is referring to a different problem, recently
 introduced, see #12962.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by anonymous):

 * cc: gonz (removed)
 * cc: yo...@aureal.pe (added)

Comment:

 the problem is not with the delete method, is with the delete action from
 the admin panel when i enable actions for a model.

 the problem is that the action never come to {{{ contrib/admin/actions.py
 }}}

 the problem is in {{{ contrib/admin/options.py:701 }}} in the {{{
 response_action }}} method

 the problem is that when u call to confirm the action, the request.POST
 method don't have the 'index' key.

 i change the line 701 from
 {{{
 if 'index' not in request.POST:
 }}}

 to
 {{{
 if 'index' not in request.POST and 'post' not in request.POST:
 }}}

 and the problem get corrected

 btw, this litle fix correct another serious bug related to this, if i for
 example use a modelform with editable_fields and use the actions then when
 i confirm the bug, for some dark magic code in django that get in another
 dimension in the code, i obtain an strange exception:

 {{{
 [u'ManagementForm data is missing or has been tampered with']
 }}}

 the fix above correct this bug too

 i put this one here to some django coder attend this, the fix is very
 little and correct and severe problem that need to be fixed before 1.2
 release

 sorry if i post this anonymous i dont have time now, i need to take a bus
 in a few minutes and find the bug in an app that i am coding with django
 trunk code

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by mrts):

 Quoting `contrib/admin/actions.py`:
 {{{
 for obj in queryset:
 obj_display = force_unicode(obj)
 modeladmin.log_deletion(request, obj, obj_display)
 queryset.delete()
 }}}

 As such, the queryset is already iterated over and the code already
 behaves a more like "delete lots of individual objects" than "bulk
 deletion of objects" by logging the individual deletions. As the `INSERT`
 in `modeladmin.log_deletion()` is probably much more costly than
 `obj.delete()`, the bulk delete optimization does not give the "dramatic"
 improvement in efficiency it would without `log_deletion()`.

 In my humble opinion, the following is both more natural (and more
 consistent by logging deletion only after it succeeds):
 {{{
 for obj in queryset:
 obj_display = force_unicode(obj)
 obj.delete()
 modeladmin.log_deletion(request, obj, obj_display)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by gonz):

 * cc: gonz (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by jacob):

  * milestone:  1.1 => 1.2

Comment:

 I'm punting on the design decision until after 1.1, but #11022 tracks the
 need for some docs for now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:  1.1   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by runeh):

 #10754 said the opposite. Signal handlers are called but not delete()

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:  1.1   
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by kmtracey):

  * milestone:  => 1.1

Comment:

 #10754 brought this up again, mentioning that signal handlers aren't
 called.  I think beefing up the doc on admin actions to mention this
 behavior and indicate how to avoid it would address the issue.  Given
 we've had two people notice this so far it'd be good to get some doc
 mention for it into 1.1, so I set the milestone for that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:
 Component:  django.contrib.admin|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by Alex):

  * component:  Uncategorized => django.contrib.admin

Comment:

 Right now the way to avoid it is to write your own delete items action,
 which frankly I'm in favor of.  Though we aren't paragons of efficiency I
 think we generally try to avoid executing wanton queries.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:
 Component:  Uncategorized   |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by kmtracey):

 I agree it makes sense from the programmer's point of view that bulk
 delete bypasses individual delete overrides.  On the other side, though, I
 believe there are plenty of users of the admin interface who never have
 anything to do with writing code, haven't the vaguest idea what a queryset
 is, and therefore might be rather surprised that bulk delete from admin
 behaves somewhat differently than individual delete.  One might argue that
 the people writing the code behind that -- who have customized delete()
 and probably been careful to not use delete() on a queryset if there is
 something in their custom delete() they want to be sure always happens --
 should be responsible for ensuring that bulk delete isn't available from
 their admin or is customized to do the right thing (can it be?  I've done
 nothing with bulk actions in admin -- could one replace the default delete
 method with a different one that calls individual deletes?).  At a minimum
 we probably need to mention this in the admin actions doc. If we could
 provide guidance on how to avoid it, if desired, while still allowing the
 user the convenience of bulk delete, that would be even better.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:
 Component:  Uncategorized   |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by Alex):

 You just referred to it as "admin bulk actions", in fact that's been what
 it's been refered to for quite a while I think.  I believe that stands for
 itself.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
-+--
  Reporter:  msurdi  | Owner:  nobody
Status:  new | Milestone:
 Component:  Uncategorized   |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * stage:  Unreviewed => Design decision needed

Comment:

 It's arguable that this is an inconsistency. After all, calling delete()
 on a queryset _doesn't_ call the delete() method on the model. This is
 well documented behavior. What we need to decide is whether the admin bulk
 actions are "delete lots of individual objects", or a "bulk deletion of
 objects". I'm happy with either outcome, but I'd be happy to hear
 opinions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10751: Admin actions not calling model's delete() method

[Django]

#10751: Admin actions not calling model's delete() method
+---
  Reporter:  msurdi | Owner:  nobody
Status:  new| Milestone:
 Component:  Uncategorized  |   Version:  SVN   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by msurdi):

 * cc: matiassu...@gmail.com (added)
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---