Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
   Reporter:  ntoll |  Owner:  nobody
   Type:  Bug   | Status:  closed
  Milestone:|  Component:  Testing framework
Version:|   Severity:  Normal
 Resolution:  fixed |   Keywords:  Textile
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  1 |  Easy pickings:  0
+---
Changes (by lukeplant):

 * status:  reopened => closed
 * resolution:   => fixed
 * severity:  Release blocker => Normal


Comment:

 1.2.1 was released *before* the fix for this, and in 1.2.2 and on 1.3.X
 and trunk, the test passes (with textile==2.1.4). I have no idea why the
 bug has been reopened.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
   Reporter:  ntoll |  Owner:  nobody
   Type:  Bug   | Status:  reopened
  Milestone:|  Component:  Testing framework
Version:|   Severity:  Release blocker
 Resolution:|   Keywords:  Textile
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  1 |  Easy pickings:  0
+---
Changes (by patchhammer):

 * needs_better_patch:  0 => 1
 * easy:   => 0


Comment:

 10843.patch fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+-
   Reporter:  ntoll |Owner:  nobody
   Type:  Bug   |   Status:  reopened
  Milestone:|Component:  Testing framework
Version:| Severity:  Release blocker
 Resolution:| Keywords:  Textile
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  0 |
+-
Changes (by SmileyChris):

 * type:   => Bug
 * severity:   => Release blocker


Comment:

 Increasing severity, working tests are paramount.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
  Reporter:  ntoll  | Owner:  nobody 
Status:  reopened   | Milestone: 
 Component:  Testing framework  |   Version: 
Resolution: |  Keywords:  Textile
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by themystic):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Occurred again with django 1.2.1 and textile 2.1.4.
 {{{
 $python manage.py test
 }}}
 yields:
 {{{
 ==
 FAIL: test_textile (django.contrib.markup.tests.Templates)
 --
 Traceback (most recent call last):
   File "/usr/local/lib/python2.6/dist-
 packages/Django-1.2.1-py2.6.egg/django/contrib/markup/tests.py", line 27,
 in test_textile
 Paragraph 2 with “quotes” and code""")
 AssertionError: u'Paragraph 1\n\n\tParagraph 2 with
 “quotes” and code' != 'Paragraph 1\
 \n\nParagraph 2 with “quotes” and
 code'

 --
 }}}
 Removing the textile egg resolves the issue (since I don't need textile
 for anything).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
  Reporter:  ntoll  | Owner:  nobody 
Status:  new| Milestone: 
 Component:  Testing framework  |   Version: 
Resolution: |  Keywords:  Textile
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Comment (by brutasse):

 Wouldn't it be safe just to change

 {{{self.assertEqual(rendered, """Paragraph 1 # etc }}}

 to

 {{{self.assertEqual(rendered.replace('\t', ''), """Paragraph 1 #
 etc }}}

 We don't really care about tabulations (only the markup is important), and
 it
 prevents the test to fail if textile changes its behavior again in the
 future.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
  Reporter:  ntoll  | Owner:  nobody 
Status:  new| Milestone: 
 Component:  Testing framework  |   Version: 
Resolution: |  Keywords:  Textile
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
  Reporter:  ntoll  | Owner:  nobody 
Status:  new| Milestone: 
 Component:  Testing framework  |   Version: 
Resolution: |  Keywords:  Textile
 Stage:  Unreviewed | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by arthurk):

  * needs_better_patch:  1 => 0

Comment:

 I've only tried versions from 2.1.0 to 2.1.3. The 2.0.x versions don't
 have the '\t'.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
  Reporter:  ntoll  | Owner:  nobody 
Status:  new| Milestone: 
 Component:  Testing framework  |   Version: 
Resolution: |  Keywords:  Textile
 Stage:  Unreviewed | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  1  |  
+---
Changes (by kmtracey):

  * needs_better_patch:  0 => 1

Comment:

 Just adding a '\t' will cause the test to fail on older versions of
 textile (the test currently works for me, for example, with textile 2.0.10
 which is what is installed on my ubuntu machine, but would break if the
 test was expecting the extra '\t').  We don't want to just move the
 problem, we want to fix it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
  Reporter:  ntoll  | Owner:  nobody 
Status:  new| Milestone: 
 Component:  Testing framework  |   Version: 
Resolution: |  Keywords:  Textile
 Stage:  Unreviewed | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by arthurk):

  * has_patch:  0 => 1

Comment:

 I can confirm that. There needs to be an extra '\t'.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10843: django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[Django]

#10843: django.contrib.markup.tests.Templates test_textile fails with python
textile 2.1.3 and Django 1.0.2 final
+---
  Reporter:  ntoll  | Owner:  nobody 
Status:  new| Milestone: 
 Component:  Testing framework  |   Version: 
Resolution: |  Keywords:  Textile
 Stage:  Unreviewed | Has_patch:  0  
Needs_docs:  0  |   Needs_tests:  0  
Needs_better_patch:  0  |  
+---
Changes (by Alex):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Old description:

> Getting the following message:
>
> ==
> FAIL: test_textile (django.contrib.markup.tests.Templates)
> --
> Traceback (most recent call last):
>   File "/Library/Python/2.5/site-
> packages/django/contrib/markup/tests.py", line 27, in test_textile
> Paragraph 2 with “quotes” and
> code""")
> AssertionError: u'Paragraph 1\n\n\tParagraph 2 with
> “quotes” and code' != 'Paragraph
> 1\n\nParagraph 2 with “quotes” and
> code'
>
> --
>
> Looks like there is an extra "\t" in there before the "Paragraph 2" 
> element.

New description:

 Getting the following message:
 {{{
 ==
 FAIL: test_textile (django.contrib.markup.tests.Templates)
 --
 Traceback (most recent call last):
   File "/Library/Python/2.5/site-packages/django/contrib/markup/tests.py",
 line 27, in test_textile
 Paragraph 2 with “quotes” and code""")
 AssertionError: u'Paragraph 1\n\n\tParagraph 2 with
 “quotes” and code' != 'Paragraph
 1\n\nParagraph 2 with “quotes” and
 code'

 --
 }}}
 Looks like there is an extra "\t" in there before the "Paragraph 2" 
 element.

Comment:

 Please use preview.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---