Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  closed| Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:  duplicate |  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by mtredinnick):

 If it needs to be reverted, then revert it. I checked that patch in
 because it was fixing one very obvious bug and the other changes looked
 reasonable and probably necessary. By checking it in, it got tested and a
 problem was found, which was the whole point! So now can somebody who can
 test on Oracle please bring this to a close.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  closed| Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:  duplicate |  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by kmtracey):

  * status:  new => closed
  * resolution:  => duplicate

Comment:

 We've also got #10716 re-opened for this problem, which is where I put a
 patch as I hadn't seen this one yet.  Can anyone with more Oracle
 knowledge than me comment on the patch I added to #10716?  It does revert
 the database name change, but instead of reverting the
 `ettings`->`settings` typo fix it tries to fix the problem that that typo
 fix revealed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by ikelly):

 I'm agreed with Matt.  The change that was made in [10547] looks like it's
 just fixing some omissions, but it actually significantly changes the way
 testing works in Oracle (admittedly, oracle/creation.py is rather
 confusing in terms of where it pulls parameters from and how it applies
 them).  This should be reverted, and the changes made should only be
 considered for 1.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 Two things to remember, if the decision to revert the changes is finally
 made:

  * [10548] implemented the same changes to the 1.0.x branch
  * Maybe the fix for this obvious typo bug can be left out of the patch
 revert?:
 
http://code.djangoproject.com/browser/django/trunk/django/db/backends/oracle/creation.py?rev=10546#L247

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by Alex):

 I understand the use of settings.TEST_* settings, what I don't understand
 is why [10547] would assign to settings.DATABASE_*.  The settings.TEST_*
 is something that's going to have to be dealt with as a part of multidb(my
 inclination is to move it to DATABASE_OPTIONS), but for now we should be
 keeping our hands off of settings.DATABASE_* as that's just a regression.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by mboersma):

 It was commit [10547] that broke the tests for Oracle.  I agree the
 creation.py code is messy, but there was no actual reproducible bug
 described, no test case, and evidently it was checked in without actually
 running the tests against Oracle.  We're a bit past due on Django 1.1, so
 let's save the code beautification projects for later and just revert it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by ikelly):

 Replying to [comment:1 Alex]:
 > I'm not an expert, but why is the Oracle backend modifying the global
 settings, we specifically changed all the backends *not* to do that.

 I don't recall off-hand whether it's necessary or not, but the Oracle
 backend still modifies the global settings when running the test suite
 because that's what all the other backends do.  See
 
http://code.djangoproject.com/browser/django/trunk/django/db/backends/creation.py#L324

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10844: r10547 broke testing with Oracle

[Django]

#10844: r10547 broke testing with Oracle
---+
  Reporter:  jbronn| Owner:  ikelly 
Status:  new   | Milestone:  1.1
 Component:  Database layer (models, ORM)  |   Version:  SVN
Resolution:|  Keywords:  oracle test
 Stage:  Unreviewed| Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I'm not an expert, but why is the Oracle backend modifying the global
 settings, we specifically changed all the backends *not* to do that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---