Re: [Django] #11583: Incomplete HTML Escaping

[Django]

#11583: Incomplete HTML Escaping
-+--
  Reporter:  rlaa...@wiktel.com  | Owner:  nobody
Status:  closed  | Milestone:
 Component:  Uncategorized   |   Version:  1.0   
Resolution:  duplicate   |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Comment (by Tomasz Elendt ):

 Replying to [comment:5 kmtracey]:
 > Replying to [comment:3 anonymous]:
 > > First change in `admin_list.py` is the same as one of mine in #11502.
 I believe I made my patch correctly.
 >
 > No, it's not correct -- the diff isn't from the root of the django tree.
 The first file here is listed simply as "templatetags/admin_list.py", but
 there is no "templatetags" directory in the root of the django tree, so
 whoever goes to apply the patch has to find the right place within the
 django tree (presumably django/contrib/admin) to apply the diff.  It's
 better if the person applying the patch doesn't have to guess where it
 goes.
 >
 > As the fix here is now entirely duplicated by the latest patch for
 #11502, which is relative to django root, I'm closing this one in favor of
 that one.

 Sorry, that was me in comment no. 3 — I forgot to sign my name. And I was
 thinking about my patch (in ticket #11502).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11583: Incomplete HTML Escaping

[Django]

#11583: Incomplete HTML Escaping
-+--
  Reporter:  rlaa...@wiktel.com  | Owner:  nobody
Status:  closed  | Milestone:
 Component:  Uncategorized   |   Version:  1.0   
Resolution:  duplicate   |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Changes (by kmtracey):

  * status:  new => closed
  * resolution:  => duplicate

Comment:

 Replying to [comment:3 anonymous]:
 > First change in `admin_list.py` is the same as one of mine in #11502. I
 believe I made my patch correctly.

 No, it's not correct -- the diff isn't from the root of the django tree.
 The first file here is listed simply as "templatetags/admin_list.py", but
 there is no "templatetags" directory in the root of the django tree, so
 whoever goes to apply the patch has to find the right place within the
 django tree (presumably django/contrib/admin) to apply the diff.  It's
 better if the person applying the patch doesn't have to guess where it
 goes.

 As the fix here is now entirely duplicated by the latest patch for #11502,
 which is relative to django root, I'm closing this one in favor of that
 one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11583: Incomplete HTML Escaping

[Django]

#11583: Incomplete HTML Escaping
-+--
  Reporter:  rlaa...@wiktel.com  | Owner:  nobody
Status:  new | Milestone:
 Component:  Uncategorized   |   Version:  1.0   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Comment (by Tomasz Elendt ):

 Ok. I also pulled the second change (in `widgets.py`) to my patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11583: Incomplete HTML Escaping

[Django]

#11583: Incomplete HTML Escaping
-+--
  Reporter:  rlaa...@wiktel.com  | Owner:  nobody
Status:  new | Milestone:
 Component:  Uncategorized   |   Version:  1.0   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Comment (by anonymous):

 First change in `admin_list.py` is the same as one of mine in #11502. I
 believe I made my patch correctly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11583: Incomplete HTML Escaping

[Django]

#11583: Incomplete HTML Escaping
-+--
  Reporter:  rlaa...@wiktel.com  | Owner:  nobody
Status:  new | Milestone:
 Component:  Uncategorized   |   Version:  1.0   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Changes (by russellm):

  * needs_better_patch:  0 => 1

Comment:

 Could you please generate patches relative to the root of the Django
 source tree - as it is, we have to try and work out where this patch
 applies.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11583: Incomplete HTML Escaping

[Django]

#11583: Incomplete HTML Escaping
-+--
  Reporter:  rlaa...@wiktel.com  | Owner:  nobody
Status:  new | Milestone:
 Component:  Uncategorized   |   Version:  1.0   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by anonymous):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 The change in templatetags/admin_list.py corrects escaping in the
 pagination. It wasn't escaping the ampersand if you had a filter applied.
 The change to widgets.py addresses a case where I had a raw_id_field with
 a related model having a __unicode__ representation that included an
 ampersand.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---