Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
---+--
 Reporter:  jedie  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  1  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+--

Comment (by ogpcludi ):

 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d5abbf2aa775aba1b37dc0cf9267efa8%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
---+--
 Reporter:  jedie  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  1  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+--
Changes (by ogpcludi ):

 * needs_better_patch:  0 => 1
 * component:  Core (Management commands) => contrib.admin
 * version:  1.1 => master
 * easy:  0 => 1
 * type:  New feature => Uncategorized
 * keywords:   => 1
 * needs_docs:  0 => 1
 * ui_ux:  0 => 1
 * resolution:  duplicate => fixed
 * stage:  Accepted => Unreviewed


Comment:

 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6ace813256c28d3dc3ff06dc4a42d3ad%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
-+-
 Reporter:  jedie|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:  1.1
  commands)  |   Resolution:  duplicate
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aaugustin):

 In [17197]:
 {{{
 #!CommitTicketReference repository="" revision="17197"
 Fixed #16397 -- Respected the --traceback flag in BaseCommand. This should
 make import loops easier to debug. Refs #11667, #17369.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
-+-
 Reporter:  jedie|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:  1.1
  commands)  |   Resolution:  duplicate
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 I'm closing this ticket in favor of #16397 which reports the same problem
 (as far as I can tell) and has a more recent patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
-+-
 Reporter:  jedie|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:  1.1
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by anonymous):

 * ui_ux:   => 0
 * easy:   => 0


Comment:

 Thanks so much!!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py runserver  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Changes (by vanschelven):

 * cc: klaasvanschel...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py runserver  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Comment (by vanschelven):

 Any movement on this?

 I can't count the number of times I've dived into the Django code and
 added a 'raise'. Of course, the proper solution would be simply to drop
 the associated try/catch block, since all it does is obfuscate things.

 This can be rewritten:

 {{{
 206 if self.can_import_settings:
 207 try:
 208 from django.utils import translation
 209 translation.activate('en-us')
 210 except ImportError, e:
 211 # If settings should be available, but aren't,
 212 # raise the error and quit.
 213 sys.stderr.write(smart_str(self.style.ERROR('Error:
 %s\n' % e)))
 214 sys.exit(1)
 }}}

 I'll submit a patch in a sec.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py runserver  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Comment (by peterlundberg):

 I agree that wrapping the exceptions makes debugging import errors very
 hard and would be Good Thing to improve with Django
 [[BR]]
  I have on occasion replaced
 {{{
 raise ImproperlyConfigured('ImportError %s: %s' % (app, e.args[0]))
 }}}
 with just
 {{{
 raise
 }}}
 in `template/loaders/app_directories.py` line 24 (django 1.2.1) which
 allows me to see what module/file was trying to do the failing import when
 running `manage.py test`

 A message like `'cannot import %s from %s line %d'` from `ImportError`
 would help a lot, but that is more a python issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py runserver  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Comment (by Joshimale):

 In relation to the file deletion question, might I suggest we at least
 allow one to select existing files? For example, if I want to use the same
 image in two different objects, the current image field uploads another
 copy and renames it rather than noticing the file already exists and
 asking to overwrite or use the existing [http://www.promogiftstore.co.uk
 Corporate Gifts] | [http://www.alternativeacnetreatments.com acne
 treatments] file. Seems like a slightly complex issue. Probably worth
 doing some use cases?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py runserver  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Comment (by Joshimale):

 It would be great to have this added to core... are there
 [http://www.propa.net Corporate Gifts] important reasons why this hasn't
 happened in the 5 months since submission?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py runserver  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Changes (by ariddell):

  * owner:  => nobody

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner: 
Status:  new| Milestone: 
 Component:  django-admin.py runserver  |   Version:  1.1
Resolution: |  Keywords: 
 Stage:  Accepted   | Has_patch:  1  
Needs_docs:  0  |   Needs_tests:  1  
Needs_better_patch:  0  |  
+---
Changes (by ariddell):

  * owner:  ariddell =>
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  ariddell
Status:  assigned   | Milestone:  
 Component:  django-admin.py runserver  |   Version:  1.1 
Resolution: |  Keywords:  
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  1   
Needs_better_patch:  0  |  
+---
Changes (by ariddell):

 * cc: ridd...@fastmail.es (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  ariddell
Status:  assigned   | Milestone:  
 Component:  django-admin.py runserver  |   Version:  1.1 
Resolution: |  Keywords:  
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  1   
Needs_better_patch:  0  |  
+---
Changes (by ariddell):

  * owner:  nobody => ariddell
  * status:  new => assigned

Comment:

 I had a similar issue when running tests. I would do a `manage.py test`
 and get an `django.core.exceptions.ImproperlyConfigured: App with label
  could not be found`. The real culprit was an import loop. As jedie
 suggests, displaying the original ImportError would be helpful.

 I'll attached a patch for the `manage.py test` case as
 `django_11667_manage_test.diff`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11667: Full traceback if import error before model validation

[Django]

#11667: Full traceback if import error before model validation
+---
  Reporter:  jedie  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py runserver  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  1 
Needs_better_patch:  0  |  
+---
Comment (by jedie):

 django.core.management.base.BaseHandler.load_middleware will also "mask"
 some import errors. Add a separate patch, if settings.DEBUG is on, raise
 the original error instead of ImproperlyConfigured, so the user will get a
 helpfull traceback.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---