Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
 Reporter:  jukvalim |Owner:  jukvalim
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"a8ded528b3c2f66d56f1f5499cf2021f3829c8e4"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a8ded528b3c2f66d56f1f5499cf2021f3829c8e4"
 [1.7.x] Fixed #11775 -- Made ABSOLUTE_URL_OVERRIDES work with models that
 don't define get_absolute_url().

 Thanks jukvalim for the report and initial patch,
 and Preston Timmons for review.

 Backport of c32bc1a7a7 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.23e6c9892fe7937635f22482d2d4cf82%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
 Reporter:  jukvalim |Owner:  jukvalim
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c32bc1a7a7bbb3d5bd0a2c11bc77dd5ab1c32fbc"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c32bc1a7a7bbb3d5bd0a2c11bc77dd5ab1c32fbc"
 Fixed #11775 -- Made ABSOLUTE_URL_OVERRIDES work with models that don't
 define get_absolute_url().

 Thanks jukvalim for the report and initial patch,
 and Preston Timmons for review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d669a447dc00b0679d71b6719492997b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
 Reporter:  jukvalim |Owner:  jukvalim
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by prestontimmons):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.393f8f6e8d4c4347303b13bcb1f1be00%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
 Reporter:  jukvalim |Owner:  jukvalim
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by prestontimmons):

 Tim, I reviewed PR. The changes look good and work for me.

 I agree, the regression should be fixed for as long as
 ABSOLUTE_URL_OVERRIDES is part of Django.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0f50dbac9780fca99e7d9add2b982529%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
 Reporter:  jukvalim |Owner:  jukvalim
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * severity:  Normal => Release blocker


Comment:

 As reported in [https://github.com/django/django/pull/3200 this PR],
 Django 1.7 broke the ability to use `ABSOLUTE_URL_OVERRIDES` for
 `auth.User` since it's `get_absolute_url()` was removed in #20881.

 I think we should fix this ticket in order to fix that regression.
 [https://github.com/django/django/pull/3203 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1130820e30d9336f9a3d0ab7a72f10d3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
 Reporter:  jukvalim |Owner:  jukvalim
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 I was going to suggest we could replace
 `settings.ABSOLUTE_URL_OVERRIDES.get('%s.%s' % (opts.app_label,
 opts.model_name)` with URL reversing; something like `reverse('%s.%s
 -absolute-url') % (opts.app_label, opts.model_name)`, but this would force
 people to rename their URLs in order to match the convention.

 Given the lack of interest in this ticket, maybe it would be better to
 simply "won't fix" it and remove it when we come up with a solution for
 #8264 "Replace get_absolute_url with more sane alternative".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8e9f4fa19e6dfe20a9e36015d6b96e2b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
 Reporter:  jukvalim |Owner:  jukvalim
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aaugustin):

 Can we deprecate ABSOLUTE_URL_OVERRIDES instead? Currently
 `get_absolute_url` and related features create lots of cross-layer
 coupling.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.222b30ca9e0514dc6854339822d05877%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
   Reporter:  jukvalim   |  Owner:  jukvalim
   Type:  New| Status:  assigned
  feature|  Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-
Changes (by patchhammer):

 * needs_better_patch:  0 => 1
 * easy:   => 0


Comment:

 patch.diff fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
-+-
   Reporter:  jukvalim   |Owner:  jukvalim
   Type:  New|   Status:  assigned
  feature|Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by baumer1122):

 * type:   => New feature
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
---+
  Reporter:  jukvalim  | Owner:  jukvalim
Status:  assigned  | Milestone:  
 Component:  Database layer (models, ORM)  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by jukvalim):

  * needs_better_patch:  1 => 0
  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
---+
  Reporter:  jukvalim  | Owner:  jukvalim
Status:  assigned  | Milestone:  
 Component:  Database layer (models, ORM)  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  1 |  
---+
Changes (by jukvalim):

 * cc: jukvalim (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
---+
  Reporter:  jukvalim  | Owner:  jukvalim
Status:  assigned  | Milestone:  
 Component:  Database layer (models, ORM)  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  1 |  
---+
Comment (by jukvalim):

 Added two tests for ABSOLUTE_URL_OVERRIDES feature, removed use of
 currying.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
---+
  Reporter:  jukvalim  | Owner:  jukvalim
Status:  assigned  | Milestone:  
 Component:  Database layer (models, ORM)  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_better_patch:  0 => 1
  * needs_tests:  0 => 1
  * stage:  Unreviewed => Accepted

Comment:

 Seems like a reasonable idea to me, and the implementation is relatively
 simple.

 One problem with the patch - it needs tests. The fact that there aren't
 any existing tests for ABSOLUTE_URL_OVERRIDES doesn't excuse you from
 writing some. If you want to win extra Brownie points, you should take the
 opportunity to write a full test suite for the entire
 ABSOLUTE_URL_OVERRIDES feature, not just the bit you added.

 I'm also interested to see if the use of currying can be removed
 altogether. While currying is a neat trick, it doesn't seem necessary in
 this case. The historical use is actually more computationally intensive
 than it should be. All we are doing here is substituting
 cls.get_absolute_url with the appropriate override. We don't need to re-
 evaluate ABSOLUTE_URL_OVERRIDES on every call to get_absolute_url.

 As prior warning: there is also a lingering background issue surrounding
 this idea and its intersection with ReplacingGetAbsoluteUrl. No formal
 decisions have been made, but if a decision *is* made, it will impact on
 this ticket and patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models

[Django]

#11775: ABSOLUTE_URL_OVERRIDES doesn't work for the majority of contrib models
---+
  Reporter:  jukvalim  | Owner:  jukvalim
Status:  assigned  | Milestone:  
 Component:  Database layer (models, ORM)  |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Unreviewed| Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by jukvalim):

  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---