Re: [Django] #11806: FormWizard.process_step() doesn't always have a validated Form.

[Django]

#11806: FormWizard.process_step() doesn't always have a validated Form.
+---
  Reporter:  kiowa  | Owner:  nobody
Status:  closed | Milestone:
 Component:  Documentation  |   Version:  1.1   
Resolution:  duplicate  |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by mpaolini):

 previous comment was mine

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11806: FormWizard.process_step() doesn't always have a validated Form.

[Django]

#11806: FormWizard.process_step() doesn't always have a validated Form.
+---
  Reporter:  kiowa  | Owner:  nobody
Status:  closed | Milestone:
 Component:  Documentation  |   Version:  1.1   
Resolution:  duplicate  |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by anonymous):

 Replying to [comment:3 kmtracey]:
 > If you believed that then why did you not search for existing tickets?
 Which would have brought up #10882.  We don't need multiple tickets for
 the same problem.
 Ok my fault, please forgive me and commit the (3 months old) patch in
 #10882

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11806: FormWizard.process_step() doesn't always have a validated Form.

[Django]

#11806: FormWizard.process_step() doesn't always have a validated Form.
+---
  Reporter:  kiowa  | Owner:  nobody
Status:  closed | Milestone:
 Component:  Documentation  |   Version:  1.1   
Resolution:  duplicate  |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by kmtracey):

  * status:  reopened => closed
  * resolution:  => duplicate

Comment:

 Replying to [comment:2 mpaolini]:
 >
 > this is an old bug, I'm sure there are other tickets on this

 If you believed that then why did you not search for existing tickets?
 Which would have brought up #10882.  We don't need multiple tickets for
 the same problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11806: FormWizard.process_step() doesn't always have a validated Form.

[Django]

#11806: FormWizard.process_step() doesn't always have a validated Form.
+---
  Reporter:  kiowa  | Owner:  nobody
Status:  reopened   | Milestone:
 Component:  Documentation  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by mpaolini):

  * status:  closed => reopened
  * resolution:  invalid =>

Comment:

 in contrib/formtools/wizard.py
 {{{
 63  for i in range(current_step):
 64  form = self.get_form(i, request.POST)
 65  if request.POST.get("hash_%d" % i, '') !=
 self.security_hash(request, form):
 66  return self.render_hash_failure(request, i)
 67  self.process_step(request, form, i)
 }}}
 line 67: form passed to self.process_step is _never_ cleaned (happens for
 all forms before current_step)

 this is an old bug, I'm sure there are other tickets on this

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11806: FormWizard.process_step() doesn't always have a validated Form.

[Django]

#11806: FormWizard.process_step() doesn't always have a validated Form.
+---
  Reporter:  kiowa  | Owner:  nobody
Status:  closed | Milestone:
 Component:  Documentation  |   Version:  1.1   
Resolution:  invalid|  Keywords:
 Stage:  Unreviewed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by kmtracey):

  * status:  new => closed
  * needs_better_patch:  => 0
  * resolution:  => invalid
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 You've stated that the form isn't always guaranteed to be clean without
 providing an example of how that could happen.  Based on the documentation
 and a brief look at the code, that happening would seem to be a coding
 error rather than a documentation problem. So as written I believe this
 ticket is invalid.  Feel free to reopen with specifics on how to recreate
 a situation where process_step is called without a valid form, but the
 place to look for fixing it I believe will be in the code, not the
 documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---