Re: [Django] #11877: Document that request.get_host() fails when behind multiple reverse proxies

[Django]

#11877: Document that request.get_host() fails when behind multiple reverse 
proxies
-+-
 Reporter:  tomevans222  |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Documentation|  Version:  1.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  proxy forwarded  | Triage Stage:  Accepted
  get_host   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by John Borwick ):

 * ui_ux:   => 0
 * type:   => Uncategorized
 * severity:   => Normal
 * easy:   => 0


Comment:

 Note for other readers: when using the included MultipleProxyMiddleware,
 consider whether you want line 30 to pull the *last* element [-1] or the
 *first* element [0].

 The right-most/last is supposed to be the most recent proxy (per
 ). The
 left-most is the furthest upstream proxy.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11877: Document that request.get_host() fails when behind multiple reverse proxies

[Django]

#11877: Document that request.get_host() fails when behind multiple reverse 
proxies
+---
  Reporter:  tomevans222| Owner:  nobody  
Status:  new| Milestone:  
 Component:  Documentation  |   Version:  1.0 
Resolution: |  Keywords:  proxy forwarded get_host
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by arnav):

  * has_patch:  0 => 1

Comment:

 documentation patch added

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11877: Document that request.get_host() fails when behind multiple reverse proxies

[Django]

#11877: Document that request.get_host() fails when behind multiple reverse 
proxies
+---
  Reporter:  tomevans222| Owner:  nobody  
Status:  new| Milestone:  
 Component:  Documentation  |   Version:  1.0 
Resolution: |  Keywords:  proxy forwarded get_host
 Stage:  Accepted   | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Comment (by tomevans222):

 That sounds perfectly reasonable Jacob. I'll try to get a doc patch up as
 soon as $JOB allows :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #11877: Document that request.get_host() fails when behind multiple reverse proxies

[Django]

#11877: Document that request.get_host() fails when behind multiple reverse 
proxies
+---
  Reporter:  tomevans222| Owner:  nobody  
Status:  new| Milestone:  
 Component:  Documentation  |   Version:  1.0 
Resolution: |  Keywords:  proxy forwarded get_host
 Stage:  Accepted   | Has_patch:  0   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by jacob):

  * needs_better_patch:  => 0
  * component:  Core framework => Documentation
  * needs_tests:  => 0
  * summary:  request.get_host() fails when behind multiple reverse proxies
  => Document that request.get_host() fails when
  behind multiple reverse proxies
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted

Comment:

 As you say, this is not a "normal" way of deploying Django, and I don't
 think there'll be a general solution here. See the back and forth about
 handling `X-Forwarded-For` for some background: the basic problem is that
 Django can't magically know which of a list of values is "correct" here. I
 think that your solution of handling this problem in middleware is as good
 as it's gonna get.

 It would, however, be good to have this documented, so I'm hijacking this
 ticket and turning it into a doc request. We could add a note to the docs
 for `request.get_host()` and include your little bit of middleware as an
 example. Feel free to work up a doc patch if you wanna grease the wheels a
 bit.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---