Re: [Django] #12156: The csrf_token should be able to use a custom template

[Django]

#12156: The csrf_token should be able to use a custom template
---+
  Reporter:  tolano| Owner:  ericholscher
Status:  closed| Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:  wontfix   |  Keywords:  csrf_token, template
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by lukeplant):

  * status:  new => closed
  * resolution:  => wontfix

Comment:

 I think this is one of those cases where guidelines should be broken :-)
 because:

  * We never want the div to be displayed, so it should be invisible
 preferably even the in presence of rules like `form div { margin: 10px; }`
  * We cannot output class=hidden, because this code needs to be stylesheet
 agnostic.

 If you are desperate, then provide your own `{% csrf_token %}` - if you
 load a template library that provides one, it will override the builtin.
 You could also use `template.add_to_builtins`.  The amount of code needed
 is very small.

 Closing WONTFIX for the above reasons - a stylistic problem in some code
 invisible to the user is not a bug :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12156: The csrf_token should be able to use a custom template

[Django]

#12156: The csrf_token should be able to use a custom template
---+
  Reporter:  tolano| Owner:  ericholscher
Status:  new   | Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  csrf_token, template
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by tolano):

  * owner:  tolano => ericholscher
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12156: The csrf_token should be able to use a custom template

[Django]

#12156: The csrf_token should be able to use a custom template
---+
  Reporter:  tolano| Owner:  tolano  
Status:  assigned  | Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  csrf_token, template
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by tolano):

  * owner:  => tolano
  * status:  new => assigned

Comment:

 I know that is supposed to be invisible, but the designer should have all
 the control over the HTML. IMHO I don't like to insert any style into the
 HTML, and it's a guideline in my company.

 Besides of that, I don't think this makes any application less consistent,
 Django provides in several parts a way to override a template.

 The first priority should be to provide full control of the generated
 HTML.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12156: The csrf_token should be able to use a custom template

[Django]

#12156: The csrf_token should be able to use a custom template
---+
  Reporter:  tolano| Owner:  
Status:  new   | Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  csrf_token, template
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by lukeplant):

 Would you mind specifying what the design problems are?  The whole output
 is supposed to be invisible.

 The problem here is that any solution is going to be global, and I imagine
 that if you change it to 'work' in one app, it might not 'work' in another
 app.  I don't want to introduce a setting which will have this problem.
 Rather, we should encourage consistency.

  depends on there being some certain CSS, which isn't
 a good idea.  Actually, the whole style="display:none" is just being
 defensive against browser bugs anyway, it shouldn't strictly be needed.
 But the div itself is needed, for HTML validity.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12156: The csrf_token should be able to use a custom template

[Django]

#12156: The csrf_token should be able to use a custom template
---+
  Reporter:  tolano| Owner:  
Status:  new   | Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  csrf_token, template
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by ericholscher):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12156: The csrf_token should be able to use a custom template

[Django]

#12156: The csrf_token should be able to use a custom template
---+
  Reporter:  tolano| Owner:  ericholscher
Status:  assigned  | Milestone:  1.2 
 Component:  Contrib apps  |   Version:  SVN 
Resolution:|  Keywords:  csrf_token, template
 Stage:  Unreviewed| Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by ericholscher):

  * owner:  nobody => ericholscher
  * needs_better_patch:  => 0
  * status:  new => assigned
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Might not be the correct solution, but it should be somehow themable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.