Re: [Django] #12226: Test HttpResponse template attribute needlessly hard to use

[Django]

#12226: Test HttpResponse template attribute needlessly hard to use
-+
   Reporter:  carljm |Owner:  carljm
   Type: |   Status:  closed
  Component:  Testing framework  |  Version:  SVN
   Severity: |   Resolution:  fixed
   Keywords:  sprintSep2010  | Triage Stage:  Accepted
  Has patch:  1  |  Needs documentation:  1
Needs tests:  0  |  Patch needs improvement:  1
-+

Comment (by aaugustin):

 In [17839]:
 {{{
 #!CommitTicketReference repository="" revision="17839"
 Removed deprecated attribute Response.template in the test client. Refs
 #12226.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12226: Test HttpResponse template attribute needlessly hard to use

[Django]

#12226: Test HttpResponse template attribute needlessly hard to use
+---
  Reporter:  carljm | Owner:  carljm   
Status:  new| Milestone:  1.3  
 Component:  Testing framework  |   Version:  SVN  
Resolution: |  Keywords:  sprintSep2010
 Stage:  Accepted   | Has_patch:  1
Needs_docs:  1  |   Needs_tests:  0
Needs_better_patch:  1  |  
+---
Changes (by russellm):

  * needs_better_patch:  0 => 1
  * needs_docs:  0 => 1

Comment:

 Me likey.

 However, this patch needs docs. We're deprecating a feature, so:
  * We need to put an entry in the release notes.
  * We need to put an entry in internals/deprecation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12226: Test HttpResponse template attribute needlessly hard to use

[Django]

#12226: Test HttpResponse template attribute needlessly hard to use
+---
  Reporter:  carljm | Owner:  carljm   
Status:  new| Milestone:  1.3  
 Component:  Testing framework  |   Version:  SVN  
Resolution: |  Keywords:  sprintSep2010
 Stage:  Accepted   | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Changes (by ericholscher):

  * milestone:  => 1.3

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12226: Test HttpResponse template attribute needlessly hard to use

[Django]

#12226: Test HttpResponse template attribute needlessly hard to use
+---
  Reporter:  carljm | Owner:  carljm   
Status:  new| Milestone:   
 Component:  Testing framework  |   Version:  SVN  
Resolution: |  Keywords:  sprintSep2010
 Stage:  Accepted   | Has_patch:  1
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Changes (by carljm):

  * keywords:  => sprintSep2010
  * owner:  nobody => carljm
  * has_patch:  0 => 1
  * version:  1.1 => SVN

Comment:

 Attached patch starts response.template on deprecation path with
 PendingDeprecationWarning, and adds response.templates API that is always
 a list, whether empty, length 1, or longer.

 I wasn't sure what the policy is for tests in a case like this. The patch
 includes conversion of most tests to the new API, and addition of a couple
 new tests to verify the back-compat API still works. Alternatively, the
 current trunk tests still all pass unchanged if only the non-test portion
 of the patch is applied, so if the policy is to wait to convert tests
 until PendingDeprecation becomes Deprecation, that's easily done as well.

 Git branch (same as patch) at
 http://github.com/carljm/django/commits/ticket_12226

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12226: Test HttpResponse template attribute needlessly hard to use

[Django]

#12226: Test HttpResponse template attribute needlessly hard to use
+---
  Reporter:  carljm | Owner:  nobody
Status:  new| Milestone:
 Component:  Testing framework  |   Version:  1.1   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by ericholscher):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Sounds like this may be something we want to do similar to how context is
 accessed.

 
http://docs.djangoproject.com/en/dev/topics/testing/#django.test.client.Response.context

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.