Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
-+-
   Reporter:  xiaket |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  contrib.localflavor
  Milestone: | Severity:  Normal
Version: | Keywords:  CN localflavor
 Resolution: |Has patch:  1
   Triage Stage:  Ready for  |  Needs tests:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by DaNmarner):

 Thanks lrekucki, it must be my script for auto-cleaning ~ and pyc files.
 cn_localflavor_r15942.diff is the patch to apply.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
-+-
   Reporter:  xiaket |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  contrib.localflavor
  Milestone: | Severity:  Normal
Version: | Keywords:  CN localflavor
 Resolution: |Has patch:  1
   Triage Stage:  Ready for  |  Needs tests:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by lrekucki):

 * stage:  Accepted => Ready for checkin


Comment:

 Your last patch deletes ".../apps/test/static/test/backup~" (I presume it
 got there by accident), so I fixed that and some trailing whitespace.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
---+---
   Reporter:  xiaket   |Owner:  nobody
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:   | Severity:  Normal
 Resolution:   | Keywords:  CN localflavor
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  0|  Needs tests:  0
Patch needs improvement:  0|
---+---
Changes (by DaNmarner):

 * needs_better_patch:  1 => 0


Comment:

 The tests have been rewritten (with unittest) and run.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
---+---
   Reporter:  xiaket   |Owner:  nobody
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:   | Severity:  Normal
 Resolution:   | Keywords:  CN localflavor
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  0|  Needs tests:  0
Patch needs improvement:  1|
---+---
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 Great work, thank you. Before we check this in, could you rewrite the
 tests using unittest?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
---+---
   Reporter:  xiaket   |Owner:  nobody
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:   | Severity:  Normal
 Resolution:   | Keywords:  CN localflavor
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  0|  Needs tests:  0
Patch needs improvement:  0|
---+---
Changes (by mattmcc):

 * type:   => New feature
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
-+--
  Reporter:  xiaket  | Owner:  nobody   
 
Status:  new | Milestone:   
 
 Component:  django.contrib.localflavor  |   Version:   
 
Resolution:  |  Keywords:  CN 
localflavor
 Stage:  Accepted| Has_patch:  1
 
Needs_docs:  0   |   Needs_tests:  0
 
Needs_better_patch:  0   |  
-+--
Comment (by Daniel Duan ):

 I can verify that this looks like a sane patch. Couple of comments here:

 1.  The select value shouldn't has space in it.
 2.  IMO, the location code is too specific to be located in a standalone
 file(it is the ID Card checking algorithm detail, not in anyway reusable).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
-+--
  Reporter:  xiaket  | Owner:  nobody   
 
Status:  new | Milestone:  1.2  
 
 Component:  django.contrib.localflavor  |   Version:  SVN  
 
Resolution:  |  Keywords:  CN 
localflavor
 Stage:  Accepted| Has_patch:  1
 
Needs_docs:  0   |   Needs_tests:  0
 
Needs_better_patch:  0   |  
-+--
Comment (by jezdez):

 No, "cn" is correct because the localflavor contrib app organizes its
 content per country, not locale.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
-+--
  Reporter:  xiaket  | Owner:  nobody   
 
Status:  new | Milestone:  1.2  
 
 Component:  django.contrib.localflavor  |   Version:  SVN  
 
Resolution:  |  Keywords:  CN 
localflavor
 Stage:  Accepted| Has_patch:  1
 
Needs_docs:  0   |   Needs_tests:  0
 
Needs_better_patch:  0   |  
-+--
Changes (by jezdez):

  * stage:  Design decision needed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12379: Simplified Chinese(CN) localflavor package

[Django]

#12379: Simplified Chinese(CN) localflavor package
-+--
  Reporter:  xiaket  | Owner:  nobody   
 
Status:  new | Milestone:  1.2  
 
 Component:  django.contrib.localflavor  |   Version:  SVN  
 
Resolution:  |  Keywords:  CN 
localflavor
 Stage:  Design decision needed  | Has_patch:  1
 
Needs_docs:  0   |   Needs_tests:  0
 
Needs_better_patch:  0   |  
-+--
Changes (by jcd):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Design decision needed
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.