Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
-+-
 Reporter:  andybak  |Owner:  DrMeers
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin, blocks,   | Triage Stage:  Ready for
  template, object-tools,|  checkin
  sprintdec2010  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * type:  Uncategorized => Cleanup/optimization
 * resolution:   => fixed


Comment:

 Please open a new ticket rather than reopening a ticket that's already
 released. Your request seems to be a duplicate of #18914.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a51b1de374a8b3630b1485cf065a315e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
-+-
 Reporter:  andybak  |Owner:  DrMeers
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, blocks,   | Triage Stage:  Ready for
  template, object-tools,|  checkin
  sprintdec2010  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by sassanh):

 Sorry, I guess I set incorrect fields for this ticket. I'm not familiar
 with Django tickets system.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2ff315e229502f26c8ce593cd657bad1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
-+-
 Reporter:  andybak  |Owner:  DrMeers
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin, blocks,   | Triage Stage:  Ready for
  template, object-tools,|  checkin
  sprintdec2010  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by sassanh):

 * status:  closed => new
 * severity:   => Normal
 * resolution:  fixed =>
 * easy:   => 0
 * ui_ux:   => 0
 * type:   => Uncategorized


Comment:

 I think it's better to make it possible to add buttons to object-tool by
 python code (in inherited admin class) instead of overriding the html
 file, extending the default and adding the button. Something like
 `actions` field in admin class but for object-tool.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3418852368691ac64782a8bdb1fbbd31%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  DrMeers
 
Status:  closed| Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:  fixed |  Keywords:  admin, blocks, 
template, object-tools, sprintdec2010
 Stage:  Ready for checkin | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by russellm):

 One suggestion that just came up at the sprints: Change the UL to be a
 DIV. DIVs are allowed to have no child elements, so the empty case ceases
 to be a problem.

 Of course, this means a bunch of changes to templates that could have all
 sorts of follow-on consequences.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  DrMeers
 
Status:  closed| Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:  fixed |  Keywords:  admin, blocks, 
template, object-tools, sprintdec2010
 Stage:  Ready for checkin | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by DrMeers):

 Replying to [comment:7 adamv]:
 > On change_list, I'm not sure that this block should be within the "user
 has add permission" if block, since you may want to add tools/links that
 don't require the add permission.

 I agree, however we've been unable to come up with a solution to allow
 this that won't result in an (invalid) empty  if the user does not
 have add permission and no additional tools are added. Suggestions most
 welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  DrMeers
 
Status:  closed| Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:  fixed |  Keywords:  admin, blocks, 
template, object-tools, sprintdec2010
 Stage:  Ready for checkin | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by adamv):

 On change_list, I'm not sure that this block should be within the "user
 has add permission" if block, since you may want to add tools/links that
 don't require the add permission.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  DrMeers
 
Status:  assigned  | Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:|  Keywords:  admin, blocks, 
template, object-tools, sprintdec2010
 Stage:  Ready for checkin | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by julien):

  * stage:  Accepted => Ready for checkin

Comment:

 This has also frustrated me for years. DrMeers' approach seems much
 simpler and more flexible than the originally proposed patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  DrMeers
 
Status:  assigned  | Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:|  Keywords:  admin, blocks, 
template, object-tools, sprintdec2010
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by DrMeers):

  * keywords:  admin, blocks, template, object-tools, sprint_dec_2010 =>
   admin, blocks, template, object-tools,
   sprintdec2010

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  DrMeers
   
Status:  assigned  | Milestone:  1.3
   
 Component:  django.contrib.admin  |   Version:  SVN
   
Resolution:|  Keywords:  admin, blocks, 
template, object-tools, sprint_dec_2010
 Stage:  Accepted  | Has_patch:  1  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by DrMeers):

  * keywords:  admin, blocks, template, object-tools => admin, blocks,
   template, object-tools, sprint_dec_2010

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  DrMeers
  
Status:  assigned  | Milestone:  1.3
  
 Component:  django.contrib.admin  |   Version:  SVN
  
Resolution:|  Keywords:  admin, blocks, 
template, object-tools
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by DrMeers):

  * owner:  nobody => DrMeers
  * status:  new => assigned
  * has_patch:  0 => 1
  * version:  1.1 => SVN
  * milestone:  => 1.3

Comment:

 This has frustrated me for years also. I've regularly used jQuery to
 insert list items within the object tools list to stay DRY...

 Very simple patch attached. I'd prefer to see this single inner-block
 rather than "pre-" and "post-" blocks because:

 * It is simpler
 * You can achieve the same by using `{% block object-tools-items %}
 BEFORE {{ block.super }} AFTER {% endblock %}`
 * `pre-object-tools` sounds like it comes ''before'' the `object-
 tools` block, despite being inside it...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12694: Adding an object-tool requires template code duplication

[Django]

#12694: Adding an object-tool requires template code duplication
---+
  Reporter:  andybak   | Owner:  nobody 
  
Status:  new   | Milestone: 
  
 Component:  django.contrib.admin  |   Version:  1.1
  
Resolution:|  Keywords:  admin, blocks, 
template, object-tools
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by jezdez):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.