Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
-+-
 Reporter:  jabapyth |Owner:  jabapyth
 Type:  Bug  |   Status:  new
Component:  contrib.flatpages|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  flatpages,   | Triage Stage:  Accepted
  validation, 404|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_better_patch:  1 => 0


Comment:

 Fair concern. Updated patch that tests for slashes in clean_url instead of
 using the regex to check it. Now the message errors are indeed more
 precise.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
-+-
 Reporter:  jabapyth |Owner:  jabapyth
 Type:  Bug  |   Status:  new
Component:  contrib.flatpages|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  flatpages,   | Triage Stage:  Accepted
  validation, 404|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by kmtracey):

 * needs_better_patch:  0 => 1


Comment:

 It looks to me like you will now (with the latest patch) get a validation
 error if you are missing the trailing slash...but the error message will
 be:

 This value must contain only letters, numbers, dots, underscores, dashes,
 slashes or tildes.

 correct? That's a pretty confusing error message if what you have supplied
 does in fact contain only letters, etc. and the actual problem is that you
 are missing a trailing slash.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
-+-
 Reporter:  jabapyth |Owner:  jabapyth
 Type:  Bug  |   Status:  new
Component:  contrib.flatpages|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  flatpages,   | Triage Stage:  Accepted
  validation, 404|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_better_patch:  1 => 0
 * ui_ux:   => 0


Comment:

 The above attached patch is an updated version of a previous patch. It
 depends on #17125 to be committed (possibility to modify regex of a
 RegexField after init). I choose this way of updating the regex because
 the current trend in Django is to prevent global state. If in the future,
 settings might vary in the same code base, this patch might be better to
 address the issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
-+-
   Reporter:  jabapyth   |  Owner:  jabapyth
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.flatpages
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:  flatpages,
   Triage Stage:  Accepted   |  validation, 404
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  1  |Needs tests:  0
 |  Easy pickings:  0
-+-
Changes (by patchhammer):

 * needs_better_patch:  0 => 1
 * easy:   => 0


Comment:

 flatpages_admin_trunk.diff fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
---+
  Reporter:  jabapyth  | Owner:  jabapyth  
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  SVN   
Resolution:|  Keywords:  flatpages, validation, 404
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jabapyth):

  * needs_better_patch:  1 => 0
  * needs_tests:  1 => 0

Comment:

 I looked around and there didn't seem to be any docs/readme on *how* to
 add tests to django (other than the basic ''this is a unittest'') -- I
 mean conventions, organization and the like. so bear with me.
 I created a new directory in /tests/regressiontests (I figured that was
 the right place for it...like I said, there didn't seem to be any
 intuitive difference between regressiontests and modeltests), called
 "flatpage_tests", and I put in some URL validation tests. is there
 anything I should change?

 btw. thanks so much for your guidance and council; as you can probably
 tell I'm fairly new at this. much appreciated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
---+
  Reporter:  jabapyth  | Owner:  jabapyth  
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  SVN   
Resolution:|  Keywords:  flatpages, validation, 404
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_better_patch:  0 => 1
  * needs_tests:  0 => 1

Comment:

 Django's testing tools have all sorts of utils for checking form
 validation. Tests aren't optional here.

 Also - PEP8: Constants (url_regex) should be in CAPITALS.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
---+
  Reporter:  jabapyth  | Owner:  jabapyth  
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  SVN   
Resolution:|  Keywords:  flatpages, validation, 404
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jabapyth):

  * needs_better_patch:  1 => 0
  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
---+
  Reporter:  jabapyth  | Owner:  jabapyth  
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  SVN   
Resolution:|  Keywords:  flatpages, validation, 404
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Comment (by jabapyth):

 As far as testing goes, it seems to be a UI change, and therefore hard to
 unittest -- unless you would like me to write some cases for the
 regex[[BR]]
 to manually examine:

 enable APPEND_SLASH (well it is by default), and enable CommonMiddleware
 (default again)[[BR]]
 - on the admin page, create a new flatpage, but omit the trailing slash in
 the URL[[BR]]
 - (should fail to validate)

 disable APPEND_SLASH[[BR]]
 - create a flatpage, omit the slash[[BR]]
 - (should accept)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
---+
  Reporter:  jabapyth  | Owner:  jabapyth  
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  SVN   
Resolution:|  Keywords:  flatpages, validation, 404
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_better_patch:  0 => 1

Comment:

 Also - please generate patches against the root of the tree.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
---+
  Reporter:  jabapyth  | Owner:  jabapyth  
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  SVN   
Resolution:|  Keywords:  flatpages, validation, 404
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * component:  Forms => Contrib apps
  * stage:  Unreviewed => Accepted

Comment:

 Checking for the trailing slash isn't necessarily a given -- you only need
 the trailing slash if APPEND_SLASH is enabled.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12972: flatpages chokes if the url doesn't begin and end with a slash (but doesn't validate for it)

[Django]

#12972: flatpages chokes if the url doesn't begin and end with a slash (but 
doesn't
validate for it)
-+--
  Reporter:  jabapyth| Owner:  jabapyth  
Status:  new | Milestone:
 Component:  Forms   |   Version:  SVN   
Resolution:  |  Keywords:  flatpages, validation, 404
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  1 
Needs_better_patch:  0   |  
-+--
Changes (by gvangool):

  * needs_better_patch:  => 0
  * needs_tests:  => 1
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.