Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link 1.8-alpha|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"07988744b347302925bc6cc66511e34224db55ab"]:
 {{{
 #!CommitTicketReference repository=""
 revision="07988744b347302925bc6cc66511e34224db55ab"
 Fixed #13165 -- Added edit and delete links to admin foreign key widgets.

 Thanks to Collin Anderson for the review and suggestions and Tim for the
 final review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4e8ac55d13d5e694f9d300f5a55549fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link 1.8-alpha|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by timgraham):

 * keywords:  admin foreign key edit link => admin foreign key edit link
 1.8-alpha


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.eeac7a01ed0bf7f8e38c0031c10c1118%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by charettes):

 * needs_better_patch:  1 => 0


Comment:

 Added what was missing to ship with 1.8. Review would be greatly
 appreciated.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2b088d4d8b673f83b2b91f2d86fec74f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by charettes):

 Created a PR with the changes. It's only missing documentation and a way
 to deal with the two broken public APIs.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5ef3e8a27f42cf3aff5bbce7a2b4bedd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by collinanderson):

 * cc: cmawebsite@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cb0ec74cbe2b0c82c408304389fa36db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by charettes):

 I added the `from_field` [https://github.com/django/django/pull/2104/files
 #diff-3c42de3e53aba87b32c494f995a728dfR613 restriction].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9332e782a32d282f1b9239110e3de31c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by charettes):

 I opened a [https://github.com/django/django/pull/2104 Pull Request] with
 a working implementation of 1.

 I'd appreciated feedback on the possible `from_field` attack vector those
 changes introduce. One solution would be to restrict allowed `from_field`
 values based on current admin site registered models pointing to the
 actual model being looked up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b4c68e75327af7bc54548bff46252ac2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by charettes):

 I've been working on this lately and
 [https://github.com/charettes/django/compare/ticket-13165-edit-and-delete-
 links almost everything is working correctly].

 The last missing part concerns foreign keys with `to_field` since there's
 no way to retrieve the related object based on the selected `to_field`
 value.

 We've got two options here:

 1. Provides views redirecting to the related object change and delete
 views based on the provided `to_field` value;
 2. Attach a `data-pk` attribute on all options (in the case of `Select`
 widget) or to the raw id input to retrieve.

 The second option doesn't seems viable since it's requires a lot of
 special casing when dealing with different types of widgets.

 The first one should be doable by allowing `ModelAdmin.get_object` to
 receive a third parameter specifying which field to retrieve it's model
 from.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3c40beb1b4e98724d218d71c71146303%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by danielsamuels):

 * cc: danielsamuels (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.17ce2633841538ae7dbb0333c5ed9b76%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  charettes
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by charettes):

 * owner:  stefanw => charettes


Comment:

 @stefanw hope you don't mind I assign this ticket to myself but I'm
 working on adapting the django-admin-enhancer code to merge it into
 Django. You can follow the WIP
 [https://github.com/charettes/django/compare/ticket-13165-edit-and-delete-
 links here].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.06d91c6e05d2a78d852dd6185a9cc341%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  stefanw
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by BinaryKhaos):

 * cc: ua_django_bugzilla@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  stefanw
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by guettli):

 * cc: hv@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  stefanw
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by charettes):

 Comment comment:39 was me. I packaged a simple app providing admin mixins
 to add a the edition and deletion links described above. You can find the
 project on [https://github.com/charettes/django-admin-enhancer github] and
 on [http://pypi.python.org/pypi/django-admin-enhancer/0.1.0 pypi].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  stefanw
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by brillgen):

 * cc: dev@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  stefanw
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by anonymous):

 Here's a little something I implemented for a project. It adds the edit /
 delete link and enable / disable them when nothing is selected. Plus
 saving an object after deleting (via popup) updates the repr of the object
 in the select box.

 * [http://dl.dropbox.com/u/2759157/empty.png]
 * [http://dl.dropbox.com/u/2759157/selected.png]
 * [http://www.youtube.com/watch?v=H4xqku-BPBU] A short demo

 The code can be found on django snippet at
 [http://djangosnippets.org/snippets/2562/]. I think we should consider
 adding the delete link also.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  stefanw
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by stefanw):

 I posted to the django-ux list about this ticket:
 https://groups.google.com/forum/#!topic/django-ux/dzkQogwfx4I

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
 Reporter:  DrMeers  |Owner:  stefanw
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  admin foreign key| Triage Stage:  Accepted
  edit link  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by stefanw):

 * needs_better_patch:  0 => 1


Comment:

 jezdez commented in irc and disliked the OPs approach of retrieving the
 object and wanted the change link to change when a different fk object is
 selected.

 There is a pull request with some open questions:
 https://github.com/django/django/pull/57

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|  Owner:  stefanw
   Type:  New| Status:  assigned
  feature|  Component:  contrib.admin
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  1  |
-+-
Changes (by stefanw):

 * status:  new => assigned
 * cc: stefanw (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|  Owner:  stefanw
   Type:  New| Status:  new
  feature|  Component:  contrib.admin
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  1  |
-+-
Changes (by stefanw):

 * owner:  DrMeers => stefanw
 * needs_better_patch:  1 => 0
 * status:  reopened => new


Comment:

 I ported the latest patch to trunk including the following additional
 changes:

  - CSS names now contain - (dashes) instead of _ (underscores)
  - link generation in admin.util.get_changelink_html includes escaping

 The related-field-changelink CSS class needs some styling (like vertical-
 align: middle or something).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|  Owner:  DrMeers
   Type:  New| Status:  reopened
  feature|  Component:  contrib.admin
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  1  |
-+-

Comment (by julien):

 Replying to [comment:32 anonymous]:
 > Hi - I'm just about to start hacking something like this together... any
 idea when it might make it into trunk? If there is anything useful I can
 do...

 We're approaching the alpha/beta release stages so the earlier one starts
 to work on this and the closer one gets to a fully functional and fully
 tested code, the higher the chance it has to be included in core. Any
 contribution is appreciated ;-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|  Owner:  DrMeers
   Type:  New| Status:  reopened
  feature|  Component:  contrib.admin
  Milestone:  1.3|   Severity:  Normal
Version:  SVN|   Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  1  |
-+-
Changes (by anonymous):

 * easy:   => 0


Comment:

 Hi - I'm just about to start hacking something like this together... any
 idea when it might make it into trunk? If there is anything useful I can
 do...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|Owner:  DrMeers
   Type:  New|   Status:  reopened
  feature|Component:  User Experience
  Milestone:  1.3| Severity:  Normal
Version:  SVN| Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  1  |
-+-

Comment (by julien):

 See #11397 for another dupe.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|Owner:  DrMeers
   Type:  New|   Status:  reopened
  feature|Component:  User Experience
  Milestone:  1.3| Severity:  Normal
Version:  SVN| Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  1  |
-+-

Comment (by julien):

 Sorry, didn't mean to close this one!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|Owner:  DrMeers
   Type:  New|   Status:  reopened
  feature|Component:  User Experience
  Milestone:  1.3| Severity:  Normal
Version:  SVN| Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  1  |
-+-
Changes (by DrMeers):

 * type:  Uncategorized => New feature


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|Owner:  DrMeers
   Type: |   Status:  reopened
  Uncategorized  |Component:  User Experience
  Milestone:  1.3| Severity:  Normal
Version:  SVN| Keywords:  admin foreign key
 Resolution: |  edit link
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  1  |
-+-
Changes (by DrMeers):

 * status:  closed => reopened
 * resolution:  duplicate =>


Comment:

 Umm; if #6723 was closed as a duplicate of this, why was this one closed
 also?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
-+-
   Reporter:  DrMeers|Owner:  DrMeers
   Type: |   Status:  closed
  Uncategorized  |Component:  User Experience
  Milestone:  1.3| Severity:  Normal
Version:  SVN| Keywords:  admin foreign key
 Resolution:  duplicate  |  edit link
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  1  |
-+-
Changes (by julien):

 * status:  assigned => closed
 * type:   => Uncategorized
 * resolution:   => duplicate
 * severity:   => Normal


Comment:

 Just for the reference, #6723 was closed as dupe.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  assigned | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  1|  
--+-
Changes (by anonymous):

  * needs_better_patch:  0 => 1

Comment:

 it dont work after update

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  assigned | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by JackLeo):

 Replying to [comment:22 JackLeo]:
 > Applying patch does not show any changes at all... what may be the case?

 My bad, patcher couldn't properly read .diff file.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  assigned | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by JackLeo):

 Applying patch does not show any changes at all... what may be the case?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  assigned | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Changes (by DrMeers):

  * status:  new => assigned

Comment:

 Replying to [comment:20 g...@lka.hu]:
 > So this way it could be translated correctly.

 I believe you are correct, thank you. Patch updated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by g...@lka.hu):

 I think the line 370 should have some more fix:

 Instead of this:

 {{{
 text = _('edit %s' % force_unicode(obj))
 }}}

 This:

 {{{
 text = _('edit %s') % force_unicode(obj)
 }}}

 So this way it could be translated correctly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by gklka):

 OK, that works fine. Thanks for your efforts!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by DrMeers):

 Replying to [comment:17 gklka]:
 > That's it:

 Try replacing

 {{{
   text = _('edit %s' % obj)
 }}}

 with

 {{{
   text = _(u'edit %s' % force_unicode(obj))
 }}}

 and let me know how if this solves it; I'll then update the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by gklka):

 That's it:


 {{{
 >>> get_changelink_html(obj, site, show_name = True)
 Traceback (most recent call last):
   File "", line 1, in 
   File "/Library/Python/2.6/site-packages/django/contrib/admin/util.py",
 line 370, in get_changelink_html
 text = _('edit %s' % obj)
   File "/Library/Python/2.6/site-
 packages/django/utils/translation/__init__.py", line 55, in ugettext
 return real_ugettext(message)
   File "/Library/Python/2.6/site-packages/django/utils/functional.py",
 line 55, in _curried
 return _curried_func(*(args+moreargs), **dict(kwargs, **morekwargs))
   File "/Library/Python/2.6/site-
 packages/django/utils/translation/__init__.py", line 36, in delayed_loader
 return getattr(trans, real_name)(*args, **kwargs)
   File "/Library/Python/2.6/site-
 packages/django/utils/translation/trans_real.py", line 276, in ugettext
 return do_translate(message, 'ugettext')
   File "/Library/Python/2.6/site-
 packages/django/utils/translation/trans_real.py", line 262, in
 do_translate
 result = getattr(t, translation_function)(eol_message)
   File
 
"/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/gettext.py",
 line 404, in ugettext
 return unicode(message)
 UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 26:
 ordinal not in range(128)

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by DrMeers):

 Replying to [comment:15 gklka]:
 > It didn't help. I have tried to replace text with some constant string
 like 'text', but it does not work that way either. I think the bug is
 elsewhere.

 Very strange; that seems to be the only thing that should be affected by
 the unicode representation of the object. Can you try something like this
 in a shell?

 {{{
 >>> from AppName import admin # ensure models get
 registered
 >>> from AppName.models import *  # get models
 >>> from django.contrib.admin import site # get admin site
 >>> from django.contrib.admin.util import *   # get get_changelink_
 methods
 >>> obj = ModelName.objects.get(pk=ChooseAnID)
 >>> get_changelink_url(obj, site)
 '/admin/AppName/ModelName/ChooseAnID/'
 >>> get_changelink_html(obj, site)
 u' edit'
 >>> get_changelink_html(obj, site, show_name=True)
 u' edit \xe1rv\xedzt\u0171r\u0151
 T\xdcK\xd6RF\xdaR\xd3G\xc9P'
 }}}

 Hopefully something will blow up noisily so we can find where the problem
 is...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by gklka):

 It didn't help. I have tried to replace text with some constant string
 like 'text', but it does not work that way either. I think the bug is
 elsewhere.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by DrMeers):

 Replying to [comment:13 gklka]:
 > Please see this video: http://www.youtube.com/watch?v=BIMRoBbH8ws

 Thank you for taking the time to make this.

 Could you please try changing line 374 of
 {{{django/contrib/admin/util.py}}} from
 {{{
 '%(text)s' % {'url': url, 'text': text})
 }}}

 to

 {{{
 '%(text)s' % {'url': url, 'text': force_unicode(text)})
 }}}

 and let me know if this solves the problem?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by gklka):

 Please see this video: http://www.youtube.com/watch?v=BIMRoBbH8ws

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by gklka):

 Replying to [comment:11 DrMeers]:
 > Still can't reproduce; see
 here[http://share.simonmeers.com/accented_string_foreign_key.png] -- are
 you using trunk/1.2 with this patch applied?

 I have Django 1.2.1 (stable) with Python 2.6 on Mac OS X.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by DrMeers):

 Replying to [comment:10 g...@lka.hu]:
 > Let's say that the model, which is referred through foreign key, has
 this method:
 >
 > def __unicode__(self):
 >return u"árvíztűrő tükörfúrógép"
 >
 > If you edit some object of the model, which has the FK field on the
 admin interface, the source code will not include the select widget. When
 you press Save, you get an error message that the value is missing (if
 required). The add page seems like working, because there the field has no
 value, so the edit button (with the result of __unicode__() of the linked
 object) is not present.

 Still can't reproduce; see
 here[http://share.simonmeers.com/accented_string_foreign_key.png] -- are
 you using trunk/1.2 with this patch applied?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by g...@lka.hu):

 Replying to [comment:9 DrMeers]:
 > Replying to [comment:8 anonymous]:
 > > It has some issues with the hungarian accented strings: If there is
 accent in the object's name, it does not render either the select widget,
 nor the add/edit buttons.
 >
 > I cannot reproduce this problem; please provide an example problematic
 accented string.

 Let's say that the model, which is referred through foreign key, has this
 method:

 def __unicode__(self):
return u"árvíztűrő tükörfúrógép"

 If you edit some object of the model, which has the FK field on the admin
 interface, the source code will not include the select widget. When you
 press Save, you get an error message that the value is missing (if
 required). The add page seems like working, because there the field has no
 value, so the edit button (with the result of __unicode__() of the linked
 object) is not present.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by DrMeers):

 Replying to [comment:8 anonymous]:
 > It has some issues with the hungarian accented strings: If there is
 accent in the object's name, it does not render either the select widget,
 nor the add/edit buttons.

 I cannot reproduce this problem; please provide an example problematic
 accented string.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by anonymous):

 It has some issues with the hungarian accented strings: If there is accent
 in the object's name, it does not render either the select widget, nor the
 add/edit buttons.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  SVN 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Changes (by DrMeers):

  * version:  1.1 => SVN

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  1.1 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Changes (by DrMeers):

  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  1.1 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  1   
   
Needs_better_patch:  0|  
--+-
Comment (by DrMeers):

 A further design decision: do we need to check whether the user has
 permission to edit the related model in question? Currently users will
 simply see a 'permission denied' message if they click the link and don't
 have permission. Which is probably OK. Hiding the link for users without
 permissions requires significant restructuring with the use of custom
 template tags or similar.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  1.1 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  1   
   
Needs_docs:  0|   Needs_tests:  1   
   
Needs_better_patch:  0|  
--+-
Changes (by DrMeers):

  * has_patch:  0 => 1
  * needs_tests:  0 => 1

Comment:

 I have a patch which is working nicely. Confirmation of a few design
 decisions is required:

  1. Does the link popup a new window? [I think not, users can control-
 click for this behaviour]
  2. Does the link work for the ''selected'' object, or just the previously
 saved one? [I think the latter; otherwise clicking on it will cause
 changes in the form to be lost. It just needs to be clear that the link is
 to the saved selection (I've included the name of the object in the link
 text beside an edit icon).]
  3. Do we provide edit links for multiple-select widgets? [I've left these
 blank for now; if you've got 30 objects selected, links will be a bit
 unwieldy]
  4. Should it work for {{{readonly_fields}}}? [I think it should, so have
 included this functionality]

 Based on my decision for point 2 above, the current patch requires no
 JavaScript. This also saves us having to do anything ugly with fudging
 reverse url resolution in JavaScript.

 I'll get onto the tests shortly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  1.1 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  0   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by DrMeers):

 Replying to [comment:2 agabel]:
 > Is there any update to this ticket? If not, I'd like to take a stab at
 it if no one objects.

 The code is almost ready, it just hasn't been high on my priority list
 since I know it won't be committed until after 1.2 lands.
 Now that others are expressing interest in the feature I'll try to knock
 it off ASAP.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  1.1 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  0   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Comment (by agabel):

 Is there any update to this ticket? If not, I'd like to take a stab at it
 if no one objects.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13165: Display edit link beside add button for ForeignKey fields in admin

[Django]

#13165: Display edit link beside add button for ForeignKey fields in admin
--+-
  Reporter:  DrMeers  | Owner:  DrMeers 
   
Status:  new  | Milestone:  1.3 
   
 Component:  User Experience  |   Version:  1.1 
   
Resolution:   |  Keywords:  admin foreign key edit 
link
 Stage:  Accepted | Has_patch:  0   
   
Needs_docs:  0|   Needs_tests:  0   
   
Needs_better_patch:  0|  
--+-
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.