Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
-+-
 Reporter:  carljm   |Owner:  ambv
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  1.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Łukasz Langa ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"64e11a68f19793d11915e83574b1bb693da3980e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="64e11a68f19793d11915e83574b1bb693da3980e"
 Fixed #13285: populate_xheaders breaks caching
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
-+-
 Reporter:  carljm   |Owner:  ambv
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  1.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Aymeric Augustin ):

 In [changeset:"e73cb6391dd4f178e430c424eda6d9c97a70c7f6"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e73cb6391dd4f178e430c424eda6d9c97a70c7f6"
 Merge pull request #1122 from ambv/issue13285

 Fixed #13285: populate_xheaders breaks caching
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
-+-
 Reporter:  carljm   |Owner:  ambv
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/1122

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
-+-
 Reporter:  carljm   |Owner:  ambv
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  0|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * stage:  Accepted => Ready for checkin


Comment:

 Łukasz will salvage the test and re-add them in another PR moving
 XViewMiddleware to d.c.admindocs, as it's only used by admindocs and not
 obviously useful otherwise.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
-+
 Reporter:  carljm   |Owner:  ambv
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by aaugustin):

 Two years later, it's probably time to remove it outright (and, since
 we're nice people, document it as a backwards incompatible change).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
-+
 Reporter:  carljm   |Owner:  ambv
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by ambv):

 * owner:  anonymous => ambv


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
-+-
 Reporter:  carljm   |Owner:  anonymous
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by anonymous):

 * owner:  nobody => anonymous
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
+---
   Reporter:  carljm| Owner:  nobody
 Status:  reopened  | Milestone:
  Component:  Cache system  |   Version:  1.1   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  0 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---

Comment (by carljm):

 The function-based generic views are now deprecated, and the class-based
 views that replaced them do not call populate_xheaders. So the only
 remaining non-deprecated view in the Django source tree that calls
 populate_xheaders is the flatpage view.

 My take at this point is that the populate_xheaders function itself is a)
 of marginal usefulness, since these sorts of debugging headers can easily
 be added without a generic function for it, b) now barely used within
 Django, c) breaks caching as written, and d) completely undocumented. So,
 barring major objections, I think it should just be removed from Django
 entirely. Since it's undocumented I don't think a deprecation path is
 strictly needed, but to err on the side of caution it could be deprecated
 along the same timeline as the function-based generic views, since they
 all call it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
---+
  Reporter:  carljm| Owner:  nobody
Status:  reopened  | Milestone:
 Component:  Cache system  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * status:  closed => reopened
  * resolution:  duplicate =>
  * stage:  Unreviewed => Accepted

Comment:

 Apologies - I got myself confused here. Original reporter was correct -
 the issue here is that populate_xheaders is a debugging tool that breaks
 caching.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13285: Generic views call populate_xheaders, which breaks caching

[Django]

#13285: Generic views call populate_xheaders, which breaks caching
---+
  Reporter:  carljm| Owner:  nobody
Status:  closed| Milestone:
 Component:  Cache system  |   Version:  1.1   
Resolution:  duplicate |  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * status:  new => closed
  * needs_better_patch:  => 0
  * resolution:  => duplicate
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I'm going to close this as a dupe of #13283; I know the presentation is
 different, but the root cause is the same - we need to be able to
 determine the login/access status of the current user without marking the
 session as dirty.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.