Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
-+-
 Reporter:  canassa  |Owner:  csinchok
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ac1975b18b5a33234284bec86e5a5bb44a4af976" ac1975b1]:
 {{{
 #!CommitTicketReference repository=""
 revision="ac1975b18b5a33234284bec86e5a5bb44a4af976"
 Fixed #13809 -- Made FieldFile.open() respect its mode argument.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.aeac95cd34d32003df8936702bcb0ef9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
-+-
 Reporter:  canassa  |Owner:  csinchok
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 [https://github.com/django/django/pull/6938 PR]. I marked #26398 as a
 duplicate and will include the test from the PR for that ticket here.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ef44a2b3809da48ad846ebb1d6728b5a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:  csinchok
 Type:  Bug   |   Status:  assigned
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by csinchok):

 * owner:   => csinchok
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.32f55b7022d8667ec6edd42ec3bb8bd8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * status:  closed => new
 * resolution:  duplicate =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c983bde6bc510d4443936fdbe43eccba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
-+-
 Reporter:  canassa  |Owner:
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 I think #26398 may have at least partially addressed this but I haven't
 verified completely.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d43571bf9f27d03337a2807f20dfe14d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by synotna):

 Still present in 1.7 :(

 My workaround is always close the file before opening it again

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4ff290ba82fa1789da431bc925617226%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.651e9f20a7b56af6cd8612c58dd01f77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by jetfix):

 I confirm this that this issue is still present in 1.5 =(

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.515ad8a49d6352362e64f5219b7084ab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by anonymous):

 I confirm this issue as still present in Django 1.5.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.005534b4070385c47125801c00f18b91%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 #16964 was a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * owner:  nobody =>
 * status:  reopened => new
 * has_patch:  0 => 1
 * needs_tests:  1 => 0


Comment:

 The patch is still not optimal, because the file is opened in 'rb' mode
 upon access, then closed and reopened in the specified mode. Seems to
 work, though.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
--+
 Reporter:  canassa   |Owner:  nobody
 Type:  Bug   |   Status:  reopened
Component:  File uploads/storage  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by davidfstr):

 * cc: davidfstr (added)


Comment:

 I confirm this issue as still present in Django 1.3.

 In short, if you call {{{FieldFile.open(mode=NOT_RB)}}}, it will always
 open in mode {{{rb}}}. This is due to {{{FieldFile.open}}} calling the
 {{{self.file}}} property, which auto-opens in 'rb' mode.
 {{{FieldFile.open}}} attempts to subsequently call {{{open}}} on this new
 file, but that does not reopen the file again.

 My suggested workaround for:
 * {{{field_file.open(mode='w+b')}}}
 is:
 * {{{field_file.file = field_file.storage.open(field_file.name, 'w+b')}}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
+--
   Reporter:  canassa   |  Owner:  nobody
   Type:  Bug   | Status:  reopened
  Milestone:|  Component:  File uploads/storage
Version:  SVN   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+--
Changes (by mrmachine):

 * cc: real.human@… (added)
 * version:  1.2 => SVN
 * ui_ux:   => 0
 * needs_tests:  0 => 1
 * easy:   => 0


Comment:

 The docs say that `File.open()` will "re-open" the file (and as a side
 effect, do `File.seek(0)`. In reality, `File.open()` will only do
 `File.seek(0)` if the file is already open, and will ignore the newly
 specified mode.

 A separate but related issue is that even if the file is explicitly
 closed, and `File.open()` is called with a new mode, `File.mode` will
 still return the original mode. I'm not sure if the intent of the docs was
 that re-opening a file would use the original mode if not specified, or
 the current mode. Either way, I think that `File.mode` should mirror the
 current file mode.

 The problem with `FieldFile.open()` (a subclass of `File`) is that it
 calls `FieldFile.file.open()`, when `FieldFile.file` will open the file
 implicitly with a mode of "rb", and then `.open()` will just do
 `.seek(0)`, regardless of the mode that was passed in.

 I'm fine with the idea that `FieldFile` should be open in "rb" mode when
 accessed by default, but users shouldn't have to explicitly access it
 first so that they can insert an explicit call to `.close()` before
 calling `.open()` with a different mode.

 I think the fix here involves a couple of steps.

 1. `File.open()` should call `.close()` if the file is already open
 (instead of `.seek(0)`), and then actually re-open it with the new mode
 (or the mode that was originally used, if not specified), as per the docs.

 2. `FieldFile.open()` should not implicitly open the file in "rb" mode
 when a mode is explicitly set. `FieldFile.open()`.

 Cheers.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
+---
   Reporter:  canassa   | Owner:  nobody
 Status:  reopened  | Milestone:
  Component:  File uploads/storage  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  0 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by yishai@…):

  * component:  Documentation => File uploads/storage


Comment:

 Replying to [comment:3 russellm]:
 > I don't think it's unreasonable to expect that when you access a file
 through a model field, it will be open ready for reading. The best
 solution I can see here is documenting the fact that files are opened "rb"
 when accessed, and if you want to perform write operations, you'll need to
 close the file first.

 I think this is a little more subtle than that; since the underlying file
 object is "automatically" opened (with 'rb' mode) upon direct access, the
 main reason one would call {{{FieldFile.open}}} is to open the file in
 another mode. Having {{{FieldFile.open(mode='w')}}} return a bad file
 descriptor (for writing) without complaining is hardly optimal.

 >
 > I'm open to any other suggestions, but I'll accept this as a
 documentation issue for now.

 Even if deciding that one should always close first before opening the
 file for writing, calling {{{FieldFile.close()}}} is not enough as it will
 skip the underlying file object if it was not opened yet. This code will
 not work:

 {{{
   obj = MyModel.objects.get(pk=1)
   obj.myFileField.close() # would expect this to close the underlying file
 object, so it's ready to be reopened for writing
   obj.myFileField.open('w')
   obj.myFileField.write('something')
 }}}

 If we rewrite {{{FieldFile.close()}}} from:

 {{{
 def close(self):
 file = getattr(self, '_file', None)
 if file is not None:
 file.close()
 }}}

 to:
 {{{
 def close(self):
 self.file.close()
 }}}

 then the above snippet will work as advertised - the underlying file will
 be opened (rb) and then closed again. Currently the snippet needs to be:

 {{{
   obj = MyModel.objects.get(pk=1)
   obj.myFileField.file.close() # works, but hardly nice
   obj.myFileField.open('w')
   obj.myFileField.write('something')
 }}}

 which works, but accessing the underlying (undocumented?) file object
 directly is probably not what we really want here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
+---
  Reporter:  canassa| Owner:  nobody
Status:  reopened   | Milestone:
 Component:  Documentation  |   Version:  1.2   
Resolution: |  Keywords:
 Stage:  Accepted   | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * component:  File uploads/storage => Documentation
  * stage:  Unreviewed => Accepted

Comment:

 I don't think it's unreasonable to expect that when you access a file
 through a model field, it will be open ready for reading. The best
 solution I can see here is documenting the fact that files are opened "rb"
 when accessed, and if you want to perform write operations, you'll need to
 close the file first.

 I'm open to any other suggestions, but I'll accept this as a documentation
 issue for now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
---+
  Reporter:  canassa   | Owner:  nobody
Status:  reopened  | Milestone:
 Component:  File uploads/storage  |   Version:  1.2   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jesh):

  * status:  closed => reopened
  * resolution:  invalid =>

Comment:

 This still does not work for me. Documented open() does not honor mode
 (it's not *reopening* r/o file). That has a annoying side effect, so that
 FieldFile.file.open("w") does not work. This is because _get_file has
 already opened it as read only. As a workaround, every open could be
 preceded by lonely close(), but IMHO that's just plain ugly. My app code
 looks like

 {{{
 class MyModel(models.Model:
 file = models.FileField(...)

 this does not work:
 f=mymodel.file.open("rw")
 mymodel.file.write(content) # -> invalid fd
 mymodel.file.close()

 this will work:
 f=mymodel.file # file gets opened here, see [1]
 f.file.close() # following open [2] uses "rb" without this -> invalid fd
 when writing
 f.file.open("wb")
 mymodel.file.write(content)
 mymodel.file.close()
 }}}

  1.
 
http://code.djangoproject.com/browser/django/trunk/django/db/models/fields/files.py#L49
  2.
 
http://code.djangoproject.com/browser/django/trunk/django/core/files/base.py#L110

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13809: FileField open method is only accepting 'rb' modes

[Django]

#13809: FileField open method is only accepting 'rb' modes
---+
  Reporter:  canassa   | Owner:  nobody
Status:  closed| Milestone:
 Component:  File uploads/storage  |   Version:  1.2   
Resolution:  invalid   |  Keywords:
 Stage:  Unreviewed| Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by dmoisset):

  * status:  new => closed
  * needs_better_patch:  => 0
  * resolution:  => invalid
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 The {{{file}}} field is not documented (so it isn't doing anything wrong),
 and the documented method ({{{open()}}}) work as expected, so I think this
 is not a bug

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.