Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  dmpayton
 Type:  New feature|   Status:  closed
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:  wontfix
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Closing as wontfix given the lack of activity/interest and because it
 isn't compatible with CSP.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1f801feaf316045437b0c61eb3fe2038%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  dmpayton
 Type:  New feature|   Status:  assigned
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by aaugustin):

 Related: #21987.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0ae0064091351badcb4adaef432a95b2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  dmpayton
 Type:  New feature|   Status:  assigned
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by dmpayton):

 Thanks Julien, I've posted this to the mailing list.

 https://groups.google.com/forum/?fromgroups=#!topic/django-
 developers/G5_W3_MdmIg

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  dmpayton
 Type:  New feature|   Status:  assigned
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by julien):

 This ticket was brought on in IRC. A good point was made by @apollo13 that
 a new W3C policy is being worked on to discourage developers from using
 inline JS, in particular to prevent the risk of XSS: the Content Security
 Policy http://www.w3.org/TR/CSP/

 While I do recognize the convenience of inline JS/CSS, this is an
 important question that needs more discussing, especially around whether
 Django core should allow this feature which seems to now go against
 recommended practices. At this point I'd recommend bringing this to the
 django-devs mailing list to gather more feedback.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  dmpayton
 Type:  New feature|   Status:  assigned
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by julien):

 Thanks for your work, Derek. The patch looks pretty good! I like the term
 "embedded" a lot more. Since it's a pretty important API addition I'll
 just seek more opinions on IRC, and then I'm hoping we can move forward
 with this soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  dmpayton
 Type:  New feature|   Status:  assigned
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by dmpayton):

 * owner:  nobody => dmpayton
 * needs_docs:  1 => 0
 * status:  new => assigned
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by dmpayton):

 How do "EmbeddedCSS" and "EmbeddedJS" sound? Updated patch:

 
https://github.com/dmpayton/django/commit/978f20c2c74a767f881b318e6227a123f7cd72b2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by julien):

 Thanks for the updated patch, Derek. We're past the beta so unfortunately
 this can't go in 1.5, but I'm definitely keen to push this forward ASAP to
 make sure it gets considered for 1.6. I'll try to review the patch in more
 detail soon.

 Just one quick note in passing: I don't really like the term "Internal" as
 it's a little vague. I'll do more thinking about it and this can easily be
 modified in the final commit. In the meantime, any other suggestions are
 welcome.

 Thanks again!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by dmpayton):

 Hi Julien,

 Thanks for the feedback! I've added a new patch that switches naming from
 "inline" to "internal" and adds separate top-level classes for CSS and JS.

 
[https://github.com/dmpayton/django/compare/dmpayton:master...dmpayton:feature/13978
 -internal-media]

 And, of course, the tests still pass:

 {{{
 [19:17:54] derek @ pangolin in ~/dev/django/tests (git:feature/13978
 -internal-media)
 ± python runtests.py --settings=test_sqlite forms.FormsMediaTestCase
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 ...
 --
 Ran 15 tests in 0.011s

 OK
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

 Please let me know if there's anything else I can do.

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 Thank you for the patch, it looks great! I just have a couple of comments.

 Instead of having a single internal class `Media.Inline`, it'd be better
 to have two standalone (and global at the forms.widgets level) classes,
 one for JS and one for CSS. This way we could potentially later add extra
 features specific to either JS or CSS (e.g. to control the "media"
 attribute for the CSS code).

 Also, I'm wondering if we could find a better name than "inline". My
 concerns are that it could be confused for the admin inlines, and that it
 could be confused for another type of inline code, e.g. ``. Maybe something like `BlockJS`, `BlockCSS`. Any
 suggestion for better names are welcome.

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by dmpayton):

 I've updated with a patch that contains a first pass at docs and tests.

 {{{
 [15:44:41] derek @ pangolin in ~/dev/django/tests (git:feature/13978
 -inline-media)
 ± python runtests.py --settings=test_sqlite forms.FormsMediaTestCase
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 ...
 --
 Ran 15 tests in 0.011s

 OK
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+
 Reporter:  nathforge  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  sprintdec2010  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by dmpayton):

 I've updated this patch for the latest Django. Assuming I were to write
 docs and a test, could this feasibly make it into 1.5?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+-
   Reporter:  nathforge|Owner:  nobody
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  Forms
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  sprintdec2010
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  1|  Needs tests:  1
Patch needs improvement:  0|
---+-

Comment (by julien):

 I went on and closed #11865. I believe it's best to tackle both css and js
 at once to maintain some consistency.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
---+-
   Reporter:  nathforge|Owner:  nobody
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  Forms
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  sprintdec2010
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  1|  Needs tests:  1
Patch needs improvement:  0|
---+-
Changes (by graham_king):

 * type:   => New feature
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
-+--
   Reporter:  nathforge  | Owner:  nobody   
 Status:  new| Milestone:   
  Component:  Forms  |   Version:  SVN  
 Resolution: |  Keywords:  sprintdec2010
   Triage Stage:  Accepted   | Has patch:  1
Needs documentation:  1  |   Needs tests:  1
Patch needs improvement:  0  |  
-+--

Comment (by mk):

 This is sort-of a duplicate of #11865. Not closing as a duplicate because
 this ticket covers inline CSS and JS, while #11865 only covers inline JS.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
+---
  Reporter:  nathforge  | Owner:  nobody   
Status:  new| Milestone:   
 Component:  Forms  |   Version:  SVN  
Resolution: |  Keywords:  sprintdec2010
 Stage:  Accepted   | Has_patch:  1
Needs_docs:  1  |   Needs_tests:  1
Needs_better_patch:  0  |  
+---
Changes (by julien):

  * milestone:  1.3 =>

Comment:

 Too late for 1.3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
+---
  Reporter:  nathforge  | Owner:  nobody   
Status:  new| Milestone:  1.3  
 Component:  Forms  |   Version:  SVN  
Resolution: |  Keywords:  sprintdec2010
 Stage:  Accepted   | Has_patch:  1
Needs_docs:  1  |   Needs_tests:  1
Needs_better_patch:  0  |  
+---
Changes (by julien):

  * keywords:  => sprintdec2010
  * stage:  Design decision needed => Accepted
  * milestone:  => 1.3

Comment:

 This sounds like a really useful feature. You'd need to add some tests and
 documentation if you want it to have a chance of shipping with 1.3?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
-+--
  Reporter:  nathforge   | Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  0   |  
-+--
Changes (by mariarchi):

  * needs_docs:  0 => 1
  * needs_tests:  0 => 1
  * stage:  Unreviewed => Design decision needed

Comment:

 Needs tests and docs [and maybe design decision]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
-+--
  Reporter:  nathforge   | Owner:  nobody
Status:  new | Milestone:
 Component:  Forms   |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Unreviewed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by rafen):

  * owner:  rafen => nobody

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13978: Allow inline js/css in forms.Media

[Django]

#13978: Allow inline js/css in forms.Media
-+--
  Reporter:  nathforge   | Owner:  rafen
Status:  new | Milestone:   
 Component:  Forms   |   Version:  SVN  
Resolution:  |  Keywords:   
 Stage:  Unreviewed  | Has_patch:  1
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by rafen):

  * owner:  nobody => rafen
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.