Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"7534e43497fed7714910ccec2a6e8acade8263ca" 7534e434]:
 {{{
 #!CommitTicketReference repository=""
 revision="7534e43497fed7714910ccec2a6e8acade8263ca"
 Refs #14204 -- Removed obsolete referential integrity comment for SQLite.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e37a0eb303bb0ef0b8b7ccce6e128e11%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"ce8b65ac5e8e20912c36ab5c714ddf11de3b664c" ce8b65a]:
 {{{
 #!CommitTicketReference repository=""
 revision="ce8b65ac5e8e20912c36ab5c714ddf11de3b664c"
 Fixed #30054 -- Implemented cascaded flush on SQLite.

 This is required to maintain foreign key integrity when using
 TransactionTestCase.available_apps.

 Refs #30033, #14204, #20483.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.612ac90d4d503bc8bc3441e9751b69b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"1939dd49d142b65fa22eb5f85cee0d20864d3730" 1939dd4]:
 {{{
 #!CommitTicketReference repository=""
 revision="1939dd49d142b65fa22eb5f85cee0d20864d3730"
 Fixed #29928 -- Enabled deferred constraint checks on SQLite 3.20+.

 Refs #11665, #14204.

 Thanks Michel Samia for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.369f04f3482cd35052f2e693eefb0953%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"169c3b3e07829d9ffa409b6eb5c1094d8ef918a8" 169c3b3]:
 {{{
 #!CommitTicketReference repository=""
 revision="169c3b3e07829d9ffa409b6eb5c1094d8ef918a8"
 Fixed #14204 -- Enforced SQLite foreign key constraints.

 Thanks Tim Graham for contributing to the patch and
 Simon Charette for advice and review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8d95c86b02339b29c3e24029f8f357df%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


Comment:

 The PR linked in the previous comment is now ready for review.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.32d2b030caceff081ebd631cdf7a718e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I've worked on updating Claude's patch by incorporating Simon's suggestion
 of adding `DEFERRABLE INITIALLY DEFERRED`:
 [https://github.com/django/django/pull/8678 PR]

 There are still some issues to figure out.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.18b8ab5cb3dec741e8ee9569662911c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 I don't have the time to investigate right now, but if it can help
 someone, I rebased the commit which is now
 
https://github.com/claudep/django/commit/15ceb2cc05262fe5f24f16cc31367fe6b5b698c1

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dee570dff60526d8dc9e4cd1da9275b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  Ramiro Morales   |Owner:  Claude
 |  Paroz
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * cc: Simon Charette (added)


Comment:

 Is there a reason SQLite foreign key constraints are not created
 `DEFERRABLE INITIALLY DEFERRED` like they are on PostgreSQL and Oracle?

 If they were the issue mentioned by Claude regarding transaction wrapping
 could be solved.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.792bfaf15116f39987da95f76c10b89f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  claudep
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 There is one major issue with supporting FK constraints on SQLite3: they
 can only be deactivated outside a transaction (this is a documented
 behavior).
 Take for example the Django TestCase implementation which wraps every test
 class inside a transaction, that means that foreign keys checking can
 never be deactivated inside TestCase tests (loading forward references in
 fixtures is problematic for example, as does
 
`fixtures_regress.tests.TestFixtures.test_loaddata_works_when_fixture_has_forward_refs`).

 WIP work in this commit:
 
https://github.com/claudep/django/commit/e7a9252aa6f990c4687656e9ea0f1d1ca70dc043

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b92a5e1c67c2b62a34add6a6ba7893f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  claudep
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * owner:  coldmind => claudep


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.91e934d7c12e4e2f066a48637b1b50fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 The pragma is per-connection. It's a runtime property of the SQLite
 engine. It doesn't affect the on-disk file format.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.acb551392acf72bb81a3dc96a768a116%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 If you'd like to see it merged, feel free to update it to apply cleanly
 and add documentation (release notes). Then send a pull request and update
 the ticket flags so the patch appears in the review queue.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.30c74e35aafebbd7107693b9179d5db3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, foreign key  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by wkschwartz):

 +1 on getting this patch merged in. For what it's worth, the patch's
 implementation of `_check_fk_constraint_support` looks correct to me based
 on my reading of the [http://www.sqlite.org/foreignkeys.html#fk_enable
 SQLite documentation]. My only question about the patch is whether the
 `PRAGMA` needs to be issued on every new connection as the patch does, or
 only once when the database is created.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7c90ae65ff0595aa7bad70c4b329c9df%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  sqlite, foreign key  |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aaugustin):

 Since it's called an O''R''M, I'm theoretically in favour of focusing on
 ''relational'' software. Realistically, the main problem is MyISAM. It was
 MySQL's default until 5.5. As long as we can't drop the code that works
 around databases not enforcing constraints, there's less to gain by
 requiring FKs on SQLite.

 I'm +1 on enabling FK checks by default in Django and +0 on requiring it
 unconditionnally.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bd8d7332a18e0e9625f60ff9b304f89f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  sqlite, foreign key  |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by akaariai):

 How about we add a database OPTION key for SQLite to allow disabling
 foreign keys (mainly usable for backwards compatibility). If "disable
 foreign keys" flag isn't set, then starting in Django 1.8 automatically
 enable foreign key support.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.94eddf2a6a476892e60305fa4bf26b83%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14204: Take advantage of SQLite support for FK constraints (was: Take advantage of (newish) SQLite support for FK constraints)

[Django]

#14204: Take advantage of SQLite support for FK constraints
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  sqlite, foreign key  |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 5 years later (by the time Django 1.8 will be released), I think we could
 probably add this unconditionally and say that SQLite versions that don't
 support FKs aren't supported. Of course, we will still have to consider
 existing databases for which support isn't enabled.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e3a95f10ef6022ab0f55e89c14724caa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.