Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
-+-
 Reporter:  Simon Meers  |Owner:
 |  abdulrahman
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  template, block, | Triage Stage:
  inheritance|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0
 * has_patch:  1 => 0
 * resolution:   => wontfix
 * stage:  Accepted => Unreviewed


Comment:

 Do to the lack of any replies [https://forum.djangoproject.com/t/adding-
 blocks-to-the-stacked-tabular-inline-templates/21969 on the forum], only a
 few replies in the ticket, and strong doubts as to whether this is really
 useful, I'll close the ticket as "wontfix".

 `title` can already be customized with
 `verbose_name`/`verbose_name_plural` and using `field-elements`/`table-
 body`/`table-headers` will force users to rewrite almost the entire
 template, so they are not very useful either.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018becab989b-96c082ae-02ca-4567-a8c9-4d8bb6aa6c02-00%40eu-central-1.amazonses.com.

Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
-+-
 Reporter:  Simon Meers  |Owner:
 |  abdulrahman
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  template, block, | Triage Stage:  Accepted
  inheritance|
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701890a771518-555ff65c-e718-449e-a67e-f9ea03eb6ede-00%40eu-central-1.amazonses.com.

Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
-+-
 Reporter:  Simon Meers  |Owner:
 |  abdulrahman
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  template, block, | Triage Stage:  Accepted
  inheritance|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by abdulrahman):

 * has_patch:  0 => 1


Comment:

 The pull request:
 https://github.com/django/django/pull/17030

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701890900ac0a-469fc7d1-7cf1-4db8-b398-87dd0bd8e74b-00%40eu-central-1.amazonses.com.

Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
-+-
 Reporter:  Simon Meers  |Owner:
 |  abdulrahman
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  template, block, | Triage Stage:  Accepted
  inheritance|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by abdulrahman:

Old description:

> This has been bugging me for years, but I've not spotted a matching
> ticket as yet. The `admin/edit-inline/(stacked|tabular).html` templates
> do no contain a single `{% block %}`, and are therefore quite useless
> when it comes to template inheritance. It is a common requirement to
> tweak a small fragment of these templates, but this cannot be done in a
> DRY manner at present.
>
> I propose tidying up these templates and breaking them down into blocks
> to solve this. More than happy to write the code, just thought I'd raise
> it here first to make sure I hadn't missed anything.

New description:

 This has been bugging me for years, but I've not spotted a matching ticket
 as yet. The `admin/edit-inline/(stacked|tabular).html` templates do not
 contain a single `{% block %}`, and are therefore quite useless when it
 comes to template inheritance. It is a common requirement to tweak a small
 fragment of these templates, but this cannot be done in a DRY manner at
 present.

 I propose tidying up these templates and breaking them down into blocks to
 solve this. More than happy to write the code, just thought I'd raise it
 here first to make sure I hadn't missed anything.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018907a4400d-386f1a8d-9c8d-4e25-a70f-f5a947a8eb12-00%40eu-central-1.amazonses.com.

Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
-+-
 Reporter:  Simon Meers  |Owner:
 |  abdulrahman
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  template, block, | Triage Stage:  Accepted
  inheritance|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by abdulrahman):

 * owner:  Simon Meers => abdulrahman
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018612ce2342-bb985dd1-0b0b-4fae-bbd3-a14546ce08c9-00%40eu-central-1.amazonses.com.

Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
-+-
   Reporter:  DrMeers|Owner:  DrMeers
   Type:  New|   Status:  new
  feature|Component:  contrib.admin
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  template, block,
 Resolution: |  inheritance
   Triage Stage:  Accepted   |Has patch:  0
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by anonymous):

 * type:   => New feature
 * severity:   => Normal
 * milestone:  1.3 =>


Comment:

 Calling it a new feature as it's providing new 'functionality' for admin
 template developers.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
---+
  Reporter:  DrMeers   | Owner:  DrMeers
 
Status:  new   | Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:|  Keywords:  template, block, 
inheritance
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by anonymous):

 * cc: sehmasch...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14810: Admin inline templates need blocks

[Django]

#14810: Admin inline templates need blocks
---+
  Reporter:  DrMeers   | Owner:  DrMeers
 
Status:  new   | Milestone:  1.3
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:|  Keywords:  template, block, 
inheritance
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I'm fairly certain I've seen a similar ticket floating around before -- if
 not specifically about edit-inline, then about other aspects of the admin
 that could be made more modular.

 Accepting on the basis that it's a good idea; if anyone knows or discovers
 the antecedent ticket, feel free to close this one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.