Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+
 Reporter:  vzima |Owner:  vzima
 Type:  New feature   |   Status:  closed
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by akaariai):

 There is a ticket about this regression, see #21473. The suggested
 solution is to not flush language from session on logout.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0cfe6e7411c4cebc2961612f6987e2f1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+
 Reporter:  vzima |Owner:  vzima
 Type:  New feature   |   Status:  closed
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by dave@…):

 This change has made multi-language testing much more difficult for
 authenticated Django applications.

 Prior to this commit, my QA team could follow this simple process to
 switch languages during testing:

 1. Switch language in browser settings
 2. Refresh page
 3. Test

 Now, they must do this:

 1. Switch language in browser settings.
 2. Clear session cookie
 3. Re-authenticate
 4. Navigate to page under test
 5. Test

 This behavior seems ok for the average user (whose language doesn't change
 minute to minute), but for a tester, this really makes things slow. Even
 test automation suffers (e.g., Selenium).

 Could we at least put this behavior being a setting? Something like
 setting.STORE_LANGUAGE_IN_SESSION = True|False (default True)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.47fd4d054dc5acbc1e3ec22a1d27317a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+
 Reporter:  vzima |Owner:  vzima
 Type:  New feature   |   Status:  closed
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6de81d65f443a01961c23139ca5d7653ef012d35"]:
 {{{
 #!CommitTicketReference repository=""
 revision="6de81d65f443a01961c23139ca5d7653ef012d35"
 Fixed #14825 -- LocaleMiddleware keeps language

  * LocaleMiddleware stores language into session if it is not present
 there.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.5cc357ad3b11b56c5bdcc654edc7ce45%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+
 Reporter:  vzima |Owner:  vzima
 Type:  New feature   |   Status:  assigned
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aaugustin):

 This looks good to me. Unfortunately the patch no longer applies after the
 sprints we just had. Could you bring it up to date and mark it as RFC once
 that's done? (Since I reviewed an almost final version, as an exception,
 you can mark it as RFC by yourself.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+
 Reporter:  vzima |Owner:  vzima
 Type:  New feature   |   Status:  assigned
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by charettes):

 * version:  1.2 => master
 * stage:  Ready for checkin => Accepted


Comment:

 Please don't mark your own patch as RFC, someone else should review your
 work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
-+-
 Reporter:  vzima|Owner:  vzima
 Type:  New feature  |   Status:  assigned
Component:   |  Version:  1.2
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by vzima):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+
 Reporter:  vzima |Owner:  vzima
 Type:  New feature   |   Status:  assigned
Component:  Internationalization  |  Version:  1.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by vzima):

 * status:  new => assigned
 * needs_better_patch:  1 => 0
 * owner:  nobody => vzima
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


Comment:

 I updated the patch and created a pull request
 https://github.com/django/django/pull/957

 I also realised that this only affects sessions. `LocaleMiddleware` should
 not touch the language cookie in this case, because it is not changed by
 session flush.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+
 Reporter:  vzima |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Internationalization  |  Version:  1.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by aaugustin):

 * stage:  Design decision needed => Accepted


Comment:

 This is a reasonable short-term workaround. #15902 will certainly take
 more time.

 The patch is a good starting point, but it needs tests. Also, please use
 `in` rather than `has_key`, and consider using `setdefault` where
 possible.

 I view this as a bugfix more than a new feature, but a line in the release
 notes can't hurt.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
-+-
 Reporter:  vzima|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:   |  Version:  1.2
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ramiro):

 See also #15902 and http://groups.google.com/d/topic/django-
 developers/8THmJSioj4U/discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
-+-
   Reporter:  vzima  |  Owner:  nobody
   Type:  New| Status:  new
  feature|  Component:
  Milestone: |  Internationalization
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  1
Needs documentation:  1  |  Easy pickings:  0
Patch needs improvement:  1  |
-+-
Changes (by raymond.penners@…):

 * cc: raymond.penners@… (added)
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
-+-
   Reporter:  vzima  |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  Internationalization
  Milestone: | Severity:  Normal
Version:  1.2| Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Design |  Needs tests:  1
  decision needed|
Needs documentation:  1  |
Patch needs improvement:  1  |
-+-
Changes (by anonymous):

 * type:   => New feature
 * severity:   => Normal


Comment:

 Marking as 'new feature' as it changes current behavior; please also
 consider updating relevant documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+-
   Reporter:  vzima   | Owner:  nobody
 Status:  new | Milestone:
  Component:  Internationalization|   Version:  1.2   
 Resolution:  |  Keywords:
   Triage Stage:  Design decision needed  | Has patch:  1 
Needs documentation:  1   |   Needs tests:  1 
Patch needs improvement:  1   |  
--+-

Comment (by vzima):

 I added better patch, sorry for errors in first one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
--+-
   Reporter:  vzima   | Owner:  nobody
 Status:  new | Milestone:
  Component:  Internationalization|   Version:  1.2   
 Resolution:  |  Keywords:
   Triage Stage:  Design decision needed  | Has patch:  1 
Needs documentation:  1   |   Needs tests:  1 
Patch needs improvement:  1   |  
--+-
Changes (by ramiro):

  * needs_better_patch:  0 => 1


Comment:

 Patch should be generated from the root of the tree, it isn't, and it
 seems to be in reversed patch. Also, would be nice if it has some context
 (e.g. changing its format to unified)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
-+--
  Reporter:  vzima   | Owner:  nobody
Status:  new | Milestone:
 Component:  Internationalization|   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  0   |  
-+--
Comment (by vzima):

 Replying to [comment:1 rasca]:
 > Marking this as Design Decision Needed, cause despite I understand your
 use case when the session is flushed one might argue that the chosen
 language is sensitive data that needs to be flushed.
 >
 > Another solution to your problem would be to render the "logged out"
 template before flushing the session.

 So it does not have to be the same middleware.

 I do not see the point in rendering "logged out" page, because if you
 refresh it (GET request) you get different result (with default language)
 and any other page where you go from there will also have default
 language.

 Only reasonable thing, I can think of, is call set_language after logout
 so it sets language to default before rendering the "logged out" page.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14825: LocaleMiddleware should store language preferences if possible

[Django]

#14825: LocaleMiddleware should store language preferences if possible
-+--
  Reporter:  vzima   | Owner:  nobody
Status:  new | Milestone:
 Component:  Internationalization|   Version:  1.2   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  0   |  
-+--
Changes (by rasca):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Design decision needed
  * needs_tests:  => 1
  * needs_docs:  => 1

Comment:

 Marking this as Design Decision Needed, cause despite I understand your
 use case when the session is flushed one might argue that the chosen
 language is sensitive data that needs to be flushed.

 Another solution to your problem would be to render the "logged out"
 template before flushing the session.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.