Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  stumbles
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  forms, is_valid, | Triage Stage:
  bad data   |  Unreviewed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-

Comment (by ogpcludi ):

 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.75f453bd7c29e762a73955ef04ff4c92%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  anonymous
 Type:  Uncategorized|   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  forms, is_valid, | Triage Stage:
  bad data   |  Unreviewed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by ogpcludi ):

 * owner:  stumbles => anonymous
 * status:  new => assigned


Comment:

 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.558788af6bfc0cb9ef9b103d6865a08a%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  stumbles
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  forms, is_valid, | Triage Stage:
  bad data   |  Unreviewed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by ogpcludi ):

 * status:  closed => new
 * needs_better_patch:  0 => 1
 * component:  Documentation => contrib.admin
 * resolution:  fixed =>
 * needs_tests:  0 => 1
 * version:  1.2 => master
 * needs_docs:  0 => 1
 * ui_ux:  0 => 1
 * type:  Cleanup/optimization => Uncategorized
 * stage:  Accepted => Unreviewed


Comment:

 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4dbcbe3224fe52721a93276cb86392a2%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  stumbles
 Type:  Uncategorized|   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  forms, is_valid, | Triage Stage:
  bad data   |  Unreviewed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by ogpcludi ):

 * needs_better_patch:  0 => 1
 * component:  Documentation => contrib.admin
 * needs_tests:  0 => 1
 * version:  1.2 => master
 * needs_docs:  0 => 1
 * ui_ux:  0 => 1
 * type:  Cleanup/optimization => Uncategorized
 * stage:  Accepted => Unreviewed


Comment:

 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.37e0171fb84642d1c06aafbc960b8ada%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  stumbles
 Type:  Uncategorized|   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  forms, is_valid, | Triage Stage:
  bad data   |  Unreviewed
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by ogpcludi ):

 * needs_better_patch:  0 => 1
 * component:  Documentation => contrib.admin
 * needs_tests:  0 => 1
 * version:  1.2 => master
 * needs_docs:  0 => 1
 * ui_ux:  0 => 1
 * type:  Cleanup/optimization => Uncategorized
 * stage:  Accepted => Unreviewed


Comment:

 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.379be677dc4b82e9d26936190569df1e%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  stumbles
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  1.2
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  forms, is_valid, |  Needs documentation:  0
  bad data   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by Tim Graham ):

 In [42aee6ffe5f16852347e0cf069447950e9d2ef85]:
 {{{
 #!CommitTicketReference repository=""
 revision="42aee6ffe5f16852347e0cf069447950e9d2ef85"
 [1.4.x] Fixed #14885 - Clarified that ModelForm cleaning may not fully
 complete if the form is invalid.

 Thanks Ben Sturmfels for the patch.

 Backport of 3fd89d99036696ba08dd2dd7e20a5b375f85d23b from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  stumbles
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  1.2
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  forms, is_valid, |  Needs documentation:  0
  bad data   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [3fd89d99036696ba08dd2dd7e20a5b375f85d23b]:
 {{{
 #!CommitTicketReference repository=""
 revision="3fd89d99036696ba08dd2dd7e20a5b375f85d23b"
 Fixed #14885 - Clarified that ModelForm cleaning may not fully complete if
 the form is invalid.

 Thanks Ben Sturmfels for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  stumbles
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.2
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  forms, is_valid, |  Needs documentation:  0
  bad data   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by stumbles):

 * status:  reopened => new
 * owner:  nobody => stumbles
 * has_patch:  0 => 1


Comment:

 I've added a patch to point out both that `is_valid()` causes the model
 instance to be modified in place, and also that this modification can be
 partial.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  nobody
 Type:   |   Status:  reopened
  Cleanup/optimization   |  Version:  1.2
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  forms, is_valid, |  Needs documentation:  0
  bad data   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by aaugustin):

 * type:  Bug => Cleanup/optimization
 * component:  Forms => Documentation
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Accepting as a documentation issue. We could make it clearer that calling
 `is_valid()` will update the instance passed to the `ModelForm`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
-+-
 Reporter:  italomaia|Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  forms, is_valid, | Triage Stage:
  bad data   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bronger):

 * status:  closed => reopened
 * severity:   => Normal
 * cc: bronger (added)
 * type:   => Bug
 * component:  Uncategorized => Forms
 * easy:   => 0
 * ui_ux:   => 0
 * resolution:  invalid =>


Comment:

 If necessary I will create a snippet for reproducing this, but actually
 the summary is complete: If you pass an "instance" to a model form
 constructor and later on call ".is_valid()" on that form, that given
 instance is changed in place.  Very often you don't care about this
 object.  But for example, if you want to compare the given instance with
 the new one returned by {{{my_model_form.save()}}}, changes are ''never''
 detected.

 I cannot read this behaviour from the
 [https://docs.djangoproject.com/en/dev/topics/forms/modelforms/#the-is-
 valid-method-and-errors docs].  It is not about model validation here: The
 fields are really ''updated'' and not just normalised.

 See also http://permalink.gmane.org/gmane.comp.python.django.user/132931
 and http://groups.google.com/group/django-users/msg/2e31bfaefd8351cf.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
+---
  Reporter:  italomaia  | Owner:  nobody   
Status:  closed | Milestone:   
 Component:  Uncategorized  |   Version:  1.2  
Resolution:  invalid|  Keywords:  forms, is_valid, bad data
 Stage:  Unreviewed | Has_patch:  0
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Comment (by ramiro):

 Oops, anonymous that close the ticket was me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14885: is_valid for ModelForm changes instance if instance is provided

[Django]

#14885: is_valid for ModelForm changes instance if instance is provided
+---
  Reporter:  italomaia  | Owner:  nobody   
Status:  closed | Milestone:   
 Component:  Uncategorized  |   Version:  1.2  
Resolution:  invalid|  Keywords:  forms, is_valid, bad data
 Stage:  Unreviewed | Has_patch:  0
Needs_docs:  0  |   Needs_tests:  0
Needs_better_patch:  0  |  
+---
Changes (by anonymous):

  * status:  new => closed
  * needs_better_patch:  => 0
  * resolution:  => invalid
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 It is not clear from the report what this ticket is reporting, it doesn't
 help at all that the example code isn't correct/complete:

  * The view isn't instanciating the ModelForm with request-FILES,
 something absolutely necessary when dealing with file uploads.
  * The ModelForm definition is incomplete.
  * The code seems to be using some third party
 `simple.direct_to_template()` function.
  * The validators argument value has a syntax error.

 If the OP or anyone wants to reopen this, please provide a working test
 case and a clear description of the issue at hand.

 Remember Since Django 1.2 ModelFom validation also triggers Model
 validation

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.