Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution:  fixed  |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-

Comment (by lsaffre):

 Okay, I hadn't read this page for quite some time now, and I agree that
 they are clear. So I was using an undocumented feature. I now simply
 modified my local manage.py files so I can continue the old way:
 {{{
   import os
   os.environ['DJANGO_SETTINGS_MODULE'] = 'myproject.settings'
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution:  fixed  |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-

Comment (by ShawnMilo):

 Replying to [comment:17 lsaffre]:
 > It took me a few days to understand that my problems came from this
 change. This change has also the effect that DJANGO_SETTINGS_MODULE will
 take precedence over any existing settings.py in the current directory.
 Until now I almost never set DJANGO_SETTINGS_MODULE when developing, I
 just go to "my" directory and called  manage.py. Now I must take care of
 not having accidentally DJANGO_SETTINGS_MODULE set to some other project.
 Maybe a warning would be useful.


 Where do you propose the warning should be? I think the docs are pretty
 clear that DJANGO_SETTINGS_MODULE should be authoritative. Also, when you
 run manage.py runserver the settings file being used is displayed.

 https://docs.djangoproject.com/en/1.3/topics/settings/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution:  fixed  |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by lsaffre):

 * cc: luc.saffre@… (added)


Comment:

 It took me a few days to understand that my problems came from this
 change. This change has also the effect that DJANGO_SETTINGS_MODULE will
 take precedence over any existing settings.py in the current directory.
 Until now I almost never set DJANGO_SETTINGS_MODULE when developing, I
 just go to "my" directory and called  manage.py. Now I must take care of
 not having accidentally DJANGO_SETTINGS_MODULE set to some other project.
 Maybe a warning would be useful.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution:  fixed  |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by ramiro):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16222]:
 {{{
 #!CommitTicketReference repository="" revision="16222"
 Fixed #15064 -- Made manage.py honor the existence and value of
 DJANGO_SETTINGS_MODULE env var. Thanks olau for the report and Shawn
 Milochik for a patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by d0ugal):

 * cc: dougal85@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by ShawnMilo):

 * needs_better_patch:  1 => 0


Comment:

 Patch improved. Please check. Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  1  |Needs tests:  0
 |  Easy pickings:  1
-+-

Comment (by ShawnMilo):

 {{{
 I had to add back the global_settings import that was just removed
 yesterday because my test uses it.

 The code patch is a simple one-line fix.

 Brief description of the test, since it's more complicated:

 There are three conditions that may exist when
 django.core.management.setup_environ is called.

 1. The optional kwarg original_settings_path is passed in (takes
 precedence).
action: use original_settings_path

 2. original_settings_path not passed, DJANGO_SETTINGS_MODULE in
 environment.
action: use DJANGO_SETTINGS_MODULE (fixed by this patch)

 3. original_settings_path not passed, DJANGO_SETTINGS_MODULE not
 in environment.
action: use default (was happening for #2 before this patch)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  1  |Needs tests:  0
 |  Easy pickings:  1
-+-

Comment (by ShawnMilo):

 Replying to [comment:11 SmileyChris]:
 > Clean up should happen in the `tearDown` method.
 >
 > It would also look cleaner to just not touch
 `os.environ['DJANGO_SETTINGS_MODULE']` if it's already set.
 >
 > One other take-it-or-leave-it change (since it is more correct but
 result in a bigger code change) would be to move the `settings_name`
 generation code inside the only conditional that will use it.

 Thanks. I'll put up a new patch later today.

 Shawn

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  1  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by SmileyChris):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Clean up should happen in the `tearDown` method.

 It would also look cleaner to just not touch
 `os.environ['DJANGO_SETTINGS_MODULE']` if it's already set.

 One other take-it-or-leave-it change (since it is more correct but result
 in a bigger code change) would be to move the `settings_name` generation
 code inside the only conditional that will use it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  ShawnMilo
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
-+-
Changes (by ShawnMilo):

 * owner:  nobody => ShawnMilo


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
-+-

Comment (by ShawnMilo):

 Replying to [comment:8 Alex]:
 > Do the tests always leave the environ in the same state it was before
 they began?  It's not obvious to me that they do.

 Alex,

 It did not. It does now.

 Shawn

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
-+-

Comment (by Alex):

 Do the tests always leave the environ in the same state it was before they
 began?  It's not obvious to me that they do.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
-+-

Comment (by ShawnMilo):

 Replying to [comment:6 jacob]:
 > The patch is a little bit whitespace-happy, but close enough for a
 trivial cleanup. Marking RFC.

 To be clear, is it the use of multi-line statements or too much whitespace
 around docstrings? Other than that, most of the whitespace is between
 parts of the tests for clarity. Is that counter to the community standard?
 The multi-lines were to avoid 80+ character lines.

 Shawn

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
-+-
Changes (by jacob):

 * stage:  Accepted => Ready for checkin


Comment:

 The patch is a little bit whitespace-happy, but close enough for a trivial
 cleanup. Marking RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.3|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by ShawnMilo):

 * has_patch:  0 => 1
 * version:  1.2 => 1.3
 * easy:   => 1


Comment:

 Added patch against trunk with tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |Owner:  nobody
   Type:  Bug|   Status:  new
  Milestone: |Component:  Core (Management
Version:  1.2|  commands)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  0
Patch needs improvement:  0  |  Needs tests:  0
-+-
Changes (by anonymous):

 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |Owner:  nobody
   Type: |   Status:  new
  Uncategorized  |Component:  Core (Management
  Milestone: |  commands)
Version:  1.2| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  0
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-

Comment (by gordl):

 Replying to [comment:2 gordl]:
 > And, what's worse is that when populating the settings via the command
 line, the overridden settings are never loaded.  If I have a custom set of
 settings for certain management commands
 > {{{
 > manage.py mymanagementcommand --settings=custom_settings
 > }}}
 > The settings specified are not loaded.
 Sorry, ignore this. Turns out I had some code that import used django.conf
 settings at import time that caused the standard settings.py to be used.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
-+-
   Reporter:  olau   |Owner:  nobody
   Type: |   Status:  new
  Uncategorized  |Component:  Core (Management
  Milestone: |  commands)
Version:  1.2| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  0
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by gordl):

 * cc: gordl (added)
 * type:   => Uncategorized
 * severity:   => Normal


Comment:

 And, what's worse is that when populating the settings via the command
 line, the overridden settings are never loaded.  If I have a custom set of
 settings for certain management commands
 {{{
 manage.py mymanagementcommand --settings=custom_settings
 }}}
 The settings specified are not loaded.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15064: DJANGO_SETTINGS_MODULE doesn't work with runserver

[Django]

#15064: DJANGO_SETTINGS_MODULE doesn't work with runserver
--+-
  Reporter:  olau | Owner:  nobody
Status:  new  | Milestone:
 Component:  django-admin.py  |   Version:  1.2   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  0 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * component:  Uncategorized => django-admin.py
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 There is an inconsistency here, which should be addressed. manage.py and
 django-admin.py do much more path-fiddling than is good practice, and this
 sort of bug is the result.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.