Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment

2011-06-07 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+
   Reporter:  lrekucki  |Owner:  nedbatchelder
   Type:  Bug   |   Status:  closed
  Milestone:|Component:  Internationalization
Version:  SVN   | Severity:  Normal
 Resolution:  fixed | Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+
Changes (by jezdez):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [16333]:
 {{{
 #!CommitTicketReference repository="" revision="16333"
 Fixed #7704, #14045 and #15495 -- Introduce a lexer for Javascript to fix
 multiple problems of the translation of Javascript files with xgettext.
 Many thanks to Ned Batchelder for his contribution of the JsLex library.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment

2011-04-09 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+
   Reporter:  lrekucki  |Owner:  nedbatchelder
   Type:  Bug   |   Status:  assigned
  Milestone:|Component:  Internationalization
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+

Comment (by nedbatchelder):

 Patch attached to #7704 fixes this problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment

2011-04-08 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+
   Reporter:  lrekucki  |Owner:  nedbatchelder
   Type:  Bug   |   Status:  assigned
  Milestone:|Component:  Internationalization
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+

Comment (by nedbatchelder):

 Yes, I'm working on a real patch to include a Javascript lexer.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment

2011-04-08 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+
   Reporter:  lrekucki  |Owner:  nedbatchelder
   Type:  Bug   |   Status:  assigned
  Milestone:|Component:  Internationalization
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  1 |
+
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 Patch needs improvement as per Łukasz's comment above.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment

2011-04-07 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+
   Reporter:  lrekucki  |Owner:  nedbatchelder
   Type:  Bug   |   Status:  assigned
  Milestone:|Component:  Internationalization
Version:  SVN   | Severity:  Normal
 Resolution:| Keywords:
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  0
Patch needs improvement:  0 |
+
Changes (by nedbatchelder):

 * owner:  nobody => nedbatchelder
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment

2011-02-25 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+---
   Reporter:  lrekucki  | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Internationalization  |   Version:  SVN   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by lrekucki):

  * has_patch:  0 => 1


Comment:

 The patch fixes this particular problem (and some similar to it), but it's
 not too hard to construct a valid JavaScript that gets omited or
 improperly mangled by regexps. Just a few examples:

 {{{
 #!js
 gettext("String"); // This comment won't be caught by pythonize_re and it
 contains "'" which is a string start in Perl
 /*
  * This one will be removed by the patch
  */
 gettext("/* but this one will be too */ 'cause there is no way of
 telling...");
 f(/* ... if it's different from this one */);
 }}}

 The only ''real'' fix is having a JavaScript lexer and (probaly
 simplified) parser instead of a bunch of hacky regexps. No time to do it
 right now, so maybe someone else wants to do it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment

2011-02-25 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+---
   Reporter:  lrekucki  | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Internationalization  |   Version:  SVN   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  0 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by russellm):

  * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15495: makemessages excludes all strings from Javascript after a comment (was: {{{makemessages}}} excludes all strings from Javascript after a comment)

2011-02-24 Thread Django 
#15495: makemessages excludes all strings from Javascript after a comment
+---
   Reporter:  lrekucki  | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Internationalization  |   Version:  SVN   
 Resolution:|  Keywords:
   Triage Stage:  Unreviewed| Has patch:  0 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  0 |  
+---
Changes (by lrekucki):

  * needs_docs:  => 0
  * needs_better_patch:  => 0
  * needs_tests:  => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.