Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
-+-
 Reporter:  lamby|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by ramiro):

 In [17924]:
 {{{
 #!CommitTicketReference repository="" revision="17924"
 [1.4.X] Added documentation notes about lack of database savepoints
 support when using MySQL+MyISAM.

 Refs #15507 and r17341.

 Backport of r17923.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
-+-
 Reporter:  lamby|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by ramiro):

 In [17923]:
 {{{
 #!CommitTicketReference repository="" revision="17923"
 Added documentation notes about lack of database savepoints support when
 using MySQL+MyISAM.

 Refs #15507, #18116 and r17341, r17921.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
-+-
 Reporter:  lamby|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.2
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by ramiro):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17341]:
 {{{
 #!CommitTicketReference repository="" revision="17341"
 Added support for savepoints to the MySQL DB backend.

 MySQL provides the savepoint functionality starting with version 5.0.3
 when using the MyISAM storage engine.

 Thanks lamby for the report and patch.

 Fixes #15507.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
-+-
   Reporter:  lamby  |  Owner:  nobody
   Type:  New| Status:  new
  feature|  Component:  Database layer
  Milestone: |  (models, ORM)
Version:  1.2|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by ramiro):

 * ui_ux:   => 0
 * needs_tests:  1 => 0
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
-+-
   Reporter:  lamby  |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  Database layer
  Milestone: |  (models, ORM)
Version:  1.2| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  1
Patch needs improvement:  0  |
-+-

Comment (by julien):

 See #13742 which asks for savepoints support with sqlite.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
-+-
   Reporter:  lamby  |Owner:  nobody
   Type:  New|   Status:  new
  feature|Component:  Database layer
  Milestone: |  (models, ORM)
Version:  1.2| Severity:  Normal
 Resolution: | Keywords:
   Triage Stage:  Accepted   |Has patch:  1
Needs documentation:  0  |  Needs tests:  1
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
-+-
   Reporter:  lamby  |Owner:  nobody
 Status:  new|Milestone:
  Component:  Database   |  Version:  1.2
  layer (models, ORM)| Keywords:
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by lamby):

 * needs_better_patch:  1 => 0


Comment:

 (Updated the patch a few days ago which corrected the feedback, forgot to
 unset "patch needs improvements")

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
+---
   Reporter:  lamby | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Database layer (models, ORM)  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  1 |  
+---

Comment (by TomaszZielinski):

 Replying to [comment:5 lamby]:
 >
 > > Have you verified that MySQLdb supports savepoints? I'm pretty sure
 that once I checked that and it didn't.
 >
 > We just execute "SAVEPOINT foo" SQL, no special support required (unless
 I'm missing something?).
 >

 Ah ok, then I might have missed something, I don't remember the details
 now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
+---
   Reporter:  lamby | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Database layer (models, ORM)  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  1 |  
+---

Comment (by lamby):

 > I just want to make sure that it is truly a no-op.

 From my tests it doesn't interfere with MyISAM although I have a limited
 number of MySQL versions I can test with. I did test it with innodb
 completely disabled with skip-innodb and that was fine; hopefully this is
 functionally equivalent to not compiling InnoDB in.

 > Have you verified that MySQLdb supports savepoints? I'm pretty sure that
 once I checked that and it didn't.

 We just execute "SAVEPOINT foo" SQL, no special support required (unless
 I'm missing something?).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
+---
   Reporter:  lamby | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Database layer (models, ORM)  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  1 |  
+---
Changes (by TomaszZielinski):

 * cc: tomasz.zielinski@… (added)


Comment:

 Have you verified that MySQLdb supports savepoints? I'm pretty sure that
 once I checked that and it didn't.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
+---
   Reporter:  lamby | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Database layer (models, ORM)  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  1 |  
+---

Comment (by russellm):

 Replying to [comment:2 lamby]:
 > You are right about 5.0.3 being the minimum version required, not 5.0 -
 I didn't see that paragraph in the manual. I'll update the patch now.
 >
 > We shouldn't worry about savepoints only being available for InnoDB as
 we don't even turn off COMMIT/ROLLBACK calls when doing queries against
 MyISAM tables. Besides, we can't detect "for InnoDB" it on the database
 connection level as it's a property of the table.

 Granted -- I just want to make sure that it's truly a no-op. MySQL MyISAM
 ignores transactions, and other than not having transactional behavior, it
 doesn't affect Django's internals. However, some of Django's internals use
 savepoints (get_or_create, for instance), so we need to make sure adding
 this behavior doesn't have other consequences on databases that don't
 support it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
+---
   Reporter:  lamby | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Database layer (models, ORM)  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  1 |  
+---

Comment (by lamby):

 You are right about 5.0.3 being the minimum version required, not 5.0 - I
 didn't see that paragraph in the manual. I'll update the patch now.

 We shouldn't worry about savepoints only being available for InnoDB as we
 don't even turn off COMMIT/ROLLBACK calls when doing queries against
 MyISAM tables. Besides, we can't detect "for InnoDB" it on the database
 connection level as it's a property of the table.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15507: Savepoint support for MySQL backend

[Django]

#15507: Savepoint support for MySQL backend
+---
   Reporter:  lamby | Owner:  nobody
 Status:  new   | Milestone:
  Component:  Database layer (models, ORM)  |   Version:  1.2   
 Resolution:|  Keywords:
   Triage Stage:  Accepted  | Has patch:  1 
Needs documentation:  0 |   Needs tests:  0 
Patch needs improvement:  1 |  
+---
Changes (by russellm):

  * needs_better_patch:  => 1
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0


Comment:

 If MySQL supports it, we should too.

 The patch looks good, too -- but are you sure that the feature check is
 correct? Looking at MySQL docs, it looks like savepoints became available
 at 5.0.3 -- but your feature check only inspects for 5.0. It's also a
 feature that is only available for InnoDB.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.