Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+-
Reporter: mk| Owner: SmileyChris
Type: Bug | Status: closed
Milestone:| Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution: fixed | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 |Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
+-
Comment (by SmileyChris):
No, it hasn't been. You'll either use the 1.3.X branch of the respository,
or wait for a 1.3.1 release.
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+-
Reporter: mk| Owner: SmileyChris
Type: Bug | Status: closed
Milestone:| Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution: fixed | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 |Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
+-
Comment (by anonymous):
Has the fixed version already been released to PyPI?
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+-
Reporter: mk| Owner: SmileyChris
Type: Bug | Status: closed
Milestone:| Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution: fixed | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 |Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
+-
Changes (by SmileyChris):
* needs_better_patch: 1 => 0
Comment:
After some head-scratching, I realised it was backported already in r16089
-- not sure why it wasn't linked here.
That revision also includes the change in r16044, so 1.3.X is fully up to
date.
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+-
Reporter: mk| Owner: SmileyChris
Type: Bug | Status: closed
Milestone:| Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution: fixed | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 |Needs tests: 0
Patch needs improvement: 1 | Easy pickings: 0
UI/UX: 0 |
+-
Changes (by anonymous):
* ui_ux: => 0
* easy: => 0
Comment:
Agreed, this is kind of a huge deal. The "only" parameter is kind of
useless without this.
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: closed
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution: fixed | Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 |
+---
Comment (by lukeplant):
I think this needs to be backported to 1.3.X
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: reopened
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution:| Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 |
+---
Changes (by ikelly):
* status: closed => reopened
* resolution: fixed =>
Comment:
Reopening because I'm seeing a whole bunch of errors in the tests from
this revision on. A couple of examples:
{{{
==
ERROR: test_current_site_in_context_after_login
(django.contrib.auth.tests.views.LoginTest)
--
Traceback (most recent call last):
File "C:\Python25\Lib\site-
packages\django.trunk\django\contrib\auth\tests\views.py", line 203, in
test_current_site_in_context_after_login
self.assertEqual(response.context['site'], site)
File "C:\Python25\Lib\site-
packages\django.trunk\django\template\context.py", line 55, in __getitem__
raise KeyError(key)
KeyError: 'site'
==
ERROR: test_action_column_class
(regressiontests.admin_views.tests.AdminActionsTest)
Tests that the checkbox column class is present in the response
--
Traceback (most recent call last):
File "C:\Python25\Lib\site-
packages\django.trunk\tests\regressiontests\admin_views\tests.py", line
1985, in test_action_column_class
self.assertNotEqual(response.context["action_form"], None)
File "C:\Python25\Lib\site-packages\django.trunk\django\test\utils.py",
line 42, in __getitem__
raise KeyError(key)
KeyError: 'action_form'
}}}
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: assigned
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution:| Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 |
+---
Comment (by SmileyChris):
See #15814 for the separation of the util. A review of that would be
appreciated.
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: assigned
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution:| Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 |
+---
Changes (by dfoerster):
* cc: david@… (added)
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: assigned
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution:| Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 |
+---
Comment (by SmileyChris):
Just for an update, I've been working on separating out that logic in a
separate ticket. I'll ensure the addition of the test_template_loader util
is a separate commit so it can be backported along with this one.
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: assigned
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution:| Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 1 |
+---
Changes (by julien):
* needs_better_patch: 0 => 1
Comment:
Patch can do with a little improvement as per Luke's comment above ;)
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: assigned
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution:| Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 |
+---
Changes (by mvt):
* cc: mvt (added)
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: assigned
Milestone:|Component: Template system
Version: 1.3 | Severity: Release blocker
Resolution:| Keywords:
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 |
+---
Changes (by lukeplant):
* keywords: regression =>
* severity: Normal => Release blocker
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
+---
Reporter: mk|Owner: SmileyChris
Type: Bug | Status: assigned
Milestone:|Component: Template system
Version: 1.3 | Severity: Normal
Resolution:| Keywords: regression
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 |
+---
Changes (by d1b):
* cc: d1b (added)
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+---
Reporter: mk |Owner: SmileyChris
Status: assigned |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords: regression
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 0|
---+---
Comment (by lukeplant):
@!SmileyChris:
Looks good to me, though I reckon a bit of the duplication from the
`test_template` method could be removed - perhaps a top level function
something like this (untested):
{{{
#!python
def template_loader_from_dict(template_dict):
"""Returns a custom template loader that loads templates from the
supplied dictionary"""
def test_template_loader(template_name, template_dirs=None):
try:
return (template_dict[template_name][0] , "test:%s" %
template_name)
except KeyError:
raise template.TemplateDoesNotExist(template_name)
return test_template_loader
}}}
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+---
Reporter: mk |Owner: SmileyChris
Status: assigned |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords: regression
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 0|
---+---
Comment (by SmileyChris):
Yeah, I had the same thoughts: wasn't sure about `RequestContext`s
importance but it seemed to make the most sense to keep the context
around, in case of custom subclasses.
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+---
Reporter: mk |Owner: SmileyChris
Status: assigned |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords: regression
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 0|
---+---
Comment (by mk):
Nice. I'm not sure whether we should keep RequestContext around inside {%
include only %} -- the resulting context does not fulfill any of the
promises of a RequestContext.
Maybe it's useful for custom Context subclasses though. I'm not sure
whether they are officially supported?
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+---
Reporter: mk |Owner: SmileyChris
Status: assigned |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords: regression
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 0|
---+---
Changes (by SmileyChris):
* needs_better_patch: 1 => 0
Comment:
I picked a different approach to fix the bug which keeps the original
context type still (even though it's most likely not necessary like Luke
pointed out).
Luke, can you take a once-over of the code and tests to see if that's an
ok way to do it?
Also picked up on another very minor bug (`.new()` could potentially mess
up the context since it wasn't using `values or {}`)
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+---
Reporter: mk |Owner: SmileyChris
Status: assigned |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords: regression
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 1|
---+---
Changes (by SmileyChris):
* status: new => assigned
* owner: nobody => SmileyChris
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+--
Reporter: mk |Owner: nobody
Status: new |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords: regression
Triage Stage: Accepted |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 1|
---+--
Changes (by lukeplant):
* keywords: => regression
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
AFAICS, the ``new`` method should hard-code ``Context`` rather than
``self.__class__``. That means that ``RequestContext.__init__`` does not
need to be modified.
The test needs to go somewhere more obvious - most likely a new test
method in ``Templates`` class in regressiontests/templates/tests.py
Thanks!
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+--
Reporter: mk |Owner: nobody
Status: new |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords:
Triage Stage: Unreviewed |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 0|
---+--
Comment (by mk):
Ok, patch with a really, really simple test attached.
--
Ticket URL:
Django
Re: [Django] #15721: {% include %} and RequestContext fails since r15795
#15721: {% include %} and RequestContext fails since r15795
---+--
Reporter: mk |Owner: nobody
Status: new |Milestone:
Component: Template system | Version: 1.3
Resolution: | Keywords:
Triage Stage: Unreviewed |Has patch: 1
Needs documentation: 0| Needs tests: 0
Patch needs improvement: 0|
---+--
Changes (by mk):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
This problem exists since #15572 was fixed in [15795].
--
Ticket URL:
Django
