Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-10-25 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
 Reporter:  lev.maximov@…|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.3
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
  USE_THOUSAND_SEPARATOR |  Needs documentation:  0
  prepopulated_fields|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by julien):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17033]:
 {{{
 #!CommitTicketReference repository="" revision="17033"
 Fixed #15938 -- Prevented the `max_length` number in the admin
 `prepopulated_fields` javascript to be localized when
 `USE_THOUSAND_SEPARATOR` is turned on. Thanks to Lev Maximov, Mathieu
 Agopian and feel.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-10-23 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
 Reporter:  lev.maximov@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  USE_THOUSAND_SEPARATOR |  Needs documentation:  0
  prepopulated_fields|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by aaugustin):

 Yes, that's how it works.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-10-23 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
 Reporter:  lev.maximov@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  USE_THOUSAND_SEPARATOR |  Needs documentation:  0
  prepopulated_fields|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by anonymous):

 I tried to look for override_settings documentation but I didn't find
 enough. Is it correct the use of it as follows?

 {{{
 @override_settings(USE_THOUSAND_SEPARATOR = True, USE_L10N = True)
 def test_prepopulated_maxlength_localized(self):
 """
 Regression test for #15938: if USE_THOUSAND_SEPARATOR is set, make
 sure
 that maxLength (in the javascript) is rendered without separators.
 """

 response =
 self.client.get('/test_admin/admin/admin_views/prepopulatedpostlargeslug/add/')
 self.assertContains(response, "maxLength: 1000") # instead of
 1,000

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-10-23 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
 Reporter:  lev.maximov@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  USE_THOUSAND_SEPARATOR |  Needs documentation:  0
  prepopulated_fields|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by aaugustin):

 * needs_better_patch:  0 => 1


Comment:

 Patch doesn't apply cleanly and `test_prepopulated_maxlength_localized`
 should use the `override_settings` decorator.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-10-23 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
 Reporter:  lev.maximov@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  USE_THOUSAND_SEPARATOR |  Needs documentation:  0
  prepopulated_fields|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by feel):

 * ui_ux:   => 0


Comment:

 I also report the same bug and the Lev's patch works well. Does it need to
 be flagged RFC?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-05-02 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
   Reporter: |  Owner:  nobody
  lev.maximov@…  | Status:  new
   Type:  Bug|  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  USE_THOUSAND_SEPARATOR
   Triage Stage:  Accepted   |  prepopulated_fields
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by magopian):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-05-02 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
   Reporter: |  Owner:  nobody
  lev.maximov@…  | Status:  new
   Type:  Bug|  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  USE_THOUSAND_SEPARATOR
   Triage Stage:  Accepted   |  prepopulated_fields
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  1
 |  Easy pickings:  1
-+-

Comment (by magopian):

 see #14895 for a similar issue (localization of a pk)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-05-01 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
   Reporter: |  Owner:  nobody
  lev.maximov@…  | Status:  new
   Type:  Bug|  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  USE_THOUSAND_SEPARATOR
   Triage Stage:  Accepted   |  prepopulated_fields
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  1
 |  Easy pickings:  1
-+-
Changes (by magopian):

 * needs_better_patch:  1 => 0
 * needs_tests:  0 => 1


Comment:

 Thanks lev for the update of the patch, looks good now. Sorry for that,
 but i missed the "needs tests" flag in my previous comment

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-05-01 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
   Reporter: |  Owner:  nobody
  lev.maximov@…  | Status:  new
   Type:  Bug|  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  USE_THOUSAND_SEPARATOR
   Triage Stage:  Accepted   |  prepopulated_fields
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  1  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by magopian):

 * cc: mathieu.agopian@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality

2011-05-01 Thread Django 
#15938: USE_THOUSAND_SEPARATOR breaks prepopulated_fields functionality
-+-
   Reporter: |  Owner:  nobody
  lev.maximov@…  | Status:  new
   Type:  Bug|  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  USE_THOUSAND_SEPARATOR
   Triage Stage:  Accepted   |  prepopulated_fields
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  1  |Needs tests:  0
 |  Easy pickings:  1
-+-
Changes (by magopian):

 * needs_better_patch:   => 1
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I've reproduced the issue, and can confirm everything stated in the ticket
 with one minor typo (it's {{{maxLength}}} in the javascript and not
 {{{max_length}}}).

 I'm marking this ticket as Accepted but the patch needs improvements:
 please remove the trailing comma, as it wasn't there in the first place,
 and it'll break in Internet Explorer.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.