Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
-+-
 Reporter:  cdestigter   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.comments |  Version:  SVN
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  dceu2011 | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by charettes):

 As #17256 and calls such as

 {{{#!python
 # Force the CT to be cached
 ct = ContentType.objects.get_for_model(Article)
 }}}

 in r16737 tests highlight that {{{ get_by_natural_key }}} doesn't actually
 cache anything.

 #17256's currently attached patch make sure {{{ get_by_natural_key }}}
 actually cache cts and remove the needs for {{{ get_for_model }}} calls in
 the tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
-+-
   Reporter: |  Owner:  nobody
  cdestigter | Status:  closed
   Type:  Bug|  Component:  contrib.comments
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  dceu2011
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16737]:
 {{{
 #!CommitTicketReference repository="" revision="16737"
 Fixed #16042 -- Use the content types caching in the comments contrib app.
 Thanks, ptone, Julien Phalip and Thejaswi Puthraya.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
-+-
   Reporter: |  Owner:  nobody
  cdestigter | Status:  new
   Type:  Bug|  Component:  contrib.comments
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  dceu2011
 Resolution: |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by ptone):

 * stage:  Accepted => Ready for checkin


Comment:

 Other than a missing model import in the tests (which I fixed in 16042.5),
 the submitted patch seems to solve the original problem - and demonstrates
 via tests as requested in previous comments.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:  dceu2011
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+--

Comment (by hvdklauw):

 small remark on the tests. Store the current DEBUG value in the setUp on
 self and restore it in tearDown, now you assume it's False when you start
 the tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:  dceu2011
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+--
Changes (by thejaswi_puthraya):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:  dceu2011
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  1   |  Easy pickings:  0
  UI/UX:  0   |
--+--

Comment (by julien):

 Also, the tests would be more robust if they asserted precise values
 instead of using the rather vague "`assertLess`".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:  dceu2011
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  1   |  Easy pickings:  0
  UI/UX:  0   |
--+--
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 The patch is looking good but the tests are raising a warning:

 {{{
 UserWarning: A {% csrf_token %} was used in a template, but the context
 did not provide the value.  This is usually caused by not using
 RequestContext.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:  dceu2011
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+--
Changes (by thejaswi_puthraya):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:  dceu2011
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  1
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+--
Changes (by thejaswi_puthraya):

 * needs_tests:  0 => 1


Comment:

 As per a discussion with freakyboy3742 on IRC, this requires a test that
 makes use of assertNumQueries to show the number of queries did in fact
 reduce.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:  dceu2011
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+--
Changes (by thejaswi_puthraya):

 * keywords:   => dceu2011


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+--
Changes (by thejaswi_puthraya):

 * version:  1.3 => SVN
 * needs_tests:  1 => 0
 * easy:  1 => 0
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16042: comments framework uses uncached content types

[Django]

#16042: comments framework uses uncached content types
--+--
   Reporter:  cdestigter  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.comments
Version:  1.3 |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  1
Patch needs improvement:  0   |  Easy pickings:  1
--+--
Changes (by jezdez):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.