Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by aaugustin):

 For the record this was fixed in edf7ad36faab8d45aafe1f96feaf46794de22fc1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by tome):

 * status:  new => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by tome):

 This is implemented in Django 1.5, thus this ticket is already fixed - see
 
https://docs.djangoproject.com/en/1.5/ref/contrib/admin/#django.contrib.admin.ModelAdmin.message_user

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by claudep):

 I understand now that message_user may be considered as a single point of
 indirection for all contrib.admin internal calls to the API (e.g. subclass
 ModelAdmin and override message_user to redirect all admin messages).
 Point taken for the decoupling point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by claudep):

 Replying to [comment:13 russellm]:
 > There's a good reason to keep messages_user -- it decouples admin from
 the messages app. By subclassing ModelAdmin, you can completely replace
 the use of Django's messages with any other scheme you wish; if you call
 the messages API directly, this obviously isn't possible.

 If by decouple, you mean avoid installing contrib.messages at all, it is
 probably already ruined by the contrib.messages import in options.py. And
 if you want to use your own messaging framework, you don't need
 message_user API for that. The only remaining use-case I can see, would be
 an external app providing a subclassed ModelAdmin that redirects
 message_user to another messages framework. At this point, I wonder if
 this external app would not simply instruct you to send messages with its
 custom messages framework in the first place. In summary, I'm struggling
 to find real use cases for that, but of course, I may miss some obvious
 uses.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by russellm):

 Replying to [comment:12 claudep]:
 > So a proposal would be to simply deprecate the method and suggest using
 the contrib.messages API directly. Other opinions?

 There's a good reason to keep messages_user -- it decouples admin from the
 messages app. By subclassing ModelAdmin, you can completely replace the
 use of Django's messages with any other scheme you wish; if you call the
 messages API directly, this obviously isn't possible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by claudep):

 Replying to [comment:11 sbaechler]:
 > If you have to import messages anyway now, isn't it easier to just use
 messages.error(request, 'foo') instead of self.message_user(request,
 'foo', level=messages.ERROR) ?
 > Especially since message_user doesn't seem to do anything but call
 messages.info().

 Fair, I admit that the message_user benefit is small. It avoids importing
 the contrib.messages when you use the default level.

 So a proposal would be to simply deprecate the method and suggest using
 the contrib.messages API directly. Other opinions?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by sbaechler):

 * cc: simon@… (added)


Comment:

 If you have to import messages anyway now, isn't it easier to just use
 messages.error(request, 'foo') instead of self.message_user(request,
 'foo', level=messages.ERROR) ?
 Especially since message_user doesn't seem to do anything but call
 messages.info().

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by H0ff1):

 * cc: H0ff1 (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by H0ff1):

 * needs_docs:  1 => 0


Comment:

 attached documentation-patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by claudep):

 * needs_docs:  0 => 1


Comment:

 message_user is documented:
 
https://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.ModelAdmin.message_user

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by H0ff1):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 Added a new WARNING-Icon and more tests

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+
Changes (by julien):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Thanks for your work on this. Some tests should be added to test the new
 functionality, i.e. that the message type can be customized. Icons/colors
 should also be adjusted for the WARNING type.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
-+-
 Reporter:  shelldweller |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  admin| Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  1
-+-
Changes (by rsiera):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by rafallo):

 * cc: rafallo (added)
 * has_patch:  0 => 1


Comment:

 message.SUCCESS has been added to every success ''message_user'' call
 and message.ERROR has been added to every ''message_user'' call where user
 try to perform action, but some conditions are not met f.e. action is not
 selected.

 I fixed some tests too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
+---
   Reporter:  shelldweller  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  SVN   |   Severity:  Normal
 Resolution:|   Keywords:  admin
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---

Comment (by ramiro):

 #15007 asked for the type of the message shown after adding a model
 instance to be ''success'' instead of ''info''. I closed it as duplicate
 of this one becasue it would provide the feature needed to set different
 types to messages related to different admin actions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
+---
   Reporter:  shelldweller  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  SVN   |   Severity:  Normal
 Resolution:|   Keywords:  admin
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---

Comment (by shelldweller):

 It appears that CSS classes and images are already there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16884: Add message level argument to ModelAdmin's message_user

[Django]

#16884: Add message level argument to ModelAdmin's message_user
+---
   Reporter:  shelldweller  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  SVN   |   Severity:  Normal
 Resolution:|   Keywords:  admin
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---
Changes (by Alex):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * component:  Uncategorized => contrib.admin
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.