Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
--+
 Reporter:  r1cky |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.contenttypes  |  Version:  1.3
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * component:  Database layer (models, ORM) => contrib.contenttypes


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6f9ffb058f65dbe5cf9472c281c238d1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Tests are not passing.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8e5fb488e7a80d3459db2de425501b4b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by gabejackson):

 * needs_better_patch:  1 => 0


Comment:

 Clean up according to review. I'm not sure the refactor of
 _check_accessor_clashes and _check_reverse_query_clashes to
 _check_clashes(check_related_query_name=True/False) leads to more legible
 code, but at least code duplication is now gone.

 Also rebased on current master.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b367b48e02c90e8dbea00d43243df341%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 I left comments for improvement on the PR. Please uncheck "Patch needs
 improvement" when you update it, thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d38d42399bf6c2d1e395cd8cf3abfe4d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by anonymous):

 * cc: 4glitch@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.47b7e96fa8e313c4f520f41b6466b028%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gabejackson):

 after some more digging, this problem hasn't been solved – it only
 vanished. Apparently, GenericRelations currently don't get check()'ed.
 This may have gotten lost during implementation of the new checks
 framework. the PR now contains 3 tests:
 - One to test that related_name will raise a TypeError when defined on
 GenericRelation
 - One to test the OPs concern of defining the same model name in two
 different apps - this no longer leads to a clash since we do not check
 related_name clashes on GenericRelation anymore (changed this code)
 - One to test that equal related_query_names still resolve in a clash when
 one or more GenericRelations define the same related_query_name to the
 same related object

 PR is updated

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c1eb0cf899c77d5497fe6b41c4eb7e61%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gabejackson):

 Wrote two tests to cover this.

 On django 1.5.1:
 {{{
 gabejackson@jax: tests# PYTHONPATH=..:$PYTHONPATH python ./runtests.py
 --settings=test_sqlite generic_relations
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 ..F...F..
 ==
 FAIL: test_generic_relation_related_name_not_allowed
 (generic_relations.tests.GenericRelationsTests)
 --
 Traceback (most recent call last):
   File
 
"/Users/gabejackson/Documents/pycharm/django-1.6.2/tests/generic_relations/tests.py",
 line 245, in test_generic_relation_related_name_not_allowed
 class InvalidGenericRelationModel(models.Model):
 AssertionError: TypeError not raised

 ==
 FAIL: test_multiple_gen_rel_with_same_class_name
 (generic_relations.tests.GenericRelationsTests)
 --
 Traceback (most recent call last):
   File
 
"/Users/gabejackson/Documents/pycharm/django-1.6.2/tests/generic_relations/tests.py",
 line 259, in test_multiple_gen_rel_with_same_class_name
 self.fail("validate() failed with: %s" % e)
 AssertionError: validate() failed with: One or more models did not
 validate:
 appone.post: Accessor for m2m field 'topic' clashes with related m2m field
 'Topic.post_set'. Add a related_name argument to the definition for
 'topic'.
 apptwo.post: Accessor for m2m field 'topic' clashes with related m2m field
 'Topic.post_set'. Add a related_name argument to the definition for
 'topic'.


 --
 Ran 9 tests in 0.107s

 FAILED (failures=2)
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

 on master:
 {{{
 Testing against Django installed in '/Users/gabejackson/Documents/pycharm
 /django-generic-rel-reverse/django'
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 .
 --
 Ran 25 tests in 0.210s

 OK
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

 Pull Request is here: [https://github.com/django/django/pull/2407]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e0b7a9e111a6cee109bf890dc87f190b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gabejackson):

 this was fixed by commit
 
[https://github.com/django/django/commit/97774429aeb54df4c09895c07cd1b09e70201f7d]
 as part of #19385

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6cc331665b0fb911225eb97978d7f903%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gabejackson):

 this will be fixed if #22207 lands.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.640a3f30e0a70fb975f966a833f65044%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
   Reporter:  r1cky  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  0
Patch needs improvement:  0  |Needs tests:  0
  UI/UX:  0  |  Easy pickings:  0
-+-

Comment (by carljm):

 Also, as part of this fix `GenericRelation` should probably be modified so
 it doesn't silently accept the useless (and problematic) `related_name`
 argument at all.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
   Reporter:  r1cky  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  0
Patch needs improvement:  0  |Needs tests:  0
  UI/UX:  0  |  Easy pickings:  0
-+-
Changes (by carljm):

 * stage:  Unreviewed => Accepted


Comment:

 This probably blocks on #16905.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

[Django]

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
   Reporter:  r1cky  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage: |   Keywords:
  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by jsocol):

 * cc: james@… (added)
 * needs_docs:   => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.