Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+-
 Reporter:  scytale|Owner:  thiderman
 Type:  New feature|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+-
Changes (by Julien Phalip ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2e2c4968f6b9b57354af7229687d179941ed74c5"]:
 {{{
 #!CommitTicketReference repository=""
 revision="2e2c4968f6b9b57354af7229687d179941ed74c5"
 Fixed #17050 -- Added some CSS class names to the admin index pages to
 facilitate per-app or per-model style customizations. Thanks to scytale
 for the report and to H0ff1 and thiderman for their work on the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+-
 Reporter:  scytale|Owner:  thiderman
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+-

Comment (by thiderman):

 Pull request updated: https://github.com/django/django/pull/535

 I removed everything from the documentation, including the release note. I
 merged the tests into the `admin_views` test and tested againt the first
 two generic models (`Actor` and `Album`). This made for a much cleaner
 patch!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+-
 Reporter:  scytale|Owner:  thiderman
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+-

Comment (by thiderman):

 I agree about the test app creation. I'll merge them into `admin_views`
 and check for some of the existing models instead.
 Should I leave the release note in or should I remove that as well?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+-
 Reporter:  scytale|Owner:  thiderman
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+-
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 Thanks a lot for the patch. It looks pretty good. I have some minor
 comments:

 * I don't think it's worth creating a separate test app for this
 (`admin_individual_ids`). Could you put those tests in `admin_views`
 instead? You might even be able to reuse existing models.
 * I'm not sure this is worth documenting at all. It's a really minor
 thing, and in the rare cases where developers might want to do this type
 of customization, they can easily inspect the DOM. So I recommend removing
 the doc from the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+-
 Reporter:  scytale|Owner:  thiderman
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+-
Changes (by thiderman):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


Comment:

 Pull request added: https://github.com/django/django/pull/535

 I'll be honest; I'm not completely sure about the documentation I added. I
 followed jezdez' advice about splitting the "Overriding templates" part
 into a more general part about customization. Feedback on that part is
 especially welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+-
 Reporter:  scytale|Owner:  thiderman
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+-
Changes (by thiderman):

 * owner:   => thiderman
 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 I'll tackle this as part of my work on the Django sprint in Stockholm.
 I'll clean up the patch, make it apply to a current master and add some
 documentation to it!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+
 Reporter:  scytale|Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by vanessagomes):

 * owner:  vanessagomes =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+
 Reporter:  scytale|Owner:  vanessagomes
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by vanessagomes):

 * owner:  nobody => vanessagomes
 * cc: vanessagomes (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+
 Reporter:  scytale|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by H0ff1):

 Made some CodeStyle fixes on the patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+
 Reporter:  scytale|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by aaugustin):

 * stage:  Unreviewed => Accepted


Comment:

 Revert spam.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+--
 Reporter:  scytale|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+--
Changes (by anonymous):

 * stage:  Accepted => Unreviewed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+
 Reporter:  scytale|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by H0ff1):

 * needs_better_patch:  1 => 0


Comment:

 I fixed it and added a Unit-Test

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17050: add id attribute to individual model divs in the admin index

[Django]

#17050: add id attribute to individual model divs in the admin index
---+
 Reporter:  scytale|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+
Changes (by julien):

 * needs_better_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 That sounds reasonable. Using slugify on the app's title would probably be
 error prone, so instead I'd simply pass the app_label through to the
 template and use that instead. Also, you'd need to prefix the id, for
 example with "app-", to be sure it doesn't conflict with other styles
 (e.g. if you have an app called "changelist").

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17050: add id attribute to individual model divs in the admin index (was: add id blah to individual msodel divs in the admin index)

[Django]

#17050: add id attribute to individual model divs in the admin index
---+--
 Reporter:  scytale|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+--
Changes (by scytale):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.