Re: [Django] #17086: humanize and markup tests modify global templatetags library state

2011-10-24 Thread Django 
#17086: humanize and markup tests modify global templatetags library state
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  contrib.humanize  |  Version:  SVN
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by carljm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17031]:
 {{{
 #!CommitTicketReference repository="" revision="17031"
 Fixed #17086 -- Removed pollution of global template-builtins from markup
 and humanize tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17086: humanize and markup tests modify global templatetags library state

2011-10-23 Thread Django 
#17086: humanize and markup tests modify global templatetags library state
--+
 Reporter:  carljm|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.humanize  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by carljm):

 Part (b) here was pure fail, there's no monkeypatching needed; if the
 contrib/humanize tests are running, that means contrib/humanize is
 installed and the template tags are available. So this is a simple fix
 (just stop using add_to_builtins and use `{% load %}` instead).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.