Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
-+-
 Reporter:  ybon |Owner:  sjaensch
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  1
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Aymeric Augustin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c2e19e26bc33d34eff57079bd1a6838ff64d9e81"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c2e19e26bc33d34eff57079bd1a6838ff64d9e81"
 Fixed #17856 -- Passed obj to get_inline_instances

 Thanks ybon, quinode and sjaensch for the patch, and Tim Graham
 for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
-+-
 Reporter:  ybon |Owner:  sjaensch
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  1
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by sjaensch):

 * stage:  Accepted => Ready for checkin


Comment:

 Done.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  sjaensch
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by quinode):

 Hey @sjaensch I just pushed a documentation update to complete your patch
 branch[[BR]]
 Please merge it and mark this as "Ready for checkin", we'll see what
 happens :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  sjaensch
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by sjaensch):

 * owner:  nobody => sjaensch


Comment:

 Hey quinode, could you (or someone else) review this small patch and mark
 the ticket as "Ready for checkin" if applicable? It would be really nice
 to fix this oversight for 1.5.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by aaugustin):

 Pull requests are a accepted as well as patches.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by quinode):

 Last version of the pull request https://github.com/django/django/pull/202
 supersedes the above patch , do we need to create a new patch here, or
 does github pull requests are now accepted in the django project workflow
 ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by sjaensch):

 On second thought: I do actually like my pull request a bit better since
 it passes the obj parameter along to the permission checking functions
 instead of just ignoring it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by sjaensch):

 * cc: sj@… (added)


Comment:

 As the author of the pull request (and the one that's to blame for the
 omission in the definition of get_inline_instances()) I can verify that
 the patch in this bug fixes the issue without introducing unwanted side
 effects. In fact it's almost identical to my independently written pull
 request. The method still works when called without the obj parameter and
 behaves exactly the same as in Django 1.4.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by aaugustin):

 #18619 was a duplicate with a pull request:
 https://github.com/django/django/pull/202

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by quinode):

 * version:  1.4-beta-1 => 1.4
 * needs_tests:  1 => 0


Comment:

 Updated and tested patch (the add_view case had been omitted)
 The patch is really simple : it adds the obj parameter to the method, and
 passes it in the three only places where the get_inline_instances is
 called. And this makes it behave just like the other ModelAdmin method.

 More can be said about the need of an entry point here. [[BR]]
 For example, this is the only clean way I found
 (https://groups.google.com/forum/?fromgroups#!topic/django-
 users/l_nsr0_ea0o) to pass the parent object instances to inlines (Inline
 classes have to be modified to get the arg, but this is another possible
 enhancement once this one exists)[[BR]]
 You need to know which object you're working on when you need to filter an
 inline form field queryset based on the parent object, a rather common
 pattern...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by quinode):

 @aaugustin : Ok, I'm looking for examples of regression tests on the other
 related methods mentioned in the ticket, I can't find any...[[BR]]
 Apart of passing another object, that will be ignored by past code, this
 code is quite simple (and works)
 Please aaugustin can you just give me an idea of what tests could be made
 here ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by mat):

 * cc: django@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by aaugustin):

 The idea is accepted, but the current patch lacks tests and docs. You can
 add them and upload a new patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by quinode):

 * cc: dguardiola@… (added)


Comment:

 What can be done to see this happen ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Twidi):

 * cc: Twidi (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by julien):

 * needs_docs:  0 => 1
 * type:  Uncategorized => New feature
 * severity:  Release blocker => Normal
 * easy:  0 => 1
 * stage:  Design decision needed => Accepted


Comment:

 It's a shame that this feature is missing, however it is too late to be
 considered for 1.4. The admin doesn't really have a strict backwards-
 compatibility policy, so we can consider fixing this in 1.5.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
-+-
 Reporter:  ybon |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:
 Severity:  Release blocker  |  1.4-beta-1
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Design
  Needs tests:  1|  decision needed
Easy pickings:  0|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Design decision needed


Comment:

 First, `get_inline_instances` wasn't introduced as a new API, but to fix a
 permission-checking bug on inlines. See r16934. Viewing it a a hook for
 admin customization is interesting :)

 Currently, it isn't documented, which makes it an internal API. And we
 don't commit to keeping backwards compatibility for internal APIs. If you
 use or override them and they change in a later version of Django, you're
 on your own -- and in this case it will be trivial to fix. That means we
 could make that change after 1.4.

 Alternatively, if we decide it's a public of "semi-public" API, and try
 not to break backwards compatibility, we need the API to be correct and
 consistent with surrounding code before it's set in stone. If we're
 choosing this path, this bug is a release blocker.

 I'm marking this as a release blocker because we must decide between (a)
 accepting to change the API after 1.4 (b) fix it now. If we choose (a)
 then it's a normal ticket, if we choose (b) then it's a release blocker.

 Given this situation, the patch being as harmless as they come, and the
 convincing (IMO) arguments of Yohan on the mailing list, I'm seriously
 tempted to make the change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by kmike):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17856: Pass "obj" parameter to get_inline_instances

[Django]

#17856: Pass "obj" parameter to get_inline_instances
---+--
 Reporter:  ybon   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  1.4-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by kmike):

 * cc: kmike84@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.