Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+-
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  closed
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  localflavor hk   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by julien):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [17886]:
 {{{
 #!CommitTicketReference repository="" revision="17886"
 Fixed #17864 -- Added Hong Kong localflavor. Thanks to mrkschan and Adrien
 Lemaire.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+-
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Fandekasp):

 Done, glad to be of help.

 I also modified the invalid error message to inform about all acceptable
 inputs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+-
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by mrkschan):

 Replying to [comment:8 Fandekasp]:

 Missed a valid testcase -


 {{{
 '8529111': '9111-',
 }}}

 Missed a invalid testcase -

 {{{
 '2111--': [error_msgs['invalid'], ]
 }}}

 i have prepared a set of comprehensive test cases - see
 http://is.gd/QE13Zs

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+-
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by julien):

 * stage:  Accepted => Ready for checkin


Comment:

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by Fandekasp):

 * cc: Fandekasp (added)
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by Fandekasp):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by Fandekasp):

 mrkschan, look at
 https://docs.djangoproject.com/en/1.3/internals/documentation/ for django-
 specific markup

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by mrkschan):

 I didn't have experience in writing proper django style docstrings. Could
 you give me hints? See attached the new patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by aaugustin):

 To work on Django, you should
 [https://docs.djangoproject.com/en/dev/topics/install/#installing-the-
 development-version checkout the source distribution].

 Tests are
 
[https://code.djangoproject.com/browser/django/trunk/tests/regressiontests/localflavor
 in tests.regressiontests.localflavor].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by mrkschan):

 Replying to [comment:2 aaugustin]:
 > I've rephrased the title to make it clearer that this patch adds a new
 country to localflavor.
 >
 > We generally don't include references to South in Django, that comment
 should be removed.
 >
 > This needs tests and docs, but they should be very easy to write, using
 other countries as examples.


 I find no test in the source distribution tarball
 (http://www.djangoproject.com/download/1.3.1/tarball/), am I looking at
 the right place?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17864: Add localflavor for Hong Kong, starting with a phone number field (was: Add Hong Kong phone number to django.contrib.localflavor.hk)

[Django]

#17864: Add localflavor for Hong Kong, starting with a phone number field
-+
 Reporter:  mrkschan@…   |Owner:  mrkschan
 Type:  New feature  |   Status:  assigned
Component:  contrib.localflavor  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  localflavor hk   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+
Changes (by aaugustin):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * easy:  0 => 1
 * needs_docs:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 I've rephrased the title to make it clearer that this patch adds a new
 country to localflavor.

 We generally don't include references to South in Django, that comment
 should be removed.

 This needs tests and docs, but they should be very easy to write, using
 other countries as examples.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.