Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+-
 Reporter:  Koen Biermans|Owner:  Arthur
 |  Rio
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  proxy contenttype| Triage Stage:  Accepted
  permission |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 This ticket is fixed but it was kept open to restore the optimization of
 f04af7080b12744c8f06fb8228ef683d556690d0 (using
 `ContentType.objects.get_for_models()`).
 [https://github.com/django/django/pull/10381 PR 10381] doesn't restore the
 optimization although it's been linked to this ticket. I tried using
 `get_for_models()` in that patch, but it doesn't work anymore because
 `create_permissions()` now uses model states (which don't have custom
 methods). Here's the error:
 {{{
   File "/home/tim/code/django/django/contrib/contenttypes/models.py", line
 89, in get_for_models
 opts_models = needed_opts.pop(ct.model_class()._meta, [])
 AttributeError: 'ContentType' object has no attribute 'model_class'
 }}}
 If someone wants to look at that optimization again, please open a new
 ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7a5156978b8bc1485f7e671f364c57fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+-
 Reporter:  Koen Biermans|Owner:  Arthur
 |  Rio
 Type:  Bug  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  proxy contenttype| Triage Stage:  Accepted
  permission |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Arthur Rio):

 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.530d8b6dcd9329805c64b4a4381f6977%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+-
 Reporter:  Koen Biermans|Owner:  Arthur
 |  Rio
 Type:  Bug  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  proxy contenttype| Triage Stage:  Accepted
  permission |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Arthur Rio):

 * status:  new => assigned
 * owner:  nobody => Arthur Rio


Comment:

 I'm going to try to address the security concerns in a new
 [https://github.com/django/django/pull/10381 pull request].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.320e903eaa456c1a5f91a304f1241124%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+-
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  proxy contenttype| Triage Stage:  Accepted
  permission |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 A newer [https://github.com/django/django/pull/4681 pull request] was
 closed as the submitter couldn't address the security concerns raised
 there. Someone else is welcome to follow up and try to address them.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e183ecbafb1b9268a31ed4deb4358a85%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+-
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  proxy contenttype| Triage Stage:  Accepted
  permission |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_docs:  0 => 1


Comment:

 Pull request was closed indicating this needs docs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.f8cf15b376840dae74730b4abc550862%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+-
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  proxy contenttype| Triage Stage:  Accepted
  permission |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by charettes):

 * keywords:   => proxy contenttype permission
 * has_patch:  0 => 1


Comment:

 Now that #18399 is fixed, I created a
 [https://github.com/django/django/pull/146 pull request] that brings back
 the `get_for_models` permission creation optimization while passing the
 test added in r17776. Note that this patch fixes #11154 at the same time
 so it includes an extra test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
--+
 Reporter:  koenb |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by aaugustin):

 * has_patch:  1 => 0
 * severity:  Release blocker => Normal


Comment:

 I'm leaving this ticket open so we remember to reactivate this
 optimization, once the situation with proxy models is improved.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  SVN
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by aaugustin):

 In [17776]:
 {{{
 #!CommitTicketReference repository="" revision="17776"
 Reverted parts of r16963 to fix a regression on the creation of
 permissions on proxy models. Refs #17904. Thanks koenb for the report and
 claudep for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  SVN
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 Unless #17648 is fixed (proxy models having their own distinct
 ContentType) and we are probably too late in the 1.4 cycle for such a
 change, reverting the optimization of r16963 is probably the safest move
 at this time.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  SVN
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by charettes):

 * cc: charette.s@… (added)


Comment:

 Actually the fix provided in #17648 would fix #11154 and this ticket,
 #14492 is really about another issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  SVN
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by ramiro):

 * version:  1.3 => SVN


Comment:

 Related tickets with pending conceptual/design decision: #11154, #17648
 and #14492.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17904: Custom permissions on proxy model no longer created

[Django]

#17904: Custom permissions on proxy model no longer created
-+
 Reporter:  koenb|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.3
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by ramiro):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 The refactoring mentioned is r16963.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.